From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Yunfei Dong <yunfei.dong@mediatek.com>,
Alexandre Courbot <acourbot@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
Irui Wang <irui.wang@mediatek.com>,
Steve Cho <stevecho@chromium.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v3, 02/13] media: mtk-vcodec: Using firmware type to separate different firmware architecture
Date: Tue, 4 Jan 2022 10:31:05 +0100 [thread overview]
Message-ID: <94e51db2-c44a-b2fe-36af-d58c9e5ca29c@collabora.com> (raw)
In-Reply-To: <20220104080138.7472-3-yunfei.dong@mediatek.com>
Il 04/01/22 09:01, Yunfei Dong ha scritto:
> MT8173 platform use vpu firmware, mt8183/mt8192 will use scp
> firmware instead, using chip name is not reasonable to separate
> different firmware architecture. Using firmware type is much better.
>
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
> Reviewed-by: Tzung-Bi Shih<tzungbi@google.com>
Hello Yunfei,
I agree with this change, it looks better as it separates behaviors in
a more generic way.
Anyway, it looks like you're removing all users of `enum mtk_chip` but, in
this case, you forgot to also remove the declaration of this enumeration
from mtk_vcodec_drv.h! :)
Can you please send a v4 with the requested removal?
so, for v4...
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2022-01-04 9:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 8:01 [PATCH v3, 00/13] media: mtk-vcodec: support for MT8192 decoder Yunfei Dong
2022-01-04 8:01 ` [PATCH v3, 01/13] media: mtk-vcodec: Add vdec enable/disable hardware helpers Yunfei Dong
2022-01-04 8:01 ` [PATCH v3, 02/13] media: mtk-vcodec: Using firmware type to separate different firmware architecture Yunfei Dong
2022-01-04 9:31 ` AngeloGioacchino Del Regno [this message]
2022-01-04 8:01 ` [PATCH v3, 03/13] media: mtk-vcodec: get capture queue buffer size from scp Yunfei Dong
2022-01-04 8:01 ` [PATCH v3, 04/13] media: mtk-vcodec: Read max resolution from dec_capability Yunfei Dong
2022-01-04 8:01 ` [PATCH v3, 05/13] media: mtk-vcodec: Call v4l2_m2m_set_dst_buffered() set capture buffer buffered Yunfei Dong
2022-01-04 8:01 ` [PATCH v3, 06/13] media: mtk-vcodec: Refactor get and put capture buffer flow Yunfei Dong
2022-01-04 8:01 ` [PATCH v3, 07/13] media: mtk-vcodec: Refactor supported vdec formats and framesizes Yunfei Dong
2022-01-04 8:01 ` [PATCH v3, 08/13] media: mtk-vcodec: Add format to support MT21C Yunfei Dong
2022-01-04 8:01 ` [PATCH v3, 09/13] media: mtk-vcodec: disable vp8 4K capability Yunfei Dong
2022-01-04 8:01 ` [PATCH v3, 10/13] media: mtk-vcodec: Fix v4l2-compliance fail Yunfei Dong
2022-01-04 8:01 ` [PATCH v3, 11/13] media: mtk-vcodec: record capture queue format type Yunfei Dong
2022-01-04 8:01 ` [PATCH v3, 12/13] media: mtk-vcodec: Extract H264 common code Yunfei Dong
2022-01-04 8:01 ` [PATCH 13/13] media: mtk-vcodec: Add h264 decoder driver for mt8192 Yunfei Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94e51db2-c44a-b2fe-36af-d58c9e5ca29c@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=benjamin.gaignard@collabora.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=irui.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=stevecho@chromium.org \
--cc=tfiga@google.com \
--cc=tiffany.lin@mediatek.com \
--cc=tzungbi@chromium.org \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).