From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B283C54FCB for ; Mon, 27 Apr 2020 15:14:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61973206CD for ; Mon, 27 Apr 2020 15:14:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728254AbgD0POF (ORCPT ); Mon, 27 Apr 2020 11:14:05 -0400 Received: from foss.arm.com ([217.140.110.172]:36874 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728252AbgD0POD (ORCPT ); Mon, 27 Apr 2020 11:14:03 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA71A31B; Mon, 27 Apr 2020 08:14:02 -0700 (PDT) Received: from [10.57.33.170] (unknown [10.57.33.170]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D9BCC3F68F; Mon, 27 Apr 2020 08:14:00 -0700 (PDT) Subject: Re: [PATCH v2 2/3] arm64: dts: rockchip: rk3399-roc-pc: Fix MMC numbering for LED triggers To: Johan Jonker , Chen-Yu Tsai Cc: devicetree , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Pavel Machek , linux-kernel , "open list:ARM/Rockchip SoC..." , Rob Herring , jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org, linux-arm-kernel , dmurphy@ti.com References: <20200427073132.29997-3-wens@kernel.org> <684132b8-4a84-8295-474b-38ccb992bba7@gmail.com> <65d15254-08da-895c-1a0c-ef6ce231b620@gmail.com> <74a984fc-ce57-211b-936c-2d77e2e642bb@gmail.com> From: Robin Murphy Message-ID: <94e7671f-2d11-b2f7-e049-b90893c61ab2@arm.com> Date: Mon, 27 Apr 2020 16:13:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2020-04-27 3:12 pm, Johan Jonker wrote: > Hi, > >>> So for fixing up the LED node names, we'd probably want the following: >>> >>> diy_led: led-0 >>> yellow_led: led-1 >>> work_led: led-2 > > Change proposal for led nodes to comply with preexisting dts. > Does this work? > > diy_led: led_0: led-0 > yellow_led: led_1: led-1 > work_led: led_2: led-2 Yuck, why? Labels are simply human-readable source annotations for the sake of referencing nodes more easily. Meaningful label names - that correlate to SoC or board components, schematic names, or physical labels on the board/device - make the DT sources easier to read, review, and maintain. There are a handful of cases where one node might have multiple labels, e.g. if two logical supply nets come from the same regulator on certain board variants, but there is zero point in defining redundant labels that just meaninglessly echo the DT's own structure. > blue: led_0: led-0 > > A check does not give any warnings. I should hope not. Labels are there to be consumed by DT compilers (and whatever symbolic overlay handlers count as... DT linkers, maybe?) - they have no business being within the scope of the bindings that define a contract for system software consuming the final DTB. Robin. > make -k ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/leds-gpio.yaml > >> >> That doesn't look pretty either. >> Would like to hear the maintainers view on how to handle other cases >> without 'led' like for example 'blue' for mk808. >> > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip >