From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F65C433F5 for ; Fri, 1 Apr 2022 09:32:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344585AbiDAJeR (ORCPT ); Fri, 1 Apr 2022 05:34:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233183AbiDAJeO (ORCPT ); Fri, 1 Apr 2022 05:34:14 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1796E26A976 for ; Fri, 1 Apr 2022 02:32:25 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id p15so4600824ejc.7 for ; Fri, 01 Apr 2022 02:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=rEnMX3kFYdJSNCFKgHrvIJeizdwWp+J/Vi4xHAvB/ms=; b=SJNd2U4dw7PTJOCbXDRPUUsMrlymsOE86fORtUCCHCEH8jMm7Zwdcu6u2KNm7eEpFH UVrouBDLphRFhYMNnmD9AiP+V1HUi0dxsqE3jvOsuKbk8+F/wG4sIVSlRdtjnlHcC0D5 iYdSIOuQdVFeRxgkPqY4rZCoGLkmcAXzJ49J6MHzHDgpmS7A0IOjwhT/EuQbmNYO6TEw Rkbs+e/bYJ8suUjuc6doxZ4Ixj8mVZVddg2KTEfUForgbMdk+w+yoQkm599wIcc2uDgb 2lKR6sd+/fZj/dgFTC96lGzSbJqJ6+lxM/4YSgnhhRj+U296gvgMQYi68h0BlCbkPjQc wgbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rEnMX3kFYdJSNCFKgHrvIJeizdwWp+J/Vi4xHAvB/ms=; b=V1RV5YFuCvalJt1CUuG1QBSkgnhcOcagXHrPCSpq1qWnxABNHtUjdATyzyw52PXNQj WZTJFvSNigez3OvDYRSTPlkVvMha3Uhj9+unb2GDfDiac4SECWeX+mNvKEyv7jAV4Eog 2aWoroHiXKA4QjNijhNaSJ/mBnuhXtO8+xgH4xt6JK0e3YjQA2lYHpkoz/Dialm5aE6c a938wwh+2Z7RkBxY9CpSy6nzI0dZ0z75KSXc3SecL4Gms9rr9Xr9g/JAjAkIiwe57Jkc tl1tmU7TjkteFO68XuWcQEZx7VtQmeQD8s+3kEoP8/WxFz5Rv2Yxa2furrpMxtKdqi9W llKA== X-Gm-Message-State: AOAM531spxFP+m+uIhGXRklquM6zus+sVUXMByHVOKKtjiZ2XGmw0yaD lJ+R8soHIMmqOXsEy21jhNK7RQ== X-Google-Smtp-Source: ABdhPJxBp9FEJqOTnq3NI8fFr4UYVz0l6hnPTbFtpsd9FK5uXnF9Lgh2ZWAtmr3NmKy2goHSRAzsjQ== X-Received: by 2002:a17:906:fc06:b0:6e0:d13f:65e4 with SMTP id ov6-20020a170906fc0600b006e0d13f65e4mr8624770ejb.71.1648805543257; Fri, 01 Apr 2022 02:32:23 -0700 (PDT) Received: from [192.168.0.169] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id e6-20020a056402190600b00413d03ac4a2sm975178edz.69.2022.04.01.02.32.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Apr 2022 02:32:22 -0700 (PDT) Message-ID: <951173dd-0d39-017c-322e-b38f693a8848@linaro.org> Date: Fri, 1 Apr 2022 11:32:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v12 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Content-Language: en-US To: =?UTF-8?B?cWluamlhblvopoPlgaVd?= Cc: "robh+dt@kernel.org" , "mturquette@baylibre.com" , "sboyd@kernel.org" , "tglx@linutronix.de" , "maz@kernel.org" , "p.zabel@pengutronix.de" , "linux@armlinux.org.uk" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" References: <84d1e5b6-caa5-cf98-a4b2-2f1ca738b795@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 01/04/2022 11:19, qinjian[覃健] wrote: >>> diff --git a/include/dt-bindings/clock/sp-sp7021.h b/include/dt-bindings/clock/sp-sp7021.h >>> new file mode 100644 >>> index 000000000..45dac6de8 >>> --- /dev/null >>> +++ b/include/dt-bindings/clock/sp-sp7021.h >>> @@ -0,0 +1,112 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>> +/* >>> + * Copyright (C) Sunplus Technology Co., Ltd. >>> + * All rights reserved. >>> + */ >>> +#ifndef _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H >>> +#define _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H >>> + >>> +#define XTAL 27000000 >>> + >>> +/* plls */ >>> +#define PLL_A 0 >>> +#define PLL_E 1 >>> +#define PLL_E_2P5 2 >>> +#define PLL_E_25 3 >>> +#define PLL_E_112P5 4 >>> +#define PLL_F 5 >>> +#define PLL_TV 6 >>> +#define PLL_TV_A 7 >>> +#define PLL_SYS 8 >>> + >>> +/* gates: mo_clken0 ~ mo_clken9 */ >>> +#define CLK_SYSTEM 0x10 >>> +#define CLK_RTC 0x12 >> >> YAML looks ok, but here comment from Arnd also applies. These should be >> regular decimal numbers incremented by one. >> >> Best regards, >> Krzysztof > > Yes, same as reset driver, these defines also mapping the hardware. > But different from reset driver, clk driver also used these defines. > If I removed this defines, I must write the proper hardware number twice in dt & driver. > It's meaningless & hard to check. Not really... just follow what most (or all) clock drivers are doing - incremental IDs. Best regards, Krzysztof