Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Harshal Dev <harshal.dev@oss.qualcomm.com>,
	Vinod Koul <vkoul@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Frank Li <Frank.Li@kernel.org>, Andy Gross <agross@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dmaengine@vger.kernel.org
Subject: Re: [PATCH v2 5/6] dt-bindings: dma: qcom,bam-dma: Increase iommus maxItems to seven
Date: Sat, 4 Jul 2026 10:37:57 +0200	[thread overview]
Message-ID: <95251d7b-fcdb-40cf-aedd-a60773eb3136@kernel.org> (raw)
In-Reply-To: <bb8f2283-93b6-4ea7-ada0-875778c89b3a@oss.qualcomm.com>

On 03/07/2026 11:01, Kuldeep Singh wrote:
> 
> 
> On 03-07-2026 14:27, Konrad Dybcio wrote:
>> On 7/3/26 10:38 AM, Kuldeep Singh wrote:
>>> On 03-07-2026 12:24, Krzysztof Kozlowski wrote:
>>>> On Thu, Jul 02, 2026 at 01:47:15AM +0530, Kuldeep Singh wrote:
>>>>> Upcoming Shikra BAM DMA uses 7 IOMMU entries and not 6, so increase the
>>>>> `iommus` maxItems constraint.
>>>>>
>>>>> Fix below error:
>>>>> dma-controller@1b04000 (qcom,bam-v1.7.4): iommus: [[25, 132, 17], [25,
>>>>
>>>> There is no dma-controller@1b04000 in DTS. Please drop all the warnings
>>>> which do not exist.
>>>
>>> Kindly check patch 6/6, it is introducing bam node with 7iommus which IP
>>> describes and hence, updated bindings before to accustom this which also
>>> helps in avoiding rob's dt-schema bot error.
>>
>> Krzysztof is saying that the error doesn't exist in the tree (because
>> the offending DTS hunk is not merged), so you shouldn't claim this fixes
>> an error, rather that Shikra simply needs it
> 
> In previous patchset, krzysztof ask was to add error in commit log and
> hence updated that.
> Maybe some misunderstanding!

From that answer you should have understood there are no warnings to be
fixed, no warnings to be mentioned, so that commit msg should have been
fixed.

Solution is not to add fake warnings in such case, like you did here.

Best regards,
Krzysztof

  reply	other threads:[~2026-07-04  8:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 20:17 [PATCH v2 0/6] Shikra: Add DT support for ICE, RNG and QCE Kuldeep Singh
2026-07-01 20:17 ` [PATCH v2 1/6] dt-bindings: crypto: qcom,inline-crypto-engine: Fix legacy/new SoC strictness split Kuldeep Singh
2026-07-03  6:51   ` Krzysztof Kozlowski
2026-07-03  8:25     ` Kuldeep Singh
2026-07-01 20:17 ` [PATCH v2 2/6] dt-bindings: crypto: qcom,inline-crypto-engine: Document Shikra ICE Kuldeep Singh
2026-07-03  6:51   ` Krzysztof Kozlowski
2026-07-03  8:17   ` Bartosz Golaszewski
2026-07-01 20:17 ` [PATCH v2 3/6] dt-bindings: crypto: qcom,prng: Document Shikra TRNG Kuldeep Singh
2026-07-03  6:52   ` Krzysztof Kozlowski
2026-07-03  8:17   ` Bartosz Golaszewski
2026-07-01 20:17 ` [PATCH v2 4/6] dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine Kuldeep Singh
2026-07-03  6:52   ` Krzysztof Kozlowski
2026-07-03  8:16   ` Bartosz Golaszewski
2026-07-01 20:17 ` [PATCH v2 5/6] dt-bindings: dma: qcom,bam-dma: Increase iommus maxItems to seven Kuldeep Singh
2026-07-03  6:54   ` Krzysztof Kozlowski
2026-07-03  8:38     ` Kuldeep Singh
2026-07-03  8:57       ` Konrad Dybcio
2026-07-03  9:01         ` Kuldeep Singh
2026-07-04  8:37           ` Krzysztof Kozlowski [this message]
2026-07-04  8:38             ` Krzysztof Kozlowski
2026-07-01 20:17 ` [PATCH v2 6/6] arm64: dts: qcom: shikra: Add ICE, TRNG and QCE nodes Kuldeep Singh
2026-07-03  8:16   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95251d7b-fcdb-40cf-aedd-a60773eb3136@kernel.org \
    --to=krzk@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=harshal.dev@oss.qualcomm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=kuldeep.singh@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox