From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 1/3] dt-bindings: mmc: Add DTS property to disable DCMDs on Arasan controllers Date: Fri, 01 Mar 2019 19:17:25 +0100 Message-ID: <9535423.1mel94qINy@phil> References: <20190301164349.60589-1-christoph.muellner@theobroma-systems.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20190301164349.60589-1-christoph.muellner@theobroma-systems.com> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Muellner Cc: robh+dt@kernel.org, mark.rutland@arm.com, shawn.lin@rock-chips.com, ulf.hansson@linaro.org, adrian.hunter@intel.com, Philipp Tomsich , Michal Simek , Douglas Anderson , Enric Balletbo i Serra , Viresh Kumar , Jeffy Chen , Shunqian Zheng , Ezequiel Garcia , Randy Li , Tony Xie , Vicente Bergas , Klaus Goger , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists List-Id: devicetree@vger.kernel.org Am Freitag, 1. März 2019, 17:43:45 CET schrieb Christoph Muellner: > Direct commands (DCMDs) are an optional feature of eMMC 5.1's command > queue engine (CQE). The Arasan eMMC 5.1 controller uses the CQHCI, > which exposes a control register bit to enable the feature. > The current implementation sets this bit unconditionally. > > This patch allows to surpress the feature activation, > by specifying the property disable-cqe-dcmd. > > Signed-off-by: Christoph Muellner > Signed-off-by: Philipp Tomsich Patch subject is needs improvement :-) . I did scratch my head a lot regarding "where is the code change" until I actually looked into the patch itself, so you probably want mmc: sdhci-of-arasan: Add DTS property to disable DCMDs or similar instead of "dt-bindings: ..." here to match the subsystem. Heiko > --- > drivers/mmc/host/sdhci-of-arasan.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index c9e3e050ccc8..88dc3f00a5be 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -832,7 +832,10 @@ static int sdhci_arasan_probe(struct platform_device *pdev) > host->mmc_host_ops.start_signal_voltage_switch = > sdhci_arasan_voltage_switch; > sdhci_arasan->has_cqe = true; > - host->mmc->caps2 |= MMC_CAP2_CQE | MMC_CAP2_CQE_DCMD; > + host->mmc->caps2 |= MMC_CAP2_CQE; > + > + if (!of_property_read_bool(np, "disable-cqe-dcmd")) > + host->mmc->caps2 |= MMC_CAP2_CQE_DCMD; > } > > ret = sdhci_arasan_add_host(sdhci_arasan); >