From: Dragan Simic <dsimic@manjaro.org>
To: Andy Yan <andyshrk@163.com>
Cc: heiko@sntech.de, krzk+dt@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: Add Cool Pi GenBook
Date: Sun, 14 Jul 2024 17:32:16 +0200 [thread overview]
Message-ID: <953e26c282874039f15f1237322c24b7@manjaro.org> (raw)
In-Reply-To: <20240714112851.1048184-1-andyshrk@163.com>
Hello Andy,
Please see a comment below.
On 2024-07-14 13:28, Andy Yan wrote:
> Add Cool Pi GenBook, a laptop powered by RK3588
>
> Cool Pi GenBook works with a mother board connect
> with CM5
>
> Signed-off-by: Andy Yan <andyshrk@163.com>
> ---
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1ef09fbfdfaf..e4f2ae9ec457 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -96,6 +96,14 @@ properties:
> - const: coolpi,pi-cm5
> - const: rockchip,rk3588
>
> + - description: Cool Pi GenBook
> + items:
> + - enum:
> + - coolpi,genbook
> + - const: coolpi,pi-cm5
The system on module (SoM) used in the GenBook is actually called GenM5,
according to the product announcement [1] and the SoM schematic. [2]
[1]
https://www.crowdsupply.com/shenzhen-tianmao-technology-co-ltd/genbook-rk3588
[2] https://wiki.cool-pi.com/notebook/coolpi-genm5-schematic-v20.pdf
> + - const: rockchip,rk3588
> +
> +
> - description: Cool Pi 4 Model B
> items:
> - const: coolpi,pi-4b
prev parent reply other threads:[~2024-07-14 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-14 11:28 [PATCH 1/2] dt-bindings: arm: rockchip: Add Cool Pi GenBook Andy Yan
2024-07-14 11:28 ` [PATCH 2/2] arm64: dts: rockchip: Add support for rk3588 GenBook Andy Yan
2024-07-14 15:27 ` Dragan Simic
2024-07-15 10:44 ` Andy Yan
2024-07-15 14:47 ` Dragan Simic
2024-07-16 10:07 ` Andy Yan
2024-07-16 13:50 ` Dragan Simic
2024-07-20 10:21 ` Dragan Simic
2024-07-20 10:45 ` Andy Yan
2024-07-14 15:32 ` Dragan Simic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=953e26c282874039f15f1237322c24b7@manjaro.org \
--to=dsimic@manjaro.org \
--cc=andyshrk@163.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).