[PATCH v1 0/2] Add support for MT8188 SCP

[PATCH v1 0/2] Add support for MT8188 SCP

[Tinghan Shen]

Tinghan Shen (2):
  dt-bindings: remoteproc: mediatek: Add binding for mt8188 scp
  remoteproc: Support MT8188 SCP

 .../devicetree/bindings/remoteproc/mtk,scp.yaml     |  2 ++
 drivers/remoteproc/mtk_scp.c                        | 13 +++++++++++++
 2 files changed, 15 insertions(+)

-- 
2.18.0

[PATCH v1 1/2] dt-bindings: remoteproc: mediatek: Add binding for mt8188 scp

[Tinghan Shen]

Add the compatible for mt8188 SCP to the binding.

Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
 Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
index eec3b9c4c713..7e091eaffc18 100644
--- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
@@ -18,6 +18,7 @@ properties:
     enum:
       - mediatek,mt8183-scp
       - mediatek,mt8186-scp
+      - mediatek,mt8188-scp
       - mediatek,mt8192-scp
       - mediatek,mt8195-scp
 
@@ -80,6 +81,7 @@ allOf:
           enum:
             - mediatek,mt8183-scp
             - mediatek,mt8186-scp
+            - mediatek,mt8188-scp
     then:
       properties:
         reg:
-- 
2.18.0

Re: [PATCH v1 1/2] dt-bindings: remoteproc: mediatek: Add binding for mt8188 scp

[Krzysztof Kozlowski]

On 15/07/2022 07:18, Tinghan Shen wrote:
> Add the compatible for mt8188 SCP to the binding.
> 
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
>  Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 2 ++


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

[PATCH v1 2/2] remoteproc: mediatek: Support MT8188 SCP

[Tinghan Shen]

MT8188 SCP has two RISC-V cores and similar to MT8195 with some
differences. The MT8188 SCP doesn't have the l1tcm and fix the
DSP EMI issue on MT8195.

Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
---
 drivers/remoteproc/mtk_scp.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index 5b2ad789e720..d421a2ccaa1e 100644
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -954,6 +954,18 @@ static const struct mtk_scp_of_data mt8186_of_data = {
 	.ipi_buf_offset = 0x3bdb0,
 };
 
+static const struct mtk_scp_of_data mt8188_of_data = {
+	.scp_clk_get = mt8195_scp_clk_get,
+	.scp_before_load = mt8192_scp_before_load,
+	.scp_irq_handler = mt8192_scp_irq_handler,
+	.scp_reset_assert = mt8192_scp_reset_assert,
+	.scp_reset_deassert = mt8192_scp_reset_deassert,
+	.scp_stop = mt8192_scp_stop,
+	.scp_da_to_va = mt8192_scp_da_to_va,
+	.host_to_scp_reg = MT8192_GIPC_IN_SET,
+	.host_to_scp_int_bit = MT8192_HOST_IPC_INT_BIT,
+};
+
 static const struct mtk_scp_of_data mt8192_of_data = {
 	.scp_clk_get = mt8192_scp_clk_get,
 	.scp_before_load = mt8192_scp_before_load,
@@ -981,6 +993,7 @@ static const struct mtk_scp_of_data mt8195_of_data = {
 static const struct of_device_id mtk_scp_of_match[] = {
 	{ .compatible = "mediatek,mt8183-scp", .data = &mt8183_of_data },
 	{ .compatible = "mediatek,mt8186-scp", .data = &mt8186_of_data },
+	{ .compatible = "mediatek,mt8188-scp", .data = &mt8188_of_data },
 	{ .compatible = "mediatek,mt8192-scp", .data = &mt8192_of_data },
 	{ .compatible = "mediatek,mt8195-scp", .data = &mt8195_of_data },
 	{},
-- 
2.18.0

Re: [PATCH v1 2/2] remoteproc: mediatek: Support MT8188 SCP

[AngeloGioacchino Del Regno]

Il 15/07/22 07:18, Tinghan Shen ha scritto:
> MT8188 SCP has two RISC-V cores and similar to MT8195 with some
> differences. The MT8188 SCP doesn't have the l1tcm and fix the
> DSP EMI issue on MT8195.
> 
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH v1 0/2] Add support for MT8188 SCP

[Mathieu Poirier]

On Fri, Jul 15, 2022 at 01:18:19PM +0800, Tinghan Shen wrote:
> 
> Tinghan Shen (2):
>   dt-bindings: remoteproc: mediatek: Add binding for mt8188 scp
>   remoteproc: Support MT8188 SCP
> 
>  .../devicetree/bindings/remoteproc/mtk,scp.yaml     |  2 ++
>  drivers/remoteproc/mtk_scp.c                        | 13 +++++++++++++
>  2 files changed, 15 insertions(+)

I have applied this set.

Thanks,
Mathieu

> 
> -- 
> 2.18.0
>