From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.227.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793093223; b=JrGSQuykXwSzVz1Di821w76l9J4V1mO/xtW0QVUTr8m+w2kJucYK6qlaEbHZPSrwwf2J b3F+KUl9Bb12GrtL4o1PTVoNZ7UyERqT4mQwcy/ixD/+sNlr8oUSB4sI4KT9ryHx81VZ9 E72ZQFA9Uj6DaqcoPPdRFsJcXLauD2vK8frtdlqqfXHfweoU7SM3kFMCA11AckarQb2Fo 8WlNSFuBvrlIh+uZ215gdjITGpmtNBkNwqzHOc2sw52axfKDGwEyJdVgQrTfY/q2MaL9Z /y8FUu+rOOLNNngeR16JfCcTI4KfLnsy0NJGIOJgb/pVZ0PTZ5wgQTqiXSVhC7UWbYw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793093223; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=h4/IEEwDZXLw/hZQAesBTnBi16Rhs6f/cohcUh8FEIY=; b=e5Qm5a2saVjQ/bF5FJUYh6IsVdOBYRiS7emgloXE71HxdWqWeOHqtjdvXL24GD2gXp+D y6MY4vDTGRsmQ/643VTEYmfY19o8a/idogC6585mRt1Q2Tz3uj+XYyJfp1bnL/hNkPXE4 ftBAqdNcq9ptzTo1zkjpOA5P0tisLAcEnhIQ9ylzsm7vn1UeTbM+wEkqdbCq33oz/hsGh rR0cnY4qVBtfAnxwU4gyHpUHCOHqCIqHRt1tZ4VjwqEwgNhhw0EZ/74J70KKGn1BcWl4X jVXLD3Pup4QTaCd+VYTN8tieTkV4a+CTHQQzhp2EmyH2FLaJj2fDAZjNEdj50DuH/5A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=cD2Yk047; arc=none smtp.remote-ip=74.125.227.130 Received: from mail-pj2-f2.google.com (mail-pj2-f2.google.com [74.125.227.130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89DC9606A31D for ; Tue, 27 Oct 2026 09:27:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 89DC9606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=cD2Yk047 Received: by mail-pj2-f2.google.com with SMTP id d9443c01a7336-2e613f813b0so7205935ad.1 for ; Tue, 27 Oct 2026 02:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1793093223; x=1793698023; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=h4/IEEwDZXLw/hZQAesBTnBi16Rhs6f/cohcUh8FEIY=; b=cD2Yk047GntO8zsfZbdXM51UwnSmlkiujCDjVKBZKHjlEC4pxvmDWLLt7xtffKKM4Z 8zB+imfN4ACLWzc1EijhmoVLfxUXQHib690/YCPcklWWxT9MXSH1GIOOSLorLaHI91YG b3rnFOL1WdDzIXN8TUlajdbY8wwjJJfkZrm8DjM0OTDLvMG/colNHSQYb4a+25wNsxbf WRPQyYNcWsfZke5O6U36AyP/bCSV4MIr3ABqlyDPCu+X+Weajhrh2yQDfBXEjXGcPm1w P/En+NESa6dRXtUXTHGEDgfI2PRplY9SX2qFXVTXdO7CMkeP8tCuSTHVuMkKKW8fxZLR PvgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793093223; x=1793698023; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=h4/IEEwDZXLw/hZQAesBTnBi16Rhs6f/cohcUh8FEIY=; b=lCO8DkcGQWWR6tneBntltLGyf19x/atvuY27JrhJ02DoGPs9OzzHF9AdAqnoyYYGtO zr/7Z+xvq/ZEgyaemCKd5lYqpTxsL8hUXMBfD7zF2XkFJc384S87kU4JtWIU4OKMKBmD NhEd2XJKqLSnAWHbPd0J0+6QirHVlpZ98cLjJngAllj/GH0Kcs5FXOw/STHjI7L2/tRY 7T4ZL219DwlVXF202hnhigLVonUFt9z8SgszYyA9AZptn9GiUidKKARP4eG2jQCpGsyl OKvHgcxinRgeyKYIsB0AYshq0YfhI5c6Jy61Xo7XTt5zma4ylhYq7xRL70Tx+dX9Uafb Br1w== X-Forwarded-Encrypted: i=1; AKwUvBysI5fUduf2dScLCX46dL/fjkWaieuazOGoJiTw7L/6qNp6HgOh0AA+WtbYe2/ozsi06BqifTRZK5EF@vger.kernel.org X-Gm-Message-State: AFq9FYKdPNKqbe293hefw4FuEG0DeeNu3ZusXs2qLfsVsZkRf2NPiMuX 55vJy+hTc37akftP5r5yC6SbHbtiiVc9LW3oTG3bwbAi4rWo62w6sp/u X-Gm-Gg: AYBFou1LI+n11aemJSRumcjalAH5dClX7cXr0oRUXE9mkVbIEP70dJeZSpGaYSXz+Cr Tr8p0kQUEDPVZuhTDtorA9shX4eShTu9DRWtjHS7cjdiY3j7AJfh1iz6hSyatcjHU1s4NBirEsN Qdg2FHp9cN1KquVXP+oF6rKihMqhxoX3Kh2ceYRt1sbXv2ITcc5St2kN/RJCu0t3lWq1yDyf2Yg Oq5601VL5ufpSQ6HZGnC2YNTKPIqv8ctkQvbwEFmCWvE/iVCIpl+/DTJOB7tLTmiwAWGG07Czo1 zYm5fy/dO+se0WxmsYGYM/3tM3BzqTVAAvBbaDiBXol4/o+sbNfzrYFihD3Px7XA0bolNCIdezK s+XPiX4AoOeO8Ukskg1gi8ATanl/h6sxF0fqS6+0SBBFToHZI4AgFIiJyZpjNc5eXlshTBBoYu3 2IMhmm1aBOueIxalmXDDv4FjVL7FMFlFmhPyEPMGqiJ0tCj04pe/aqMUK9gsHLfHsop1Dn6Q1az 6K1rMo7yfYW+c1K39Mx6A9k4QrVmrc6nVjYg0eybys/eZAZsPlQBkWtx18MtY3gcyDyL9943T1f rLO6fVafpreRZlQmBrvF4Rz1TzEB X-Received: by 2002:a17:903:19f0:b0:2e9:3dd2:a8f6 with SMTP id d9443c01a7336-2eae3942024mr14409105ad.9.1793093222853; Tue, 27 Oct 2026 02:27:02 -0700 (PDT) Received: from [0.0.0.0] ([129.126.71.118]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2eae6b7a216sm6149335ad.16.2026.10.27.02.26.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2026 02:26:59 -0700 (PDT) Message-ID: <9556e959-daf3-4c85-8794-9613e7e7a9ae@gmail.com> Date: Tue, 27 Oct 2026 17:26:44 +0800 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] cpufreq: add an Amlogic speed-bin driver To: Viresh Kumar , Jerome Brunet Cc: christian.koever-draxl@student.uibk.ac.at, neil.armstrong@linaro.org, sboyd@kernel.org, bmasney+clk@redhat.com, khilman@baylibre.com, martin.blumenstingl@googlemail.com, rafael@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, =?UTF-8?Q?Christian_Stefan_K=C3=B6v=C3=A9r-Drax?= =?UTF-8?Q?l?= References: <20261025192219.209137-1-christian.koever-draxl@student.uibk.ac.at> <20261025192219.209137-5-christian.koever-draxl@student.uibk.ac.at> <1jbj8gkff1.fsf@starbuckisacylon.baylibre.com> From: Chuan Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Viresh, Christian, Could you please hold off for now on the patches adding cpufreq driver support on S4? There are still two issues that need to be resolved first: - The clock driver currently does not support setting the CPU clock. - The CPU regulator needs some time to stabilize after the voltage is changed. Without a proper delay, the CPU clock frequency may be raised before the regulator voltage has actually reached the target value, which can hang the system. The S4 CPU regulator handling currently lacks the logic to wait for the regulator voltage to settle, so this part needs to be completed first. We are currently working on submitting our own cpufreq driver. We are considering how to address the issues above, taking into account the hardware characteristics of previous SoCs and evaluating factors such as the transition latency. S4 will be covered by that work (as well as SoCs from S4 onward, such as C3, T7, ..., A9). So please give us some time. On 10/26/2026 4:59 PM, Viresh Kumar wrote: > On 26-10-26, 09:57, Jerome Brunet wrote: >> On lun. 26 oct. 2026 at 11:00, Viresh Kumar wrote: >> >>> On 25-10-26, 20:22, christian.koever-draxl@student.uibk.ac.at wrote: >>>> From: Christian Stefan Kövér-Draxl >>>> >>>> Every S4 speed bin runs the same CPU frequencies but needs its own >>>> voltage curve, and the bin can only be read through the secure monitor. >>>> >>>> Read the bin from the firmware, select the matching >>>> "opp-microvolt-speed" property for all CPUs, then register >>>> cpufreq-dt. Bins outside the known range fall back to bin 0, which >>>> has the highest voltages. Like sun50i-cpufreq-nvmem, the driver binds >>>> on the SoC compatible and needs no node of its own, and S4 is added to >>>> the cpufreq-dt-platdev blocklist so cpufreq-dt is only created after >>>> the bin has been applied. >>>> >>>> Signed-off-by: Christian Stefan Kövér-Draxl >>>> --- >>>> MAINTAINERS | 1 + >>>> drivers/cpufreq/Kconfig.arm | 14 ++ >>>> drivers/cpufreq/Makefile | 1 + >>>> drivers/cpufreq/amlogic-cpufreq.c | 184 +++++++++++++++++++++++++++ >>>> drivers/cpufreq/cpufreq-dt-platdev.c | 2 + >>>> 5 files changed, 202 insertions(+) >>>> create mode 100644 drivers/cpufreq/amlogic-cpufreq.c >>> >>> Is it safe to apply just this one ? I can take this via the PM tree then. >> >> I would advise to wait a little for Amlogic to chime in. > > Sure, I wasn't going to wait for the maintainers to respond anyway. > -- Best regards, Chuan