From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06EBAC38142 for ; Tue, 24 Jan 2023 08:17:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232771AbjAXIRU (ORCPT ); Tue, 24 Jan 2023 03:17:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231975AbjAXIRS (ORCPT ); Tue, 24 Jan 2023 03:17:18 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70B2CDC for ; Tue, 24 Jan 2023 00:17:17 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id t18so234921wro.1 for ; Tue, 24 Jan 2023 00:17:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kLCH4vzF1S5fETKgbedPA51jeuB1hlnoXHacM1L7F8A=; b=PUCx69XU/ALNSOnNm3wvq0dYsW6xQff+/756CSvgawj5VkarkYeNnvrg5pkIHXeJvC tH6jWQZXJGE7SPgHqrLg7MYzAdvLRGLlYUkq5Ip8xwrNY1UH11hLEN22hByAXNFspFKz aZiO/3UlZaGGnmfbNQVMLEqgOxtE/FItMeLb3VFNY6HFcQIqWYJKC82PhT8+A4lF1xzN ives3T43i1wpt4rZaeNlGoK12ltSem8VVpphw5DSpJkrSdkNYAJAG+SJA/nv4iQKPwSE Hb6ajPifB6TjJitYVTr0H5+W327fGX0kdXDAr8Z8xIvJ51i/+rSc8RaavuRsdyXrWZ/k JXuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kLCH4vzF1S5fETKgbedPA51jeuB1hlnoXHacM1L7F8A=; b=HNS0vOJBsyu+D5PJYwz27qmIzNZaB/COBFYXIsLApavckgIUQJzhguPCheLn6sHUwN td6Ct5tAmM2xkJCnnTaiMGnqhv2U+sa6rKzGe6TmEKQLBbPqnTC59shhK3NDZxVOhpEU ztDQowhHG5uaIZMB1TeP4i+JkeTfN7FmW2YoaGAl1v+yrJKSYRfZhRwcDlUsZdXnKfQL vGyErT054gFwUqL2Cw5TYixTU1fkSqh4F19qfiNJJ1qGy6115lCrxaWeG0FIqD9DgQ3m f5njRhkcfNRUg2dbKaknaIqPC1b28nO7ItdRFNzvYVwVrMKReoEi9cGgTB+4GabtbrKH +aPA== X-Gm-Message-State: AFqh2krk3XcLIhrvPTaY/aSHqATIPrqKZImADx2XlX5J2XxWdF5SLL8B m7VK3yFaugWLd1xsQRDuBUQ8NQ== X-Google-Smtp-Source: AMrXdXuKhilEOYXCaWzj5MnYT6+XRh6z0kCNN3okw51LIYDecgd5E8Ez0G9+d3ehflLkb16p29wJdA== X-Received: by 2002:a05:6000:608:b0:2bd:db84:d663 with SMTP id bn8-20020a056000060800b002bddb84d663mr21417965wrb.5.1674548235969; Tue, 24 Jan 2023 00:17:15 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id x15-20020a5d650f000000b002bdda9856b5sm1263775wru.50.2023.01.24.00.17.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 00:17:15 -0800 (PST) Message-ID: <955f4b2a-a750-11a2-0423-72023935723b@linaro.org> Date: Tue, 24 Jan 2023 09:17:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 2/2] dt-bindings: mmc: correct pwrseq node names Content-Language: en-US To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , =?UTF-8?Q?Andreas_F=c3=a4rber?= , Manivannan Sadhasivam , Alim Akhtar , Tony Huang , Li-hao Kuo , Maxime Ripard , Adrian Hunter , Masahiro Yamada , Markus Pargmann , Wolfram Sang , Jaehoon Chung , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-tegra@vger.kernel.org, linux-actions@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20230120085722.171965-1-krzysztof.kozlowski@linaro.org> <20230120085722.171965-2-krzysztof.kozlowski@linaro.org> <2138388.Mh6RI2rZIc@diego> From: Krzysztof Kozlowski In-Reply-To: <2138388.Mh6RI2rZIc@diego> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/01/2023 10:38, Heiko Stübner wrote: > Am Freitag, 20. Januar 2023, 09:57:22 CET schrieb Krzysztof Kozlowski: >> Node names should be generic and should not contain underscores. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml | 2 +- >> Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml | 2 +- >> Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml >> index 911a5996e099..588be73168fa 100644 >> --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml >> +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml >> @@ -41,7 +41,7 @@ additionalProperties: false >> examples: >> - | >> #include >> - sdhci0_pwrseq { >> + pwrseq { > > [applicable for all 3 examples] > > hmm, power-sequences are not necessarily tied to an address and I guess > it will be very much a common case to have multiple ones on a system. > > So might it be better to follow other patterns (like leds) to number them > or suggest a "foo-pwrseq" / "pwrseq-foo"? In such cases one can add number or descriptive suffix (pwrseq-0, pwrseq-foo), just like we do for regulators. However the examples have here only one node and in such case "pwrseq" is enough. Best regards, Krzysztof