From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pratyush Brahma <quic_pbrahma@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: qcs9100: Update memory map
Date: Mon, 13 Jan 2025 13:20:22 +0100 [thread overview]
Message-ID: <95647b2a-83ff-40d1-bcc4-1b7168286a53@kernel.org> (raw)
In-Reply-To: <20250113-sa8775p-iot-memory-map-v2-2-aa2bb544706e@quicinc.com>
On 13/01/2025 13:13, Pratyush Brahma wrote:
> Update the iot specific memory map for qcs9100* boards.
>
> Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++
> arch/arm64/boot/dts/qcom/qcs9100-ride.dts | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> index 759d1ec694b20e9cead674c1bd61c6a6627eeb27..06e57239bbe975b9c0b939d438095692243e39cf 100644
> --- a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts
> @@ -5,6 +5,8 @@
> /dts-v1/;
>
> #include "sa8775p-ride-r3.dts"
> +#include "sa8775p-iot.dtsi"
No. Either this is car or iot. Cannot be both.
In other threads I already complained you add some artificial split of
DTS/DTSI and not describing the hardware. This is another example of
that - you claim you have automotive board, which is derived from
automotive board, but it is not automotive and instead it is iot.
Decide about all this and come with DTS/DTSI structure reflecting actual
hardware, not how you want to organize your device nodes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-13 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 12:13 [PATCH v2 0/3] arm64: dts: qcom: sa8775p: Update memory map for derived IOT boards Pratyush Brahma
2025-01-13 12:13 ` [PATCH v2 1/3] arm64: dts: qcom: sa8775p-iot: Introduce new memory map Pratyush Brahma
2025-01-13 12:13 ` [PATCH v2 2/3] arm64: dts: qcom: qcs9100: Update " Pratyush Brahma
2025-01-13 12:20 ` Krzysztof Kozlowski [this message]
2025-01-13 12:20 ` Krzysztof Kozlowski
2025-01-13 12:38 ` Pratyush Brahma
2025-01-13 21:32 ` Dmitry Baryshkov
2025-01-13 12:13 ` [PATCH v2 3/3] arm64: dts: qcom: qcs9075: " Pratyush Brahma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95647b2a-83ff-40d1-bcc4-1b7168286a53@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_pbrahma@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox