From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89BC6EB64DD for ; Thu, 13 Jul 2023 08:44:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233355AbjGMIoM (ORCPT ); Thu, 13 Jul 2023 04:44:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233398AbjGMInm (ORCPT ); Thu, 13 Jul 2023 04:43:42 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD2C026A0 for ; Thu, 13 Jul 2023 01:41:49 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-4fc8049fd8bso669712e87.2 for ; Thu, 13 Jul 2023 01:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689237708; x=1691829708; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ql1POIcuo0TsaMIUAHdPoB5L/Q0A6/AHhI/hDkQRujs=; b=t+TmQwgHNF5uKWW7Uxnk9AfRqeWy8tCvsF/pc9g/2NmcOXFSc5XsWxfhwihNegwkWw RF0LVByoXz5AUEQ+mTgX4KZvx6pvPtBijUDelJbDlWZjnEyyhx3qvgGcX6fIUzhRre4Z 09m+mhGwvp13v7+yzxsNopin9Do4PJ3hIi8QSdYBixlUA8RFDUjH5jKG2yeVJwSMUFOj tpoCjwmlL2U7U+NI5fdhQ7l4ds8AjXATovxVykfPt/PAEVF7tmQm3UuwJiSzhcR8+9zs E4LsBecUYzDxQrDSMjArws5hTLEZ194zHYdH+lO9jK+ciz32HWh1urgUAU0dl/J4VqKW 0AVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689237708; x=1691829708; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ql1POIcuo0TsaMIUAHdPoB5L/Q0A6/AHhI/hDkQRujs=; b=GW0B+e42DnR74Ex3JB7rhZrDGABxo+Q/7wtYz2kATRnbfNr92XlhEJnFQRSx7GjAz0 ccM1LPTa2e1TxBTipyC0pHIbu66GhgwwIlapFUV/Pan3cVn0KfGb9rvhhzCQwQsTe+KL HjVZsgv1hczwVQEfF5MivfPVw8TEG6YesPAzSjovAog/tJgTuSOy+WTr0aiXSwKoeQaS uvZMrEJ8k5xGDUdkCiAjwjGZ5qokEMwSGuOIFiHAdsq1Bp7D9oyitT3l/7kyA+u0g0pE IafJXoVGdq3uIHXZjScTK2cXokYb481/UaFs3cKH89wquFisQcdvL6Z3AgyC/4tSclRT BeEA== X-Gm-Message-State: ABy/qLZAoo3kCFE4mjWw2AhkMmeauT4X7GYXh1GBdVgSIiEPdt2A2HDi JhaBFrsEVliu7RfYJmxnmNxi/g== X-Google-Smtp-Source: APBJJlG2UJSxl2mpB4gj51oF6BFqZoTDX7kP9XHcu2MhIIGhV4rZTmSm0W8uOG4QvddLOulBKjPzbw== X-Received: by 2002:ac2:5290:0:b0:4fb:7b2a:78de with SMTP id q16-20020ac25290000000b004fb7b2a78demr708934lfm.45.1689237707997; Thu, 13 Jul 2023 01:41:47 -0700 (PDT) Received: from [192.168.1.101] (abyl63.neoplus.adsl.tpnet.pl. [83.9.31.63]) by smtp.gmail.com with ESMTPSA id f22-20020ac25336000000b004fba6f38f87sm1027447lfh.24.2023.07.13.01.41.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jul 2023 01:41:47 -0700 (PDT) Message-ID: <9587baf4-2316-494d-fbd1-73a86e742741@linaro.org> Date: Thu, 13 Jul 2023 10:41:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 8/8] arm64: dts: qcom: sm8450: provide MDSS cfg interconnect To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar , Marijn Suijten , Rob Herring , Krzysztof Kozlowski Cc: Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20230712121145.1994830-1-dmitry.baryshkov@linaro.org> <20230712121145.1994830-9-dmitry.baryshkov@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20230712121145.1994830-9-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12.07.2023 14:11, Dmitry Baryshkov wrote: > Add support for the MDSS cfg-cpu bus vote on the SM8450 platform. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index 595533aeafc4..0b01f3027ee3 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -2672,8 +2673,12 @@ mdss: display-subsystem@ae00000 { > > /* same path used twice */ > interconnects = <&mmss_noc MASTER_MDP_DISP 0 &mc_virt SLAVE_EBI1_DISP 0>, > - <&mmss_noc MASTER_MDP_DISP 0 &mc_virt SLAVE_EBI1_DISP 0>; > - interconnect-names = "mdp0-mem", "mdp1-mem"; > + <&mmss_noc MASTER_MDP_DISP 0 &mc_virt SLAVE_EBI1_DISP 0>, > + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY > + &config_noc SLAVE_DISPLAY_CFG QCOM_ICC_TAG_ACTIVE_ONLY>; Looking at icc_set_tag occurences in msm-5.10/techpack/display, I *think* active-only is only possible for the data bus (MDP-EBI) Moreover, I think Linux is supposed to cast MDSS votes through the APPS RSC (so, nodes without _DISP [1][2]) and conversely, DISP_RSC is supposed to active-only votes Konrad [1] not that it matters today because it's not implemented yet [2] https://lore.kernel.org/linux-arm-msm/20230708-topic-rpmh_icc_rsc-v1-0-b223bd2ac8dd@linaro.org > + interconnect-names = "mdp0-mem", > + "mdp1-mem", > + "cpu-cfg"; > > resets = <&dispcc DISP_CC_MDSS_CORE_BCR>; >