From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CC3CC7EE23 for ; Fri, 12 May 2023 15:31:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241895AbjELPbi (ORCPT ); Fri, 12 May 2023 11:31:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242010AbjELPbW (ORCPT ); Fri, 12 May 2023 11:31:22 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 002095BBB for ; Fri, 12 May 2023 08:30:45 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-50bc25f0c7dso18219730a12.3 for ; Fri, 12 May 2023 08:30:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683905440; x=1686497440; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Xefq3pdZcO0e8EKQ19pFTto53xIKapXB7LmHWfDyQu4=; b=B3wUVVsls0aEbOr/VInqZjyshEeKanQt80a2sIm/FNUZlIQ9xR8OUTxnSZ5AgNhS5b I1FQ37AJtyHDuRoXWZ0SB023RcQmLubkjYBsu65owCYFhe96Wq9PrjYghN8cNEXUuEiE xkIWdGT0nleZobLTdcoI7WmSrwhlUo/Fgx5W0KCyYXVfmGQW/+IVUTY0i7KMdeu+DhFU rzZKJSa+so2eE5r2DUjWbcURlNbIA3/4VzDd5lzGfeY1Gj71F/Q4WYpaiYKPBnjm9npI QW9TVbJvsF7aO6viJuxShULipefO1sPsY7zumjiUcNwoufCtOSjgdnDOKM8VywTQLcNo ti7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683905440; x=1686497440; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xefq3pdZcO0e8EKQ19pFTto53xIKapXB7LmHWfDyQu4=; b=dOeqLhUCKdav1d3sBhHhgor+s9XzbARKle3og7qea62JvzGPv9Yn9Y2z8AAsgFK0T/ XGzXhR5VUSqnlt/3QBCIhFJgCkZRSHo7CrDYFm4U3AlRPp249b78iw9gfESIxcbdni2E hvQv1CEoOzq0mYLxGdK9/oxMvTwpm4//K5dIA+4NXNs0I/Uk4R07OD38FznyDoPdNO7v FE413frPMfW36aoIgbKH1kN8vnrHr7Qyc7f3gL92X5Na0addFR9f18HgVmKdxI6MXV6z YviZEhMKsuBoypk6h97XcKkc4/70zcLDJde1wN7BsDyWN5WM6xMgGDdC/LznbLqkCfpj gWow== X-Gm-Message-State: AC+VfDx5fpvRYHWfL9Ai7Gq0vBrSNRHQ0rEVXY6tqv6tqzBrzFcSyoDi FsPr3j3izCh10hIL6ETK2e4kEg== X-Google-Smtp-Source: ACHHUZ7ox4zpEalJuln5LCdWNNjDzEjIcylFmSEdARdvEn9rrWst0L377ZSaS0MUvfliMWUYEJBOGg== X-Received: by 2002:a17:907:d16:b0:966:391b:5b3e with SMTP id gn22-20020a1709070d1600b00966391b5b3emr20842436ejc.55.1683905439693; Fri, 12 May 2023 08:30:39 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:7ede:fc7b:2328:3883? ([2a02:810d:15c0:828:7ede:fc7b:2328:3883]) by smtp.gmail.com with ESMTPSA id bn13-20020a170906c0cd00b0096599bf7029sm5588639ejb.145.2023.05.12.08.30.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 May 2023 08:30:39 -0700 (PDT) Message-ID: <9591999e-9d7f-2a4a-29df-d9c42dfa736b@linaro.org> Date: Fri, 12 May 2023 17:30:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 08/10] pinctrl: cs42l43: Add support for the cs42l43 Content-Language: en-US To: Charles Keepax , broonie@kernel.org, lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, tglx@linutronix.de, maz@kernel.org, linus.walleij@linaro.org, vkoul@kernel.org Cc: lgirdwood@gmail.com, yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230512122838.243002-1-ckeepax@opensource.cirrus.com> <20230512122838.243002-9-ckeepax@opensource.cirrus.com> From: Krzysztof Kozlowski In-Reply-To: <20230512122838.243002-9-ckeepax@opensource.cirrus.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/05/2023 14:28, Charles Keepax wrote: > The CS42L43 is an audio CODEC with integrated MIPI SoundWire interface > (Version 1.2.1 compliant), I2C, SPI, and I2S/TDM interfaces designed > for portable applications. It provides a high dynamic range, stereo > DAC for headphone output, two integrated Class D amplifiers for > loudspeakers, and two ADCs for wired headset microphone input or > stereo line input. PDM inputs are provided for digital microphones. > > Add a basic pinctrl driver which supports driver strength for the > various pins, gpios, and pinmux for the 2 multi-function pins. > > Signed-off-by: Charles Keepax ... > +{ > + struct cs42l43 *cs42l43 = dev_get_drvdata(pdev->dev.parent); > + struct cs42l43_pin *priv; > + struct pinctrl_dev *pctldev; > + int ret; > + > + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + priv->dev = &pdev->dev; > + priv->regmap = cs42l43->regmap; > + > + priv->shutters_locked = cs42l43->hw_lock; > + > + priv->gpio_chip.request = gpiochip_generic_request; > + priv->gpio_chip.free = gpiochip_generic_free; > + priv->gpio_chip.direction_input = cs42l43_gpio_direction_in; > + priv->gpio_chip.direction_output = cs42l43_gpio_direction_out; > + priv->gpio_chip.get = cs42l43_gpio_get; > + priv->gpio_chip.set = cs42l43_gpio_set; > + priv->gpio_chip.label = dev_name(priv->dev); > + priv->gpio_chip.parent = priv->dev; > + priv->gpio_chip.can_sleep = true; > + priv->gpio_chip.base = -1; > + priv->gpio_chip.ngpio = CS42L43_NUM_GPIOS; > + priv->gpio_chip.fwnode = dev_fwnode(cs42l43->dev); > + > + if (is_of_node(dev_fwnode(cs42l43->dev))) { > + device_set_node(priv->dev, > + fwnode_get_named_child_node(dev_fwnode(cs42l43->dev), > + "pinctrl")); That's something unusual. It seems you want to bind to a DT node because you miss compatible in DT node? > + } else { > + device_set_node(priv->dev, dev_fwnode(cs42l43->dev)); > + } > + > + pm_runtime_enable(priv->dev); > + pm_runtime_idle(priv->dev); > + .... > + > +static struct platform_driver cs42l43_pin_driver = { > + .driver = { > + .name = "cs42l43-pinctrl", > + }, > + > + .probe = cs42l43_pin_probe, > + .remove = cs42l43_pin_remove, > +}; > +module_platform_driver(cs42l43_pin_driver); > + > +MODULE_DESCRIPTION("CS42L43 Pinctrl Driver"); > +MODULE_AUTHOR("Charles Keepax "); > +MODULE_LICENSE("GPL"); > +MODULE_ALIAS("platform:cs42l43-pinctrl"); Same comment, so I guess you have this pattern everywhere. Best regards, Krzysztof