public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexander Koskovich <akoskovich@pm.me>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: eliza: Add IMEM node
Date: Thu, 16 Apr 2026 12:09:24 +0200	[thread overview]
Message-ID: <9592f205-7467-462b-874e-7fc599e5277a@kernel.org> (raw)
In-Reply-To: <20260416-eliza-imem-v2-3-fb7a71123451@pm.me>

On 16/04/2026 11:40, Alexander Koskovich wrote:
> Add a node for the IMEM found on Eliza, which contains pil-reloc-info
> and the modem tables for IPA, among others.
> 
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> ---
>  arch/arm64/boot/dts/qcom/eliza.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
> index 6fa5679c1a62..551df07e44c6 100644
> --- a/arch/arm64/boot/dts/qcom/eliza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
> @@ -1029,6 +1029,26 @@ qup_uart14_default: qup-uart14-default-state {
>  			};
>  		};
>  
> +		sram@14680000 {
> +			compatible = "qcom,eliza-imem", "mmio-sram";
> +			reg = <0x0 0x14680000 0x0 0x2c000>;
> +			ranges = <0x0 0x0 0x14680000 0x2c000>;
> +
> +			no-memory-wc;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			pilreloc-sram@94c {
> +				compatible = "qcom,pil-reloc-info";
> +				reg = <0x94c 0xc8>;
> +			};
> +
> +			ipa_modem_tables: modem-tables-sram@3000 {
> +				reg = <0x3000 0x2000>;

I don't think these two should be in the main SoC DTSI. The non-modem
version obviously does not have modem-tables.

Either this is part of board or common DTSI for SMxxxx SoC. Whatever is
chosen here, should be consistent with other platforms.

Best regards,
Krzysztof

  reply	other threads:[~2026-04-16 10:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16  9:39 [PATCH v2 0/3] Describe IMEM on Eliza Alexander Koskovich
2026-04-16  9:39 ` [PATCH v2 1/3] arm64: dts: qcom: eliza: Sort nodes by unit address Alexander Koskovich
2026-04-16 10:04   ` Krzysztof Kozlowski
2026-04-17  8:19   ` Konrad Dybcio
2026-04-16  9:40 ` [PATCH v2 2/3] dt-bindings: sram: Document qcom,eliza-imem Alexander Koskovich
2026-04-16 10:21   ` Krzysztof Kozlowski
2026-04-16  9:40 ` [PATCH v2 3/3] arm64: dts: qcom: eliza: Add IMEM node Alexander Koskovich
2026-04-16 10:09   ` Krzysztof Kozlowski [this message]
2026-04-16 10:15     ` Alexander Koskovich
2026-04-16 10:19     ` Konrad Dybcio
2026-04-16 10:20   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9592f205-7467-462b-874e-7fc599e5277a@kernel.org \
    --to=krzk@kernel.org \
    --cc=akoskovich@pm.me \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox