From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABF56281517; Tue, 6 May 2025 14:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746540350; cv=none; b=u+rqyzAy5GKKzE2qSi6Jf2lElh3KHYtyUS7QyjZtD670geQ9L8JQ3w5s0WC46LEHrjwmpNoSUXFi7B9SyQOpXLeDjHnre5VpmQMQtUvr4iAfbnUVaJmn7Nqc3GG+GScrvHrdF++9hTVwbQW+tY6AL2mCkNmLmENp5em/tXOiUY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746540350; c=relaxed/simple; bh=rtGooarvZfFQ6BrtD0+1cwijdv62pjdrrNWljVpj0xE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sS8FN/ojCTnwj+nEBmyrsnIQGpSK7MdOmlGMCM1BHu5GMgasmsTv8SrcTRt0DSMTl3sMG2j53acXzfDsQEs4g+qBRMDm0OuM7BSzbFj1dIdtBkrDDEHbwEdDIcht+iMuGzdWMcSgFAcwRsMshOKuH2HzT9FAeUb6CciwWbnOglQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CavGFfBw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CavGFfBw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D45F9C4CEE4; Tue, 6 May 2025 14:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746540350; bh=rtGooarvZfFQ6BrtD0+1cwijdv62pjdrrNWljVpj0xE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CavGFfBwe9eA/J6fTn0Tc/ljif6AN4LkaacNCnZkVSq3FCx6ez0zoz9ribQZvba8o sTLNzMNCwV6R3Op/hF1n1jrxZ6FW389LOKmY493/xvA1/WTja0I8V9cAvbnfWJfYd/ 9r6bmUe7lB2DppQDa75YmhaS039cyMhITVsRAgXw4I6d/YJab93M2PSaFxK25Bgy0p hnTQipJBobZ/g5oTm2MXUyDxplCbpRdEF3ShJh4IDv5qAob3BHS5IUCDN5RFue6Pm9 0AHIccSZGSkMrtjE1djQbal3DwNW7zwzHbMZAx6twgSKK5AhwP+pE+nLfs8tEq70TE P6LzEBV07MilQ== Message-ID: <959b56f0-ff63-485b-86eb-96ae32bdeb88@kernel.org> Date: Tue, 6 May 2025 16:05:46 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] dt-bindings: mfd: add bindings for QIXIS CPLD To: Ioana Ciornei Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20250430153634.2971736-1-ioana.ciornei@nxp.com> <20250430153634.2971736-2-ioana.ciornei@nxp.com> <20250502-meticulous-bulky-wildebeest-c1a8b6@kuoka> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06/05/2025 15:57, Ioana Ciornei wrote: > On Fri, May 02, 2025 at 09:01:59AM +0200, Krzysztof Kozlowski wrote: >> On Wed, Apr 30, 2025 at 06:36:29PM GMT, Ioana Ciornei wrote: >>> This adds device tree bindings for the board management controller - >>> QIXIS CPLD - found on some Layerscape based boards such as LX2160A-RDB, >>> LX2160AQDS, LS1028AQDS etc. >>> >>> Signed-off-by: Ioana Ciornei >>> --- >>> .../bindings/mfd/fsl,qixis-i2c.yaml | 65 +++++++++++++++++++ >>> 1 file changed, 65 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/mfd/fsl,qixis-i2c.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/fsl,qixis-i2c.yaml b/Documentation/devicetree/bindings/mfd/fsl,qixis-i2c.yaml >>> new file mode 100644 >>> index 000000000000..562878050916 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/mfd/fsl,qixis-i2c.yaml >> >> Filename matching compatible. > > How to choose one if there are multiple compatible strings? The fallback or the oldest or the lowest number or whichever you prefer as a base. > >> >>> @@ -0,0 +1,65 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/mfd/fsl,qixis-i2c.yaml >>> +$schema: http://devicetree.org/meta-schemas/core.yaml >>> + >>> +title: NXP's QIXIS CPLD board management controller >>> + >>> +maintainers: >>> + - Ioana Ciornei >>> + >>> +description: | >>> + The board management controller found on some Layerscape boards contains >>> + different IP blocks like GPIO controllers, interrupt controllers, reg-muxes >>> + etc. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - fsl,lx2160a-qds-qixis-i2c >>> + - fsl,lx2162a-qds-qixis-i2c >>> + - fsl,ls1028a-qds-qixis-i2c >> >> Keep alphabetical order. >> >> What is actual device name? I2C? Is this an I2C controller or device? I assume you will then drop the redundant part. >> >>> + >>> + reg: >>> + description: >>> + I2C device address. >> >> This says device, so i2c in compatible is wrong. >> >> Anyway drop description, redundant. > > Ok, will drop. > >> >> >>> + maxItems: 1 >>> + >>> + "#address-cells": >>> + const: 1 >> >> Why? >> >>> + >>> + "#size-cells": >>> + const: 0 >> >> Why? Drop cells. >> > > See below. > >>> + >>> + mux-controller: >>> + $ref: /schemas/mux/reg-mux.yaml# >>> + >>> +required: >>> + - "#address-cells" >>> + - "#size-cells" >>> + - compatible >>> + - reg >> >> Keep same order as in properties > > Ok. > >> >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + i2c { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + qixis@66 { >> >> Node names should be generic. See also an explanation and list of >> examples (not exhaustive) in DT specification: >> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > In this case, an accepted node name is 'cpld'? If this is CPLD then yes. > >> >>> + compatible = "fsl,lx2160a-qds-qixis-i2c"; >>> + reg = <0x66>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >> >> So were do you use address/size cells? >> > > For example, fsl-ls1028a-qds.dts looks like this: > > fpga@66 { > compatible = "fsl,ls1028a-qds-qixis-i2c"; > reg = <0x66>; > #address-cells = <1>; > #size-cells = <0>; > > mux: mux-controller@54 { > compatible = "reg-mux"; > reg = <0x54>; > #mux-control-cells = <1>; > mux-reg-masks = <0x54 0xf0>; /* 0: reg 0x54, bits 7:4 */ > }; > }; > > Also, some boards have in their qixis CPLD gpio controllers and I am > planning to add them as the next step. And if you tested that DTS you would see that binding does not work well... so my arguments stay valid - these properties in current binding make no sense. However binding is just wrong, so maybe these properties make sense after fixing the binding but then in both cases: current stage is not correct. > > Ioana Best regards, Krzysztof