From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EC6C26E717; Wed, 12 Nov 2025 07:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762932676; cv=none; b=YjZtgEmRmSfTpZrrk1GNkCo1J41az26J6futZTtrTwKDNPoC/Vj//eLhAOnGXWqy13UT+2wpsrnP1FGWkP046HcRjIgE99UFy1Qt3EFW3VKMu7zXEcxMGFMxzrRBrsovAWxTyBSw/A410ZSZkCZT96WpbYbJj1+lCUp386aNuPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762932676; c=relaxed/simple; bh=wRZh9AiMdIHJ/hnaT1J6UAl9Amp76jd8s8ixT0Dm+Gs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Xw4TmDVV7tZmAnM+OKqKVn5EhIkHERUrpmjEMaU1svYRBjB1FDh6qf8Vnn5p0rkVF5v7qPQO6xtu2xKsakWidG27oVacRJlKNvoy3OhY0z/J0crvBQ/KX11Xdl3d2LhvGPiThYI3vuvn+af9kfLOsBiUHOb7xN7IFiuSYjb0+ok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RzDdJCtp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RzDdJCtp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B119EC19425; Wed, 12 Nov 2025 07:31:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762932675; bh=wRZh9AiMdIHJ/hnaT1J6UAl9Amp76jd8s8ixT0Dm+Gs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RzDdJCtpDxn/y09+VtD/SqEZV2HiG6FkIIKexmUm6QR9QsHpzUyt3Sk+zIZi07Wg1 K3y3sF0Nu5HzbPC0p4I2eKHBG9pOP4CxpCDB/ukHgd13rrHOrJfeJGWTgI6ou58E63 5vP6gYZdazte/TQapthw6pvGoch6/rP4fC3ot9yEcmWrKXND+e7FJcRV3m/6SEtSI0 eD8HKiywaTrksHCFjloHjN5y73oAlplFoeUEm5rN706DrtMvR+t3L0HN62dhJBVIIq Mm+vzoVJBRTb84VhsQXCAsFR/Y9n4XLj5kYigFYTIfTj+vuwRyNlr/ZA40A3Nnbxo0 CvbRyLAdr+YfA== Message-ID: <95b61d3f-f6e8-4746-9195-cc38d8815d66@kernel.org> Date: Wed, 12 Nov 2025 08:31:11 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/5] memory: tegra186-emc: Support non-bpmp icc scaling To: Aaron Kling , Jon Hunter Cc: Rob Herring , Conor Dooley , Thierry Reding , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org References: <20251027-tegra186-icc-p2-v4-0-e4e4f57e2103@gmail.com> <20251027-tegra186-icc-p2-v4-3-e4e4f57e2103@gmail.com> <82c8dda8-6fcb-48f9-bdaa-f3d1431e41ae@nvidia.com> <99ca4992-5736-417d-854e-379542549bee@kernel.org> <7f3dad08-cff5-40c2-8e7f-f6441a3d6b91@nvidia.com> <249bbe7e-e2da-4493-bdd5-8f4b17aff8fe@nvidia.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/11/2025 08:21, Aaron Kling wrote: > On Wed, Nov 12, 2025 at 12:18 AM Jon Hunter wrote: >> >> >> On 11/11/2025 23:17, Aaron Kling wrote: >> >> ... >> >>> Alright, I think I've got the picture of what's going on now. The >>> standard arm64 defconfig enables the t194 pcie driver as a module. And >>> my simple busybox ramdisk that I use for mainline regression testing >>> isn't loading any modules. If I set the pcie driver to built-in, I >>> replicate the issue. And I don't see the issue on my normal use case, >>> because I have the dt changes as well. >>> >>> So it appears that the pcie driver submits icc bandwidth. And without >>> cpufreq submitting bandwidth as well, the emc driver gets a very low >>> number and thus sets a very low emc freq. The question becomes... what >>> to do about it? If the related dt changes were submitted to >>> linux-next, everything should fall into place. And I'm not sure where >>> this falls on the severity scale since it doesn't full out break boot >>> or prevent operation. >> >> Where are the related DT changes? If we can get these into -next and >> lined up to be merged for v6.19, then that is fine. However, we should >> not merge this for v6.19 without the DT changes. > > The dt changes are here [0]. > > This was all part of the same series, keeping everything logically > related together. But on v2, Krzysztof said that none of this should I asked you about dependencies between the patches and you said there are none, so collecting different subsystems into one is wrong. That's nothing new, standard Linux kernel process. What is non-standard here is keeping secret that there is impact on users. > have ever been together and that each subsystem should get a separate > series, even if the changes are related. Which I did, and now this is > split across three series. The actmon series for tegra210 is in a > similar state. Split across four series and only one has been pulled > to linux-next. > >> I will also talk with Thierry to see if he has any concerns about users >> seeing slow performance if they don't have an up-to-date DTB. >> >> Is there any easy way to detect if the DTB has he necessary properties >> to enable ICC scaling? > > I'm not sure there is any simple way, given how I set up tegra186 and > tegra194. The new dt properties are on the cpu nodes, there's nothing > new for the emc node. So the emc driver just unconditionally declares > itself to icc. It was doing this before too, but wouldn't do anything > on tegra186 or tegra194 because the set_bw function was just a stub > and the real logic happened in the bpmp bw mgr, which only exists on > tegra234+. Now the set_bw function will directly calculate and set the > emc clock as long as the bpmp bw mgr is not supported. Offhand, I > can't think of anything existing to check to skip this, because > nothing new in the dt has been added in the scope of emc. If your ICC triggers without users, I think it is usual case - you should not enable the sync_state but instead keep it disabled till you have all the consumers in place. Best regards, Krzysztof