From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 203CCC433EF for ; Tue, 12 Jul 2022 09:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232180AbiGLJuw (ORCPT ); Tue, 12 Jul 2022 05:50:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231761AbiGLJuv (ORCPT ); Tue, 12 Jul 2022 05:50:51 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFE68A44F6 for ; Tue, 12 Jul 2022 02:50:49 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id e28so9438757lfj.4 for ; Tue, 12 Jul 2022 02:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=FD4c+Hsdhye940ZDEYK0eytq3nanfYvmmstMbkyO/KM=; b=W5RHqZowOwhOPQ8/RfQ5YqvUbKKcnHpt1kN2nGQenjFAB7MhIu6m6uTfPb5Yhtb9nr 2Ssyeg8syQRdCjW7HIPgT93IEwq0G1hrOYIcnhTCPeDoP1ca63AJAhCwoifaGxPWjfhd Ymxri9PDqT2yw67XsU7ZkgNGq4X7OgU/3ehn31khxdpwvyzMskIHAvFf3sMHE+bHxdo3 MHOZs/U8BoXD0aF/3yCQH+1zll75Hk+j7zYlbjxsBM3H3LxauvjviWbrAaUbah1kuoyD Qm73s8514RSBUhflv1snfQ6184+nXJmHQ0CYIsbPxzBaMMd/ErBDJY5/FMjGO2SwU60y bOcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=FD4c+Hsdhye940ZDEYK0eytq3nanfYvmmstMbkyO/KM=; b=Fw5Q1Ne6fACMwG+RArvkJYwA87xzYR+tIMZZkVRrbKyvhN+4kgmI8vOr49AlHCU53c jXSQJ/ixezAqZGGsS3xdK8Zrlp9kdZY4eZ9OVCBZ0H/Um57yvxqJuLJ4Fs8/yhUer6n6 pSJM5R0L/kF49/QBJaok7VX7VtA6kaEIxKLrt8hUcq7taJ2jP9kDmjBP9janqYYO03TY bIhZb5NMP+bV9tMqYvNE/6wvO3j8o+sql1yOzWXZ4x20ubnXWm45dCoYVP5NXSqputTo UU5AmJoffHCi5s9snc398HWYd5LEi6JDgn5R2AJUkWAd1AHh6gAoz3+bDm/5ax0y4zGN VvwQ== X-Gm-Message-State: AJIora/pFaqR7VkW6OOq0CKYLiKfmJ8VCE0nj9IDnqVsFCwf1sTiNlxB rT9gyJc/KEXNLoe37csX7ejp5g== X-Google-Smtp-Source: AGRyM1t3ZG+j0jDG56+HTVYdVe2y58DlRXCAYBUR6gEBaEULs+nKR0Ll1WKpTXs0nFfxRDUTyAcA1A== X-Received: by 2002:a19:6b07:0:b0:489:c785:8dfc with SMTP id d7-20020a196b07000000b00489c7858dfcmr11265554lfa.268.1657619448133; Tue, 12 Jul 2022 02:50:48 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id v4-20020a056512348400b004795bcfe953sm2080436lfr.214.2022.07.12.02.50.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jul 2022 02:50:47 -0700 (PDT) Message-ID: <95d12b72-be9d-5503-c4ea-801303bb7776@linaro.org> Date: Tue, 12 Jul 2022 11:50:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 2/2] pinctrl: nuvoton: add NPCM8XX pinctrl and GPIO driver Content-Language: en-US To: Tomer Maimon , avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au, venture@google.com, yuenn@google.com, benjaminfair@google.com, linus.walleij@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, j.neuschaefer@gmx.net, zhengbin13@huawei.com Cc: openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220710102110.39748-1-tmaimon77@gmail.com> <20220710102110.39748-3-tmaimon77@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220710102110.39748-3-tmaimon77@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/07/2022 12:21, Tomer Maimon wrote: > Add pinctrl and GPIO controller driver support to Arbel BMC NPCM8XX SoC. > > Arbel BMC NPCM8XX pinctrl driver based on Poleg NPCM7XX, except the > pin mux mapping difference the NPCM8XX GPIO supports adjust debounce > period time. > > Signed-off-by: Tomer Maimon (...) > + > +static int npcm8xx_pinctrl_probe(struct platform_device *pdev) > +{ > + struct npcm8xx_pinctrl *pctrl; > + int ret; > + > + pctrl = devm_kzalloc(&pdev->dev, sizeof(*pctrl), GFP_KERNEL); > + if (!pctrl) > + return -ENOMEM; > + > + pctrl->dev = &pdev->dev; > + dev_set_drvdata(&pdev->dev, pctrl); > + > + pctrl->gcr_regmap = > + syscon_regmap_lookup_by_compatible("nuvoton,npcm845-gcr"); No. Use property. By this patchset, I would expect that you learnt from previous mistakes around this. Why repeating the same trouble second time? > + if (IS_ERR(pctrl->gcr_regmap)) { > + dev_err(pctrl->dev, "didn't find nuvoton,npcm845-gcr\n"); > + return PTR_ERR(pctrl->gcr_regmap); > + } > + > + ret = npcm8xx_gpio_of(pctrl); > + if (ret < 0) { > + dev_err(pctrl->dev, "Failed to gpio dt-binding %u\n", ret); > + return ret; > + } > + > + pctrl->pctldev = devm_pinctrl_register(&pdev->dev, > + &npcm8xx_pinctrl_desc, pctrl); > + if (IS_ERR(pctrl->pctldev)) { > + dev_err(&pdev->dev, "Failed to register pinctrl device\n"); > + return PTR_ERR(pctrl->pctldev); > + } > + > + ret = npcm8xx_gpio_register(pctrl); > + if (ret < 0) { > + dev_err(pctrl->dev, "Failed to register gpio %u\n", ret); > + return ret; > + } > + > + pr_info("npcm8xx Pinctrl driver probed\n"); No pr_ in devices. No success debug messages. > + return 0; > +} > + > +static const struct of_device_id npcm8xx_pinctrl_match[] = { > + { .compatible = "nuvoton,npcm845-pinctrl" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, npcm8xx_pinctrl_match); > + > +static struct platform_driver npcm8xx_pinctrl_driver = { > + .probe = npcm8xx_pinctrl_probe, > + .driver = { > + .name = "npcm8xx-pinctrl", > + .of_match_table = npcm8xx_pinctrl_match, > + .suppress_bind_attrs = true, > + }, > +}; > + > +static int __init npcm8xx_pinctrl_register(void) > +{ > + return platform_driver_register(&npcm8xx_pinctrl_driver); > +} > +arch_initcall(npcm8xx_pinctrl_register); > + > +MODULE_LICENSE("GPL v2"); > +MODULE_AUTHOR("tomer.maimon@nuvoton.com"); > +MODULE_DESCRIPTION("Nuvoton NPCM8XX Pinctrl and GPIO driver"); Best regards, Krzysztof