From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>,
"Stefan Wahren" <stefan.wahren@i2se.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>
Cc: linux-imx@nxp.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/9] ARM: dts: imx28: Clean up older DTS files
Date: Fri, 3 Feb 2023 11:16:12 +0100 [thread overview]
Message-ID: <95e3286b-8018-5cb4-80c7-7b7d77a296d3@linaro.org> (raw)
In-Reply-To: <46eb7d7e-4e44-e0d8-c591-30e06757900c@armadeus.com>
On 03/02/2023 10:44, Sébastien Szymanski wrote:
> Hello,
>
> On 2/1/23 21:33, Stefan Wahren wrote:
>> Since the imx28 belongs to the early ARM platforms which has been
>> adapted to DT, a lot of these DTS files are not in the best shape.
>> So this series tries to address this by using label references
>> and SPDX tags.
>>
>> Theses patches doesn't include functional changes. The resulting
>> DTB files has been verified with dtdiff.
>>
>> Stefan Wahren (9):
>> ARM: dts: imx28-apf28: Convert to use label references
>> ARM: dts: imx28-m28/sps1: Convert to use label references
>> ARM: dts: imx28-apx4devkit: Convert to use label references
>> ARM: dts: imx28-cfa10036: Convert to use label references
>> ARM: dts: imx28-duckbill: Convert to use label references
>> ARM: dts: imx28-duckbill-2: Include base board
>> ARM: dts: imx28-evk: Convert to use label references
>> ARM: dts: imx28-ts4600: Convert to use label references
>> ARM: dts: imx28-tx28: add SPDX-License-Identifier
>>
>> arch/arm/boot/dts/imx28-apf28.dts | 96 ++--
>> arch/arm/boot/dts/imx28-apf28dev.dts | 312 ++++++------
>> arch/arm/boot/dts/imx28-apx4devkit.dts | 380 +++++++-------
>> arch/arm/boot/dts/imx28-cfa10036.dts | 193 ++++----
>> arch/arm/boot/dts/imx28-cfa10049.dts | 454 +++++++++--------
>> arch/arm/boot/dts/imx28-cfa10055.dts | 224 +++++----
>> arch/arm/boot/dts/imx28-cfa10056.dts | 146 +++---
>> arch/arm/boot/dts/imx28-cfa10057.dts | 252 +++++-----
>> arch/arm/boot/dts/imx28-cfa10058.dts | 186 ++++---
>> arch/arm/boot/dts/imx28-duckbill-2-485.dts | 174 +------
>> .../arm/boot/dts/imx28-duckbill-2-enocean.dts | 198 +-------
>> arch/arm/boot/dts/imx28-duckbill-2-spi.dts | 211 ++------
>> arch/arm/boot/dts/imx28-duckbill-2.dts | 256 +++++-----
>> arch/arm/boot/dts/imx28-duckbill.dts | 196 ++++----
>> arch/arm/boot/dts/imx28-evk.dts | 462 +++++++++---------
>> arch/arm/boot/dts/imx28-m28.dtsi | 44 +-
>> arch/arm/boot/dts/imx28-m28cu3.dts | 354 +++++++-------
>> arch/arm/boot/dts/imx28-m28evk.dts | 420 ++++++++--------
>> arch/arm/boot/dts/imx28-sps1.dts | 201 ++++----
>> arch/arm/boot/dts/imx28-ts4600.dts | 80 ++-
>> arch/arm/boot/dts/imx28-tx28.dts | 38 +-
>> 21 files changed, 2142 insertions(+), 2735 deletions(-)
>>
>
> FYI, such changes have been rejected years ago:
>
> https://lore.kernel.org/linux-arm-kernel/20140512141814.GE8330@dragon/
That's a bit surprising. I did it for my Samsung platforms, doing it now
for Qualcomm.
If the platform is obsolete, indeed changes might not have sense. But
even if a very old platform is still used and maintained, then
refactoring and improving quality should be welcomed, even if it affects
out of tree users. Any out of tree users should anyway upstream
themselves or it is their problem.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-03 10:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 20:33 [PATCH 0/9] ARM: dts: imx28: Clean up older DTS files Stefan Wahren
2023-02-01 20:33 ` [PATCH 1/9] ARM: dts: imx28-apf28: Convert to use label references Stefan Wahren
2023-02-13 8:22 ` Sébastien Szymanski
2023-02-13 14:50 ` Stefan Wahren
2023-02-01 20:33 ` [PATCH 2/9] ARM: dts: imx28-m28/sps1: " Stefan Wahren
2023-02-01 21:03 ` Marek Vasut
2023-02-01 20:33 ` [PATCH 3/9] ARM: dts: imx28-apx4devkit: " Stefan Wahren
2023-02-01 20:33 ` [PATCH 4/9] ARM: dts: imx28-cfa10036: " Stefan Wahren
2023-02-01 20:33 ` [PATCH 5/9] ARM: dts: imx28-duckbill: " Stefan Wahren
2023-02-01 20:33 ` [PATCH 6/9] ARM: dts: imx28-duckbill-2: Include base board Stefan Wahren
2023-02-01 20:33 ` [PATCH 7/9] ARM: dts: imx28-evk: Convert to use label references Stefan Wahren
2023-02-01 20:33 ` [PATCH 8/9] ARM: dts: imx28-ts4600: " Stefan Wahren
2023-02-01 20:33 ` [PATCH 9/9] ARM: dts: imx28-tx28: add SPDX-License-Identifier Stefan Wahren
2023-02-02 6:16 ` Lothar Waßmann
2023-02-03 9:44 ` [PATCH 0/9] ARM: dts: imx28: Clean up older DTS files Sébastien Szymanski
2023-02-03 10:16 ` Krzysztof Kozlowski [this message]
2023-02-03 13:13 ` Sascha Hauer
2023-03-06 2:58 ` Shawn Guo
2023-03-07 9:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95e3286b-8018-5cb4-80c7-7b7d77a296d3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastien.szymanski@armadeus.com \
--cc=shawnguo@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).