From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 837A9C4332F for ; Tue, 8 Nov 2022 11:22:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233771AbiKHLWu (ORCPT ); Tue, 8 Nov 2022 06:22:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234123AbiKHLWR (ORCPT ); Tue, 8 Nov 2022 06:22:17 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A86E24D5C8 for ; Tue, 8 Nov 2022 03:22:11 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id j16so20732350lfe.12 for ; Tue, 08 Nov 2022 03:22:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6S31b1GgAuSZeRVi3aE6k9Lv1kYy2JgOJdueU/WrfPk=; b=FQVTX03+/jYDhFiJtnC4PlzY3j6O7eqRrURGbxCj9uxURjFPxqXVMZP/7fLhWbImBm JdC6fC+nWdrCet4LQal83kXfuzLLawXKFxu/oLYv8Kh2r6x559FfrsvfHjCmy2lBT2pa QV3OVJL19Mn4gyrzkg6t6afH5exahrLMKp49Zciw9Ta4DwOEluePqPBp/VNPXU+77weK lmit955EmN4VKHGupVAVSjMQxm/PKGzojOJMymAfU8+zG2QjMYaXztogXBUZ6oJAEr9X BXxZOLcPkDq8/wEIfmqbcQ9xMX56E55y+wwH5Tx8zJ331BBicVaEbuCsdYGaIZWrHAOU 7t/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6S31b1GgAuSZeRVi3aE6k9Lv1kYy2JgOJdueU/WrfPk=; b=EcGW/XHNuASxtORp0kW9EwQ3Y1cR/u9Zomi3bYdBak9lbw3r4T+z7kkl/YehUXSXZ/ 8l2d7Edmc4IyBQetbam3Kf124osiqqBTeB5gBJ837YLx/EamJbMOwiLu3ZLLHXRXczYg xrM3/evlBN0RpliKgZj5B/KcmASk+jcWD+hvtWra1RExJ5o2JIgiUfYC/plWfNUPN1FL 0XqHFttwjBf1K0dHGBU+fDf29Ew8e0bapzDyTqQy68kKKu9cMgauoMjI4wSsMWRVk/Xi EvKAbNdAFdQg6mevVPA0iayp8MaewdiOSTCmtsfCu0qo1RmrHbI7Tf3UMXRpq01Fu1iJ 2NEQ== X-Gm-Message-State: ANoB5pkT886WPnHw7kozHPnJANJ0KeIJOUvOrbqENCBEGurgjFJM+CFJ f66xSd+tjMBQWdTeNzGaA1czQA== X-Google-Smtp-Source: AA0mqf71iUpqb4+BI/4RUZw1laBPRBQU7iqH2g/sTobl9bST23hwOoH26omyo1cgyvEyZZV9JTdQ2Q== X-Received: by 2002:ac2:43b0:0:b0:4b2:805:f5cb with SMTP id t16-20020ac243b0000000b004b20805f5cbmr5885841lfl.204.1667906530035; Tue, 08 Nov 2022 03:22:10 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id q7-20020ac25107000000b004b40c2fccfdsm221399lfb.59.2022.11.08.03.22.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Nov 2022 03:22:09 -0800 (PST) Message-ID: <95f588d2-04f3-0be6-ebce-cb6957f5aa1a@linaro.org> Date: Tue, 8 Nov 2022 12:22:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v1 3/6] dt-bindings: hwmon: Add hpe,gxp-fan-ctrl Content-Language: en-US To: "Hawkins, Nick" , "jdelvare@suse.com" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "Verdun, Jean-Marie" , "corbet@lwn.net" , "linux@armlinux.org.uk" , "linux-hwmon@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" References: <20221104193657.105130-1-nick.hawkins@hpe.com> <20221104193657.105130-4-nick.hawkins@hpe.com> <1b90f86c-9c0f-225b-38b5-6f37a4eded69@linaro.org> <236F9C0A-797D-41C6-B342-4C32DF28C426@hpe.com> From: Krzysztof Kozlowski In-Reply-To: <236F9C0A-797D-41C6-B342-4C32DF28C426@hpe.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/11/2022 23:36, Hawkins, Nick wrote: > > > > This provides the base registers address, programmable logic registers > > > address, and the function 2 registers to allow control access of the HPE > > > fans on the GXP SoC. > > > What is "This"? If "This patch", then drop it. > > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > > If "This hardware" then please instead describe the hardware, not it > components. What are its features? If it controls the fan, then why > there are no PWM-related cells? How do you set the speed? > > Greetings Krzysztof, > > Thank you for the feedback. The intention was this binding.. however, that was an error on my part, and I will correct it to reflect the hardware situation of the GXP with the fan controller and how each of the mapped registers provide control to the system. To answer your questions: The fans speeds are controlled through an external CPLD device which we provide a PWM value (0-255) using the "base" register to the CIF interface. Wrap your emails, it's impossible to simply reply to it. Then your CIF interface is a PWM device? > This interface provides access to the CPLD. The CPLD then drives the fan. The CPLD can generate up to 8 unique different PWMs to multiple fans. So you have other CPLD (not external) which generates PWM based on first CPLD base register? Hm, I think it's one CPLD. > The CPLD monitors the fans and reports the status back to the SoC through the CIF interface to the "plreg base". The plreg includes the installation, failed, and identification statuses. The function 2 register base is used to check the power state of the system as that influences the PWM values read back. > As the PWM generation happens outside the SoC do we still need pwm-cells? If so, should we have a custom compatible for that? > Depends, if these are actually tightly coupled and you cannot use PWM for anything else, then you do not need. > Thanks, > > -Nick > > Best regards, Krzysztof