From: Dmitry Osipenko <digetx@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Jaroslav Kysela <perex@perex.cz>, Ion Agorria <ion@agorria.com>,
Svyatoslav Ryhel <clamor95@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] ASoC: tegra: Unify ASoC machine drivers
Date: Tue, 18 May 2021 23:11:56 +0300 [thread overview]
Message-ID: <95f62f68-b081-2f98-1f88-f39e52c49bfe@gmail.com> (raw)
In-Reply-To: <20210518180949.GA949047@robh.at.kernel.org>
18.05.2021 21:09, Rob Herring пишет:
>> +static const char * const tegra_active_low_hp_compats[] = {
>> + "ad,tegra-audio-plutux",
>> + "ad,tegra-audio-wm8903-medcom-wide",
>> + "ad,tegra-audio-wm8903-tec",
>> + "nvidia,tegra-audio-wm8903-cardhu",
>> + "nvidia,tegra-audio-wm8903-harmony",
>> + "nvidia,tegra-audio-wm8903-picasso",
>> + "nvidia,tegra-audio-wm8903-seaboard",
>> + "nvidia,tegra-audio-wm8903-ventana",
>> + NULL,
> I think this list should be added to the main match table below with
> data having a flag for active low HP. Then you only match once, don't
> need the exported function and the next difference is much easier to
> add.
>
Thank you for the suggestion. You're right that these compats will take
precedence.
I'm also now thinking that it should be okay to assume that the GPIO is
active-low by default. I haven't seen tegra boards with the active-high
configuration.
I'll remove the use of the exported function in v2.
prev parent reply other threads:[~2021-05-18 20:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 0:13 [PATCH v1 0/2] Unify NVIDIA Tegra ASoC machine drivers Dmitry Osipenko
2021-05-18 0:13 ` [PATCH v1 1/2] of: base: Export of_device_compatible_match() Dmitry Osipenko
2021-05-18 18:14 ` Rob Herring
2021-05-18 0:13 ` [PATCH v1 2/2] ASoC: tegra: Unify ASoC machine drivers Dmitry Osipenko
2021-05-18 18:09 ` Rob Herring
2021-05-18 18:34 ` Mark Brown
2021-05-18 20:16 ` Dmitry Osipenko
2021-05-19 20:09 ` Mark Brown
2021-05-18 22:31 ` Question about Tegra UCMs Dmitry Osipenko
2021-05-19 11:13 ` Jaroslav Kysela
2021-05-19 13:15 ` Dmitry Osipenko
2021-05-19 11:38 ` Mark Brown
2021-05-19 13:19 ` Dmitry Osipenko
2021-05-18 20:11 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95f62f68-b081-2f98-1f88-f39e52c49bfe@gmail.com \
--to=digetx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=clamor95@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=ion@agorria.com \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).