Re: [Patch v3 2/2] memory: tegra: make sid and broadcast regions optional

Krzysztof Kozlowski
2024-04-22T07:12:41Z

On 12/04/2024 15:05, Sumit Gupta wrote:
> MC SID and Broadbast channel register access is restricted for Guest VM.

Same typo

> In Tegra MC driver, consider both the regions as optional and skip
> access to restricted registers from Guest if a region is not present
> in Guest DT.
>

...

>
> static inline u32 mc_readl(const struct tegra_mc *mc, unsigned long offset)
> diff --git a/drivers/memory/tegra/tegra186.c b/drivers/memory/tegra/tegra186.c
> index 1b3183951bfe..716582255eeb 100644
> --- a/drivers/memory/tegra/tegra186.c
> +++ b/drivers/memory/tegra/tegra186.c
> @@ -26,20 +26,16 @@
> static int tegra186_mc_probe(struct tegra_mc *mc)
> {
> struct platform_device *pdev = to_platform_device(mc->dev);
> + struct resource *res;
> unsigned int i;
> - char name[8];
> + char name[14];

How is it relevant? I don't see this being used in your diff.

Best regards,
Krzysztof