From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDBB6C6FA86 for ; Thu, 8 Sep 2022 11:40:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231228AbiIHLkE (ORCPT ); Thu, 8 Sep 2022 07:40:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230101AbiIHLkC (ORCPT ); Thu, 8 Sep 2022 07:40:02 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2E436D9CF for ; Thu, 8 Sep 2022 04:39:58 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id i26so11501942lfp.11 for ; Thu, 08 Sep 2022 04:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=VIMRu3DlnR1bsB5zLuZyfEMWhGcdT9QFRMPDPMKjXCI=; b=EUN/eII6fAHStDiHP5M4+H2AZnUfJoda1Sv4cDqD+ji7NebxXFawVFe3nHmjf4Prai nXsU+2T+GtYxm+SuzBObS+BG1F+XFuMd/RglD5GU7CN7HKOQxGyogX250NIAOCxS3UdT fTQ4EKOyayztjv9V11TNKnXLqu0LZRuH42IEFipXFalZKACfj75glHGXpIc7KMriqp8j Iv5IzHBx6X2cEFnUpJM/m6uCFTHCaNOfvb7USbV5NxsNfP6D4phf178lkBhsaeqR8uMt nZilSPb5eJVN3GmO/W4VuOBLFUcsQtiY/NRlu9MguM1n7sfHfOJIeIFOUGaOvjfJ3If5 m0jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=VIMRu3DlnR1bsB5zLuZyfEMWhGcdT9QFRMPDPMKjXCI=; b=p6Q/+vJTLNu4srSK3OGP6Z7+acgP2VCfTwaG03E5mYEfVkd3jCEgrCBFWMF08p6tOo zAz9phG68dX8t5YWMUYHf6UMYBoM328NR1wTDFFd8XNO5ad7Lxj5hFiYOHRciWqpzr2j YHFv17GDNt9HGKIidct+qxmvk32ILU/QsLQ9IsZ4zE72vKtO8b//xJlHU7z9TnA51wrc q0Bf2BHZmyJ1nIkpqb9iCFMFcH54mZH71fX7xEr2wxRYf/bhnYzwUPnue+rWOFzo4hWR dguGAz7JZjD6vTftBlhwj6Gt2rwVXMCoN2bXv5Ukhfjygg/KRRcg8yO0GGnZjW7oGVpi vnUg== X-Gm-Message-State: ACgBeo2opfJBMIIaL1fDB3sBbIGO+HxR3yPeZw98ooUOZSIKrbv0EFFs G2nGvng5q78PiS+kDT7RCqpRsg== X-Google-Smtp-Source: AA6agR5sTBbNR2Xr0R2PxZyBP7qGDTxaJA/YR/L8EF9WX4+xtyxyVk7fYZFU0G2jo0dBbnMdcDRArg== X-Received: by 2002:a05:6512:1189:b0:494:b306:c16 with SMTP id g9-20020a056512118900b00494b3060c16mr2700311lfr.452.1662637197344; Thu, 08 Sep 2022 04:39:57 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id a18-20020ac25052000000b004979e231fafsm1495281lfm.38.2022.09.08.04.39.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 04:39:56 -0700 (PDT) Message-ID: <961b4821-4111-b48e-1ae0-60da8c427fbb@linaro.org> Date: Thu, 8 Sep 2022 13:39:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 1/4] media: dt-bindings: Document Renesas RZ/G2L CSI-2 block Content-Language: en-US To: Lad Prabhakar , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , Jacopo Mondi , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Sakari Ailus , Hans Verkuil Cc: Geert Uytterhoeven , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das References: <20220905230406.30801-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220905230406.30801-2-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Krzysztof Kozlowski In-Reply-To: <20220905230406.30801-2-prabhakar.mahadev-lad.rj@bp.renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/09/2022 01:04, Lad Prabhakar wrote: > Document the CSI-2 block which is part of CRU found in Renesas > RZ/G2L (and alike) SoCs. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Laurent Pinchart > --- > v1 -> v2 > * Dropped media prefix from subject > * Renamed node name csi20 -> csi > * Used 4 spaces for indentation in example node > * Dropped reset-names and interrupt-names properties > * Dropped oneOf from compatible > * Included RB tag from Laurent > > RFC v2 -> v1 > * Fixed review comments pointed by Rob and Jacopo. > > RFC v1 -> RFC v2 > * New patch > --- > .../bindings/media/renesas,rzg2l-csi2.yaml | 140 ++++++++++++++++++ > 1 file changed, 140 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml > > diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml > new file mode 100644 > index 000000000000..79beace4dec2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml > @@ -0,0 +1,140 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (C) 2022 Renesas Electronics Corp. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/renesas,rzg2l-csi2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RZ/G2L (and alike SoC's) MIPI CSI-2 receiver > + > +maintainers: > + - Lad Prabhakar > + > +description: > + The CSI-2 receiver device provides MIPI CSI-2 capabilities for the Renesas RZ/G2L > + (and alike SoCs). MIPI CSI-2 is part of the CRU block which is used in conjunction > + with the Image Processing module, which provides the video capture capabilities. > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,r9a07g044-csi2 # RZ/G2{L,LC} > + - renesas,r9a07g054-csi2 # RZ/V2L > + - const: renesas,rzg2l-csi2 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Internal clock for connecting CRU and MIPI > + - description: CRU Main clock > + - description: CPU Register access clock > + > + clock-names: > + items: > + - const: sysclk > + - const: vclk > + - const: pclk One more: drop the "clk" suffixes. Remaining names could be made a bit more readable. Best regards, Krzysztof