From: Mudit Sharma <muditsharma.info@gmail.com>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
ivan.orlov0322@gmail.com, jic23@kernel.org, lars@metafoo.de,
krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/3] MAINTAINERS: Add maintainer for ROHM BH1745
Date: Tue, 4 Jun 2024 11:44:01 +0100 [thread overview]
Message-ID: <961fa617-a76b-4b79-956b-795a55fec959@gmail.com> (raw)
In-Reply-To: <a628db76-a48a-4492-a3cc-f93c0f67ad04@gmail.com>
On 03/06/2024 23:37, Javier Carrasco wrote:
> On 03/06/2024 18:21, Mudit Sharma wrote:
>> Add myself as maintainer for ROHM BH1745 colour sensor driver.
>>
>> Signed-off-by: Mudit Sharma <muditsharma.info@gmail.com>
>> ---
>> v1->v2:
>> - No changes
>>
>> MAINTAINERS | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index d6c90161c7bf..945873321fef 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -19407,6 +19407,13 @@ S: Supported
>> F: drivers/power/supply/bd99954-charger.c
>> F: drivers/power/supply/bd99954-charger.h
>>
>> +ROHM BH1745 COLOUR SENSOR
>> +M: Mudit Sharma <muditsharma.info@gmail.com>
>> +L: linux-iio@vger.kernel.org
>> +S: Maintained
>> +F: Documentation/devicetree/bindings/iio/light/rohm,bh1745.yaml
>> +F: drivers/iio/light/bh1745.c
>> +
>> ROHM BH1750 AMBIENT LIGHT SENSOR DRIVER
>> M: Tomasz Duszynski <tduszyns@gmail.com>
>> S: Maintained
>
> Hi Mudit,
>
> is there any special reason to have a separate patch for this? The
> addition to MAINTANERS for new drives is usually included in the patch
> that provides the driver itself.
>
> Best regards,
> Javier Carrasco
Hi Javier,
Adding this in a separate commit was just a pattern I notices with some
other drivers, for instance 3b4e0e9.
If necessary and/or considered good practice, I can squash this in the
patch that brings in the driver.
Best regards,
Mudit Sharma
next prev parent reply other threads:[~2024-06-04 10:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 16:21 [PATCH v2 1/3] dt-bindings: iio: light: ROHM BH1745 Mudit Sharma
2024-06-03 16:21 ` [PATCH v2 2/3] iio: light: ROHM BH1745 colour sensor Mudit Sharma
2024-06-03 16:49 ` Ivan Orlov
2024-06-03 23:10 ` Javier Carrasco
2024-06-04 14:24 ` Mudit Sharma
2024-06-04 14:58 ` Javier Carrasco
2024-06-04 15:49 ` Mudit Sharma
2024-06-08 15:20 ` Jonathan Cameron
2024-06-05 7:51 ` kernel test robot
2024-06-03 16:21 ` [PATCH v2 3/3] MAINTAINERS: Add maintainer for ROHM BH1745 Mudit Sharma
2024-06-03 16:47 ` Ivan Orlov
2024-06-03 22:37 ` Javier Carrasco
2024-06-04 10:44 ` Mudit Sharma [this message]
2024-06-04 12:53 ` Javier Carrasco
2024-06-04 13:38 ` Matti Vaittinen
2024-06-04 13:47 ` Javier Carrasco
2024-06-04 6:35 ` [PATCH v2 1/3] dt-bindings: iio: light: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=961fa617-a76b-4b79-956b-795a55fec959@gmail.com \
--to=muditsharma.info@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivan.orlov0322@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).