From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Barinov Subject: Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree Date: Fri, 6 Oct 2017 05:47:25 +0300 Message-ID: <9635bb2d-8695-a168-d49e-0bd51807cc19@cogentembedded.com> References: <1505398732-4614-1-git-send-email-vladimir.barinov@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geert Uytterhoeven Cc: Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux-Renesas , Pantelis Antoniou List-Id: devicetree@vger.kernel.org Hi Simon, Geert, Do you need extra actions from my side to accept this patch? On 20.09.2017 15:32, Geert Uytterhoeven wrote: > Hi Vladimir, > > [CC Pantelis] > > On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov > wrote: >> Add the initial device tree for the M3ULCB with Kingfisher extension >> infotainment board. >> >> Signed-off-by: Vladimir Barinov >> --- >> Changes in version 2: >> - added own compatible value "shimafuji,kingfisher" > Reviewed-by: Geert Uytterhoeven > > Some food for thought below... > >> --- /dev/null >> +++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts >> @@ -0,0 +1,19 @@ >> +/* >> + * Device Tree Source for the M3ULCB Kingfisher board >> + * >> + * Copyright (C) 2017 Renesas Electronics Corp. >> + * Copyright (C) 2017 Cogent Embedded, Inc. >> + * >> + * This file is licensed under the terms of the GNU General Public License >> + * version 2. This program is licensed "as is" without any warranty of any >> + * kind, whether express or implied. >> + */ >> + >> +#include "r8a7796-m3ulcb.dts" > Ideally, we don't include *.dts files, only *.dtsi. > But I don't see a better immediate solution. > >> +#include "ulcb-kf.dtsi" > As the Kingfisher is actually an expansion board for H3ULCB (with R-Car H3 > ES1.1 and ES2.0) and M3ULCB (with R-Car M3-W), turning ulcb-kf.dtsi into a > DT overlay would make sense. > That would also solve the issue of the 3 extra DTSes needed for all possible > combinations of ULCB and Kingfisher (r8a7795-es1-h3ulcb-kf.dts, > r8a7795-h3ulcb-kf.dts, r8a7796-h3ulcb-kf.dts (perhaps more to follow?)). > > But that's too premature, without upstream support for the easy loading of > DT overlays. > >> +/ { >> + model = "Renesas M3ULCB Kingfisher board based on r8a7796"; >> + compatible = "shimafuji,kingfisher", "renesas,m3ulcb", >> + "renesas,r8a7796"; >> +}; > And how to support from an overlay the addition of "shimafuji,kingfisher" to > (not replacement of!) the main compatible value? > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Regards, Vladimir -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html