From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E122EC678D7 for ; Tue, 10 Jan 2023 16:41:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234189AbjAJQlQ (ORCPT ); Tue, 10 Jan 2023 11:41:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234097AbjAJQlJ (ORCPT ); Tue, 10 Jan 2023 11:41:09 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9A0B51320 for ; Tue, 10 Jan 2023 08:41:04 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id p1-20020a05600c1d8100b003d8c9b191e0so10542871wms.4 for ; Tue, 10 Jan 2023 08:41:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Th4XS3ExnJps+ejGgAt+lEc+wt5pkhQaMhYYIYNJy0U=; b=a2RI/NAz23mB851gzvwuv+p7hExudFo71Jz2+0oDw0T1EhzC7jwPZqmqwBS3mZ7Pk5 XN+mp23UWm76WcYPMr+2b0ss91RHKvx5Q3bTO6u/8pXjO8pCxW5ph1dwoq/P9vV/hU8P uotbWX0UA1lJXNzp/yuQyd+Lybnq+sTqqt4Wu8jG1aiinRxynfX9xOUkrXVM8KlULoUd 8fO+I6pUurdwv+JnjMTH1bjinN+feq4bT35Uf3/Uy+IpzcgzqQ7JahwDt2J12PTMjSky UqYsIc6fT9oEA/mGd0GtJKQnrOVgfM4z/YU/ABm/7341rcFsAxWKw8PKuZUveZxmvBsH 2hHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Th4XS3ExnJps+ejGgAt+lEc+wt5pkhQaMhYYIYNJy0U=; b=1waKaq+aQ047JSCv24fD2BUciCP0xe7tmqotZ7g/JivBlrSCDcZjkOZ2O2FJRqIX9a qfkDvU3x0YUInCP/yIVcjSdPcMgzxgMDjD+eOlKem6Y4cQhXR2t8umfGSVUJId2WzCMt 9Hugm6G3x745w6JtZZRy6xC5tJNe5C3/aTRZ7dr/p1MwD0Oav9Ey/hnYHL+wT4vzbO5A FPa0KmYD677ladidnbzClaWKTLkKB/KgXRY6v2RYa2SRLeDeHVx3FsUfxX+frvZXBmE3 zSjVOUqZUj3QaG2BepA65LaLmL8+ls+QjAs3aHAY+2sk9JC+6k2C1ubCMsNOgAK3uCVD kt6w== X-Gm-Message-State: AFqh2koSkdkhagA+Jyxfm7ofA5gaLAO3KHKY0V0TO2+EhdUfj1CfdSwv UsuHnTSllTHmyBVGkmbCUD5C/Q== X-Google-Smtp-Source: AMrXdXskmZw3ugW9Pk8CVGZsMZh1RbFbAqdASFjBu3L9/SbBgfi3fYgfSX8zXMjI3EW8xExE+p+a9Q== X-Received: by 2002:a05:600c:46c7:b0:3d9:ee3d:2f54 with SMTP id q7-20020a05600c46c700b003d9ee3d2f54mr6883493wmo.13.1673368863486; Tue, 10 Jan 2023 08:41:03 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id he12-20020a05600c540c00b003d9ddc82450sm15086035wmb.45.2023.01.10.08.41.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 08:41:03 -0800 (PST) Message-ID: <9640d2a0-7245-285e-0e7a-d75bfe3f88ac@linaro.org> Date: Tue, 10 Jan 2023 17:40:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 09/11] dt-bindings: mmc: convert amlogic,meson-gx.txt to dt-schema Content-Language: en-US To: neil.armstrong@linaro.org, Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Srinivas Kandagatla , Wim Van Sebroeck , Guenter Roeck , Mauro Carvalho Chehab , Alessandro Zummo , Alexandre Belloni , Daniel Lezcano , Thomas Gleixner , Vinod Koul , Kishon Vijay Abraham I , Ulf Hansson , Bjorn Helgaas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Russell King Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-media@vger.kernel.org, linux-rtc@vger.kernel.org, linux-phy@lists.infradead.org, linux-mmc@vger.kernel.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org References: <20221117-b4-amlogic-bindings-convert-v2-0-36ad050bb625@linaro.org> <20221117-b4-amlogic-bindings-convert-v2-9-36ad050bb625@linaro.org> <2037156d-5113-4b96-8f86-c8ef1c1fdf96@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <2037156d-5113-4b96-8f86-c8ef1c1fdf96@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/01/2023 15:17, Neil Armstrong wrote: > On 10/01/2023 11:17, Krzysztof Kozlowski wrote: >> On 09/01/2023 13:53, Neil Armstrong wrote: >>> Convert the Amlogic SD / eMMC controller for S905/GXBB family SoCs >>> to dt-schema. >>> >>> Take in account the used variant with amlogic,meson-gx-mmc. >>> >>> Signed-off-by: Neil Armstrong >>> --- >>> .../bindings/mmc/amlogic,meson-gx-mmc.yaml | 75 ++++++++++++++++++++++ >>> .../devicetree/bindings/mmc/amlogic,meson-gx.txt | 39 ----------- >>> 2 files changed, 75 insertions(+), 39 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml >>> new file mode 100644 >>> index 000000000000..30228964fd9c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml >>> @@ -0,0 +1,75 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/mmc/amlogic,meson-gx-mmc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Amlogic SD / eMMC controller for S905/GXBB family SoCs >>> + >>> +description: >>> + The MMC 5.1 compliant host controller on Amlogic provides the >>> + interface for SD, eMMC and SDIO devices >>> + >>> +maintainers: >>> + - Neil Armstrong >>> + >>> +allOf: >>> + - $ref: mmc-controller.yaml# >>> + >>> +properties: >>> + compatible: >>> + oneOf: >>> + - enum: >>> + - amlogic,meson-gx-mmc >>> + - amlogic,meson-axg-mmc >>> + - items: >>> + - const: amlogic,meson-gx-mmc >> >> This does not look correct. Either gx is alone (not compatible with >> gxbb) or it is compatible with gxbb. Cannot be both. > > This ishow it's used in DT: > > arch/arm64/boot/dts/amlogic/meson-gx.dtsi: compatible = "amlogic,meson-gx-mmc", "amlogic,meson-gxbb-mmc"; > arch/arm64/boot/dts/amlogic/meson-axg.dtsi: compatible = "amlogic,meson-axg-mmc"; > arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi: compatible = "amlogic,meson-axg-mmc"; > > So I'll drop the amlogic,meson-gx-mmc in the first enum to have : > +properties: > + compatible: > + oneOf: > + - const: amlogic,meson-axg-mmc > + - items: > + - const: amlogic,meson-gx-mmc > + - const: amlogic,meson-gxbb-mmc > > It's right ? Yes. Best regards, Krzysztof