From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D511C433EF for ; Mon, 11 Jul 2022 11:42:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbiGKLmr (ORCPT ); Mon, 11 Jul 2022 07:42:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbiGKLmf (ORCPT ); Mon, 11 Jul 2022 07:42:35 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9D023237FE for ; Mon, 11 Jul 2022 04:34:50 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A92252B; Mon, 11 Jul 2022 04:34:50 -0700 (PDT) Received: from [10.57.85.194] (unknown [10.57.85.194]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 21B843F792; Mon, 11 Jul 2022 04:34:47 -0700 (PDT) Message-ID: <9645c413-af05-c47f-dfb5-5b0e7f511d9c@arm.com> Date: Mon, 11 Jul 2022 12:34:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a Content-Language: en-GB To: Piotr Oniszczuk Cc: Peter Geis , Sascha Hauer , Michael Riesch , dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , kernel test robot References: <20220422072841.2206452-1-s.hauer@pengutronix.de> <0E6FE020-C95E-47CF-A9D6-AC3F2B2D334F@gmail.com> <9F2D8CFF-1EAE-4586-9EE9-82A9D67840BB@gmail.com> <9567EECF-A154-4FE1-A03C-5ED080409030@gmail.com> <190C3FD3-0185-4A99-B10E-A5790047D993@gmail.com> <0D8B18A1-82FD-4902-A443-AD774DE43DAD@gmail.com> <15846ffa-f68a-2f88-55a3-40a633132c28@arm.com> <27F4BA6C-9C56-446D-AB82-A691E7C54772@gmail.com> From: Robin Murphy In-Reply-To: <27F4BA6C-9C56-446D-AB82-A691E7C54772@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-07-11 12:04, Piotr Oniszczuk wrote: > > >> Wiadomość napisana przez Robin Murphy w dniu 11.07.2022, o godz. 12:41: >> >> On 2022-06-25 16:31, Piotr Oniszczuk wrote: >>>> Wiadomość napisana przez Peter Geis w dniu 25.06.2022, o godz. 16:00: >>>> >>>> >>>> The first issue you have is the TV isn't responding until the absolute >>>> end. >>> I suspect this is because lack on idle gaps between cec commands sent from board to tv. >>> Maybe TV sw. can't deal with consecutive commands without any idle between them? >>> It is interesting that disconnecting TV - so CEC line is driven only by board - rock3a still don't have any idle gaps while rock3b (and radxa 4.19 bsp) has them (very similar between 5.18mailine and 4.19 bsp). >>> How this is possible that change I/O from m0->m1 impacts _timings_ on free hanging CEC line? >> >> Check all the pinctrl settings beyond just the function mux - pulls, drive strength, output type, etc. - the defaults tend to be all over the place, and rarely what you want. >> >> Robin. > > Robin, > > I'm not sure do I looked in right place... > > but: > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi?h=v5.18.10#n788 > > vs. > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi?h=v5.18.10#n795 > > are looking ok? I meant more in terms of dumping out the actual hardware state to compare across both axes of cec_m0 vs. cec_m1 and mainline vs. BSP. However from a quick skim of the Rock3 schematic there doesn't appear to be an external pull-up, so the internal pull-up also being disabled is a clear suspect to start with. Robin.