From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53DC6C433F5 for ; Tue, 4 Oct 2022 06:53:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229642AbiJDGx4 (ORCPT ); Tue, 4 Oct 2022 02:53:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbiJDGxz (ORCPT ); Tue, 4 Oct 2022 02:53:55 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B877E2ED4C for ; Mon, 3 Oct 2022 23:53:53 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id f37so1443119lfv.8 for ; Mon, 03 Oct 2022 23:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=rGAbSoZZBNp1Rcgw72Rvq0ko1UR3Gj5wyM3fR9f9QcA=; b=kwFzKfO/Y/xaLTNuTEfETEj4Sx9BNm+sDiWRt2m6ij+4hPyAy813ZhUuqvLUihg/w7 HPzk7xkR2hMGfmCel+qv+9pktl4dzA+64MlhqCGa+F/p7NbEZh0QzqNa0n2U8NJ7JSYl RLD1M3i+tTIdVhZXeYovo/mNN9e9hDCpI3SqSrJ6wdLNCsaFbBCaDfKnuq9MCqK/Bjjs h3H8w35Hia1srXSv2U5PUeUdXwyFOqqH+VgCKgpifXFPt/Bl+JpeMFGdhpimof7HAkvj BkeyjFns0x85c8D1kEv333nbQiwXg2kt/IDzM1ibdZaX0wV50TYNEG8atXflJOHsrI0S cbnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=rGAbSoZZBNp1Rcgw72Rvq0ko1UR3Gj5wyM3fR9f9QcA=; b=BdCaexkQY8mP8lNEGtMdeU2mRJi82IRIOswH/z4epZ6X6LpYSPw7uey4VQ2WmG0psl SzHIkflIBqxuY+Gp8WXEAgdbAqSJENiUpV45X4SMxYKMD4Wom8YbF3lgEpgt67UrT5LS ThUXF9QaguFqVX3PpUJb9+BY/Mq2yGV55VoXW7oNIvfzbYn2cdMA/e62qMJl1I/e5YQj tGiiIPDaAypTps2QPUUKHK2CWsmlhvTGLAR3eoP2/0yn+RXeLMSeNj8Vitp/OkkCBH7l gIfFa9qY+6r9RcBzta4dXf39z4qW3oXKuPn5eiKbs/WOaQSazuPtnE5NOqg0cCAGdr8j wxLQ== X-Gm-Message-State: ACrzQf14k1ZzyRKrSrxLUiFWkrdBABbbCneFEk1sCxL5DStn/IjlqA3L xQDioI1yy67xr81NDwtN8VHgAQ== X-Google-Smtp-Source: AMsMyM5RaCobEe+/0/5LX8MZEHgbJcoU+0O/Jr7Y0adYZZuT5CPllLO9zX3tunOqSvUAvqlyO6sYmg== X-Received: by 2002:ac2:51ae:0:b0:4a2:4f37:451c with SMTP id f14-20020ac251ae000000b004a24f37451cmr1309615lfk.649.1664866432124; Mon, 03 Oct 2022 23:53:52 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id k2-20020a05651239c200b00499aefcf68esm1769029lfu.292.2022.10.03.23.53.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 23:53:51 -0700 (PDT) Message-ID: <9664a623-3c58-49e8-1b9a-69335d844448@linaro.org> Date: Tue, 4 Oct 2022 08:53:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles Content-Language: en-US To: Dmitry Baryshkov , Melody Olvera Cc: Andy Gross , Bjorn Andersson , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Ulf Hansson , Bhupesh Sharma , linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221001030641.29354-1-quic_molvera@quicinc.com> <20221001030641.29354-2-quic_molvera@quicinc.com> <09f5d364-320e-9ecc-2c2b-68066c61f802@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/10/2022 00:14, Dmitry Baryshkov wrote: > On Tue, 4 Oct 2022 at 01:02, Melody Olvera wrote: >> >> >> On 10/1/2022 4:25 AM, Krzysztof Kozlowski wrote: >>> On 01/10/2022 05:06, Melody Olvera wrote: >>>> Add compatibles for scm driver for QDU1000 and QRU1000 platforms. >>>> >>>> Signed-off-by: Melody Olvera >>>> --- >>>> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >>>> index c5b76c9f7ad0..b47a5dda3c3e 100644 >>>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >>>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >>>> @@ -51,6 +51,8 @@ properties: >>>> - qcom,scm-sm8250 >>>> - qcom,scm-sm8350 >>>> - qcom,scm-sm8450 >>>> + - qcom,scm-qdu1000 >>>> + - qcom,scm-qru1000 > > I think after seeing all the patchsets it's time to ask the following > question. Do we really need a duplicate compatibility families: > qdu1000 vs qru1000? I'd suggest using a single set of compatibile > strings in most of the cases. > Settle down onto a single name (qdu,qru, qdru, whatever) and define > distinct compat strings only when there is an actual difference? > > E.g .we don't have separate compatible strings for all the sda660, > apq8096, etc. unless this is required by the corresponding hardware > block not being compatible with corresponding sdm or msm counterpart. > I am not that fluent in Qualcomm naming, so let me ask - what are the differences between QDU and QRU? For compatible (and/or similar) devices the general recommendation is to have specific compatibles followed by fallback. Even if devices are very, very, very similar, usually the recommendation still stays. Best regards, Krzysztof