From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A60C433E6 for ; Mon, 31 Aug 2020 10:35:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC19F20DD4 for ; Mon, 31 Aug 2020 10:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598870140; bh=V1ZLMFYN+hd025pVnh+Yww7lnqsvYV7nIlFHgJ6wVF0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=wyBS4G/kYMIf6FWwYJ4ttSJAbVdca6Mf0XMgceWT/mXgSJPsARMlj4KhQ2eYWF2rq 98swZ6I78HgzuqfyFdN4WWmqf1VzATHFmWGcW+nSW/WOnCmS/l7ctG4GEO0WYYj6zz xy3ejYPMHHKyWcf6YziqyrFfsQyaCm+8q2ndp1xM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726468AbgHaKfj (ORCPT ); Mon, 31 Aug 2020 06:35:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:50762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbgHaKfg (ORCPT ); Mon, 31 Aug 2020 06:35:36 -0400 Received: from [192.168.0.50] (89-70-52-201.dynamic.chello.pl [89.70.52.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35ED020DD4; Mon, 31 Aug 2020 10:35:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598870136; bh=V1ZLMFYN+hd025pVnh+Yww7lnqsvYV7nIlFHgJ6wVF0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=QBKfUCQSPkEfS/h6P3Sqp+d62D6FYKrtw5pPhnOmSzIKEUfeuFhiIDB7AW4vjh4cl 7OC2WKi1VGNRtIZY/MIO9uQ5UVV9+IrnFEhW1bY/gSc9BMruuCvNktAMcyExGDJP6P dQ5dT6pubfosL4soPm3ebl8MPyVf0sYhA9g9qbok= Subject: Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3 To: Krzysztof Kozlowski , Marek Szyprowski Cc: Rob Herring , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Denis GNUtoo Carikli , Simon Shields , Bartlomiej Zolnierkiewicz References: <20200830135200.24304-1-krzk@kernel.org> <20200830135200.24304-23-krzk@kernel.org> From: Sylwester Nawrocki Message-ID: <96651e85-c27f-3167-7b41-2ea051c25c65@kernel.org> Date: Mon, 31 Aug 2020 12:35:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On 8/31/20 10:38, Krzysztof Kozlowski wrote: > On Mon, 31 Aug 2020 at 10:31, Marek Szyprowski wrote: >> On 30.08.2020 15:51, Krzysztof Kozlowski wrote: >>> The camera's pinctrl configuration is simply empty and not effective. >>> Remove it to fix dtbs_check warning: >>> >>> arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array' >>> >>> Signed-off-by: Krzysztof Kozlowski >> >> I think that this was intentional to properly enable support for >> mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the >> default values if no pinctrl properties are provided. Sylwester, could >> you comment? > > Indeed it could be intentional... I see now errors: > [ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19 > > I wonder why getting an empty pinctrl is needed... maybe the driver > should accept missing pinctrl? It might have been better to have the pinctrl properties optional, as there might be boards without the image sensor attached and FIMC could still be used in memory-to-memory mode, as Marek pointed out. But it seems too late now to change that. The binding defines the pinctrl properties as required (Documentation/devicetree/bindings/media/samsung-fimc.txt) and we need to keep them in dtses. -- Regards, Sylwester