Devicetree
 help / color / mirror / Atom feed
From: Val Packett <val@packett.cool>
To: Adam Szyma <adamszyma@wp.pl>, linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org, andersson@kernel.org,
	quic_bjorande@quicinc.com
Subject: Re: [PATCH] arm64: dts: qcom: Add Dell Inspiron 14 Plus 5441
Date: Wed, 6 May 2026 00:10:07 -0300	[thread overview]
Message-ID: <9666c1f5-722f-4c90-8412-19257a4afae5@packett.cool> (raw)
In-Reply-To: <20260504150812.15385-1-adamszyma@wp.pl>


On 5/4/26 12:08 PM, Adam Szyma wrote:
> Add device tree for the Dell Inspiron 14 Plus 5441 laptop which uses
> the Qualcomm Snapdragon X Plus X1P64100 SoC. The device shares the
> same platform (Thena) as the Dell Inspiron 14 Plus 7441 and Dell
> Latitude 7455, and reuses the x1-dell-thena.dtsi include.
>
> Signed-off-by: Adam Szyma <adamszyma@wp.pl>
> ---
>   arch/arm64/boot/dts/qcom/Makefile             |  1 +
>   .../x1p64100-dell-inspiron-14-plus-5441.dts   | 42 +++++++++++++++++++
>   2 files changed, 43 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/qcom/x1p64100-dell-inspiron-14-plus-5441.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 4ba8e7306..8fb09ec5b 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -449,3 +449,4 @@ x1p42100-lenovo-thinkbook-16-el2-dtbs	:= x1p42100-lenovo-thinkbook-16.dtb x1-el2
>   dtb-$(CONFIG_ARCH_QCOM)	+= x1p42100-lenovo-thinkbook-16.dtb x1p42100-lenovo-thinkbook-16-el2.dtb
>   x1p64100-microsoft-denali-el2-dtbs	:= x1p64100-microsoft-denali.dtb x1-el2.dtbo
>   dtb-$(CONFIG_ARCH_QCOM)	+= x1p64100-microsoft-denali.dtb x1p64100-microsoft-denali-el2.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= x1p64100-dell-inspiron-14-plus-5441.dtb
You do need to do the EL2 overlay thing here as well just like the other 
models have it.
> diff --git a/arch/arm64/boot/dts/qcom/x1p64100-dell-inspiron-14-plus-5441.dts b/arch/arm64/boot/dts/qcom/x1p64100-dell-inspiron-14-plus-5441.dts
> new file mode 100644
> index 000000000..d38febdc4
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/x1p64100-dell-inspiron-14-plus-5441.dts
> @@ -0,0 +1,42 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2026 Adam Szyma <adamszyma@wp.pl>
> + */
<one newline, please>
> +/dts-v1/;
> +#include "hamoa.dtsi"
> +#include "x1-dell-thena.dtsi"
> +
> +/ {
> +	model = "Dell Inspiron 14 Plus 5441";
> +	compatible = "dell,inspiron-14-plus-5441",
> +		     "qcom,x1p64100", "qcom,x1e80100";
> +};
> +
> +&sound {
> +	model = "X1E80100-Dell-Inspiron-14p-5441";
> +};

Is it a 2-speaker variant (no front tweeters)? Or is that only on the 
purwa model? From the pictures I can find online it seems to not have 
front speakers..

If so, the &left_tweeter &right_tweeter nodes should also be deleted 
with /delete-node/.

> +
> +&gpu {
> +	status = "okay";
> +};
> +
> +&gpu_zap_shader {
> +	firmware-name = "qcom/x1e80100/dell/inspiron-14-plus-5441/qcdxkmsuc8380.mbn";
> +};
> +
> +&iris {
> +	firmware-name = "qcom/x1e80100/dell/inspiron-14-plus-5441/qcvss8380.mbn";
> +	status = "okay";
> +};
> +
> +&remoteproc_adsp {
> +	firmware-name = "qcom/x1e80100/dell/inspiron-14-plus-5441/qcadsp8380.mbn",
> +			"qcom/x1e80100/dell/inspiron-14-plus-5441/adsp_dtbs.elf";
> +	status = "okay";
> +};
> +
> +&remoteproc_cdsp {
> +	firmware-name = "qcom/x1e80100/dell/inspiron-14-plus-5441/qccdsp8380.mbn",
> +			"qcom/x1e80100/dell/inspiron-14-plus-5441/cdsp_dtbs.elf";
> +	status = "okay";
> +};

Also could you confirm if there's actually no touchscreen?


Thanks,
~val


  reply	other threads:[~2026-05-06  3:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 15:08 [PATCH] arm64: dts: qcom: Add Dell Inspiron 14 Plus 5441 Adam Szyma
2026-05-06  3:10 ` Val Packett [this message]
2026-05-08  5:08   ` [PATCH v2] " Adam Szyma
2026-05-08  9:55     ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9666c1f5-722f-4c90-8412-19257a4afae5@packett.cool \
    --to=val@packett.cool \
    --cc=adamszyma@wp.pl \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_bjorande@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox