Re: [PATCH] dt-bindings: interrupt-controller: Convert Synquacer EXIU to DT schema

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 09/12/2022 18:16, Rob Herring wrote:
> Convert the Socionext Synquacer EXIU interrupt controller to DT schema
> format.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../socionext,synquacer-exiu.txt              | 31 -----------
>  .../socionext,synquacer-exiu.yaml             | 53 +++++++++++++++++++
>  2 files changed, 53 insertions(+), 31 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/socionext,synquacer-exiu.txt
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/socionext,synquacer-exiu.yaml
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/socionext,synquacer-exiu.txt b/Documentation/devicetree/bindings/interrupt-controller/socionext,synquacer-exiu.txt
> deleted file mode 100644
> index dac0846fe789..000000000000
> --- a/Documentation/devicetree/bindings/interrupt-controller/socionext,synquacer-exiu.txt
> +++ /dev/null
> @@ -1,31 +0,0 @@
> -Socionext SynQuacer External Interrupt Unit (EXIU)
> -
> -The Socionext Synquacer SoC has an external interrupt unit (EXIU)
> -that forwards a block of 32 configurable input lines to 32 adjacent
> -level-high type GICv3 SPIs.
> -
> -Required properties:
> -
> -- compatible           : Should be "socionext,synquacer-exiu".
> -- reg                  : Specifies base physical address and size of the
> -                         control registers.
> -- interrupt-controller : Identifies the node as an interrupt controller.
> -- #interrupt-cells     : Specifies the number of cells needed to encode an
> -                         interrupt source. The value must be 3.
> -- socionext,spi-base   : The SPI number of the first SPI of the 32 adjacent
> -                         ones the EXIU forwards its interrups to.
> -
> -Notes:
> -
> -- Only SPIs can use the EXIU as an interrupt parent.
> -
> -Example:
> -
> -	exiu: interrupt-controller@510c0000 {
> -		compatible = "socionext,synquacer-exiu";
> -		reg = <0x0 0x510c0000 0x0 0x20>;
> -		interrupt-controller;
> -		interrupt-parent = <&gic>;
> -		#interrupt-cells = <3>;
> -		socionext,spi-base = <112>;
> -	};
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/socionext,synquacer-exiu.yaml b/Documentation/devicetree/bindings/interrupt-controller/socionext,synquacer-exiu.yaml
> new file mode 100644
> index 000000000000..a0d65022f07b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/socionext,synquacer-exiu.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/socionext,synquacer-exiu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext SynQuacer External Interrupt Unit (EXIU)
> +
> +maintainers:
> +  - Ard Biesheuvel <ardb@kernel.org>
> +
> +description: |+
> +  The Socionext SynQuacer SoC has an external interrupt unit (EXIU)
> +  that forwards a block of 32 configurable input lines to 32 adjacent
> +  level-high type GICv3 SPIs.
> +
> +properties:
> +  compatible:
> +    const: socionext,synquacer-exiu
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#interrupt-cells':
> +    const: 3
> +
> +  interrupt-controller: true
> +
> +  socionext,spi-base:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: The SPI number of the first SPI of the 32 adjacent ones the
> +      EXIU forwards its interrups to.
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#interrupt-cells'
> +  - interrupt-controller
> +  - socionext,spi-base
> +
> +unevaluatedProperties: false

One blank line here...

> +examples:
> +  - |
> +

and this one can be dropped

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof