From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/6] spi: dt-bindings: qcom-qspi: Add QCS615 compatible
Date: Thu, 26 Mar 2026 10:10:39 +0100 [thread overview]
Message-ID: <9687b21e-e6f9-4d66-b8ad-a5f2e60bb787@kernel.org> (raw)
In-Reply-To: <0c3c0d7d-b108-4295-96da-a261e65cd16e@oss.qualcomm.com>
On 26/03/2026 10:07, Konrad Dybcio wrote:
>>> - enum:
>>> + - qcom,qcs615-qspi
>>
>> Existing bindings allow flexible interconnects, but it should be
>> constrained. At least for new variants. Please move allOf: to the bottom
>> (after required:) and add there if:then: requiring min two interconnects
>> for qcs615.
>
> FWIW they should have never been flexible on any platform
Changing existing ones affects ABI and I do not wamt to stall this
contribution. New code however must be correct.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-26 9:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 13:13 [PATCH 0/6] Add QSPI support for QCS615 and improve interconnect handling Viken Dadhaniya
2026-03-24 13:13 ` [PATCH v1 1/6] spi: dt-bindings: qcom-qspi: Add QCS615 compatible Viken Dadhaniya
2026-03-25 11:12 ` Krzysztof Kozlowski
2026-03-26 9:07 ` Konrad Dybcio
2026-03-26 9:10 ` Krzysztof Kozlowski [this message]
2026-03-24 13:13 ` [PATCH v1 2/6] spi: spi-qcom-qspi: Add interconnect support for memory path Viken Dadhaniya
2026-03-24 16:24 ` Mark Brown
2026-03-24 13:13 ` [PATCH v1 3/6] arm64: dts: qcom: talos: Add QSPI support Viken Dadhaniya
2026-03-24 20:51 ` Dmitry Baryshkov
2026-03-25 9:32 ` Konrad Dybcio
2026-03-24 20:52 ` Dmitry Baryshkov
2026-03-25 11:13 ` Krzysztof Kozlowski
2026-03-24 13:13 ` [PATCH v1 4/6] arm64: dts: qcom: qcs615-ride: enable QSPI and NOR flash Viken Dadhaniya
2026-03-24 20:53 ` Dmitry Baryshkov
2026-03-24 13:13 ` [PATCH v1 5/6] arm64: dts: qcom: kodiak: Add QSPI memory interconnect path Viken Dadhaniya
2026-03-24 20:54 ` Dmitry Baryshkov
2026-03-24 13:13 ` [PATCH v1 6/6] arm64: dts: qcom: sc7180: " Viken Dadhaniya
2026-03-24 20:54 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9687b21e-e6f9-4d66-b8ad-a5f2e60bb787@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox