From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wenmeng Liu <quic_wenmliu@quicinc.com>,
rfoss@kernel.org, todor.too@gmail.com,
bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, akapatra@quicinc.com,
hariramp@quicinc.com
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_svankada@quicinc.com, quic_depengs@quicinc.com,
quic_vikramsa@quicinc.com
Subject: Re: [RFC PATCH 1/3] media: dt-bindings: Add regulator current load
Date: Fri, 20 Jun 2025 10:35:16 +0200 [thread overview]
Message-ID: <96ee2939-d0d6-439e-bde4-1e5476214c5a@kernel.org> (raw)
In-Reply-To: <20250620040736.3032667-2-quic_wenmliu@quicinc.com>
On 20/06/2025 06:07, Wenmeng Liu wrote:
> Add regulator current load support for vdda-phy vdda-pll.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> .../devicetree/bindings/media/qcom,sc7280-camss.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
This patch fails on so many levels... do internal reviews first.
Use existing properties, see regulators. If not, use existing unit
suffixes. Otherwise it is just another downstream property you send us,
to which we responded many times - don't.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Read meeting notes from internal discussions where you discussed this
already.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-20 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 4:07 [RFC PATCH 0/3] Add current load setting for qcom camss csiphy Wenmeng Liu
2025-06-20 4:07 ` [RFC PATCH 1/3] media: dt-bindings: Add regulator current load Wenmeng Liu
2025-06-20 8:35 ` Krzysztof Kozlowski [this message]
2025-06-20 4:07 ` [RFC PATCH 2/3] media: qcom: camss: csiphy: Add regulator current load setting Wenmeng Liu
2025-06-20 4:07 ` [RFC PATCH 3/3] arm64: dts: qcom: qcs6490-rb3gen2: Add csiphy current support Wenmeng Liu
2025-06-20 8:33 ` Krzysztof Kozlowski
2025-06-20 8:23 ` [RFC PATCH 0/3] Add current load setting for qcom camss csiphy Bryan O'Donoghue
2025-06-27 9:34 ` Wenmeng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96ee2939-d0d6-439e-bde4-1e5476214c5a@kernel.org \
--to=krzk@kernel.org \
--cc=akapatra@quicinc.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hariramp@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_depengs@quicinc.com \
--cc=quic_svankada@quicinc.com \
--cc=quic_vikramsa@quicinc.com \
--cc=quic_wenmliu@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).