* Re: [PATCH v4] dt-bindings: arm: keystone: add boot_* mboxes to ti,sci
2025-12-05 6:15 [PATCH v4] dt-bindings: arm: keystone: add boot_* mboxes to ti,sci Anshul Dalal
@ 2025-12-05 13:01 ` Nishanth Menon
2025-12-05 14:58 ` Andrew Davis
2025-12-08 6:20 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Nishanth Menon @ 2025-12-05 13:01 UTC (permalink / raw)
To: Anshul Dalal
Cc: Tero Kristo, Santosh Shilimkar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Andrew Davis, linux-arm-kernel, devicetree,
linux-kernel, Vignesh Raghavendra
On 11:45-20251205, Anshul Dalal wrote:
> The bootloader on K3 devices makes use of mailboxes as per the ROM spec
> which might be different than one's available to the kernel (firmware
> spec).
>
> Therefore, this patch adds the missing mailbox entries to the DT binding
> if the matching compatible is ti,am654-sci to represent the mailboxes
> exposed by the hardware during boot for the purpose of loading the
> firmware.
>
> Signed-off-by: Anshul Dalal <anshuld@ti.com>
> ---
> Changes in v4:
> - Make new boot_* mboxes conditional on ti,am654-sci compatible
> - Link to v3: https://lore.kernel.org/r/20251112-k3_syscon_add_boot_mailboxes-v3-1-66155a4236dc@ti.com
>
> Changes in v3:
> - Drop [1/2] of the last patch series
> - Update existing example with boot_* mailboxes instead of adding a new one
> - Link to v2: https://lore.kernel.org/r/20251112-k3_syscon_add_boot_mailboxes-v2-0-aebc1e47b391@ti.com
>
> Changes in v2:
> - Remove maxItems entry
> - Remove RFC tag from patch (added by mistake in v1)
> - Document the new mailboxes in mboxes instead of mbox-names
> - Provide example with all the mailboxes set
> - Update commit title to have "ti,sci"
> - Split into two patches
> - Link to v1: https://lore.kernel.org/r/20251111-k3_syscon_add_boot_mailboxes-v1-1-529a27f21076@ti.com
> ---
> .../devicetree/bindings/arm/keystone/ti,sci.yaml | 50 +++++++++++++++++++---
> 1 file changed, 43 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index 25a2b42105e5..d9eb2a81e539 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -51,15 +51,15 @@ properties:
> minItems: 1
>
> mbox-names:
> + minItems: 2
> + maxItems: 6
> description: |
> Specifies the mailboxes used to communicate with TI-SCI Controller
> made available from TI-SCI controller.
> - items:
> - - const: rx
> - - const: tx
>
> mboxes:
> minItems: 2
> + maxItems: 6
>
> ti,host-id:
> $ref: /schemas/types.yaml#/definitions/uint32
> @@ -79,6 +79,42 @@ properties:
> type: object
> $ref: /schemas/reset/ti,sci-reset.yaml#
>
> +if:
> + properties:
> + compatible:
> + contains:
> + const: ti,am654-sci
> +then:
> + properties:
> + mbox-names:
> + minItems: 2
> + items:
> + - const: rx
> + - const: tx
> + - const: notify
> + - const: boot_rx
> + - const: boot_tx
> + - const: boot_notify
> + mboxes:
> + minItems: 2
> + items:
> + - description: RX thread
> + - description: TX thread
> + - description: Notify thread
> + - description: boot stage RX thread
> + - description: boot stage TX thread
> + - description: boot stage Notify thread
> +else:
> + properties:
> + mbox-names:
> + items:
> + - const: rx
> + - const: tx
> + mboxes:
> + items:
> + - description: RX thread
> + - description: TX thread
> +
> required:
> - compatible
> - mbox-names
> @@ -99,11 +135,11 @@ examples:
>
> - |
> dmsc: system-controller@44083000 {
> - compatible = "ti,k2g-sci";
> + compatible = "ti,am654-sci";
> ti,host-id = <12>;
> - mbox-names = "rx", "tx";
> - mboxes = <&secure_proxy_main 11>,
> - <&secure_proxy_main 13>;
> + mbox-names = "rx", "tx", "notify", "boot_rx", "boot_tx";
> + mboxes= <&secure_proxy_mcu 6>, <&secure_proxy_mcu 8>,
> + <&secure_proxy_mcu 5>, <&secure_proxy_mcu 5>, <&secure_proxy_mcu 4>;
> reg-names = "debug_messages";
> reg = <0x44083000 0x1000>;
Create another example. why are we dropping k2g-sci - that is still
valid and the schema must continue to support - so functions as a
validation.
However, i'd like to make sure this can handle two different patterns -
example: AM62x and j784s4.
>
>
> ---
> base-commit: 4427259cc7f7571a157fbc9b5011e1ef6fe0a4a8
> change-id: 20251105-k3_syscon_add_boot_mailboxes-8452bdd98962
>
> Best regards,
> --
> Anshul Dalal <anshuld@ti.com>
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
https://ti.com/opensource
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] dt-bindings: arm: keystone: add boot_* mboxes to ti,sci
2025-12-05 6:15 [PATCH v4] dt-bindings: arm: keystone: add boot_* mboxes to ti,sci Anshul Dalal
2025-12-05 13:01 ` Nishanth Menon
@ 2025-12-05 14:58 ` Andrew Davis
2025-12-08 6:20 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Andrew Davis @ 2025-12-05 14:58 UTC (permalink / raw)
To: Anshul Dalal, Nishanth Menon, Tero Kristo, Santosh Shilimkar,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, devicetree, linux-kernel, Vignesh Raghavendra
On 12/5/25 12:15 AM, Anshul Dalal wrote:
> The bootloader on K3 devices makes use of mailboxes as per the ROM spec
> which might be different than one's available to the kernel (firmware
> spec).
>
See this was the part that confused me earlier into thinking this was
for different processing elements. But really even the same processor
could need both sets of mailboxes, pre and post loading the SCI firmware.
It isn't about "boot" vs "kernel", it is "ROM" vs "Firmware".
How about instead of boot_* you call them rom_*? Or at very least update
this commit message and the "description" in the schema to not simply
say "boot stage".
> Therefore, this patch adds the missing mailbox entries to the DT binding
> if the matching compatible is ti,am654-sci to represent the mailboxes
> exposed by the hardware during boot for the purpose of loading the
> firmware.
>
> Signed-off-by: Anshul Dalal <anshuld@ti.com>
> ---
> Changes in v4:
> - Make new boot_* mboxes conditional on ti,am654-sci compatible
> - Link to v3: https://lore.kernel.org/r/20251112-k3_syscon_add_boot_mailboxes-v3-1-66155a4236dc@ti.com
>
> Changes in v3:
> - Drop [1/2] of the last patch series
> - Update existing example with boot_* mailboxes instead of adding a new one
> - Link to v2: https://lore.kernel.org/r/20251112-k3_syscon_add_boot_mailboxes-v2-0-aebc1e47b391@ti.com
>
> Changes in v2:
> - Remove maxItems entry
> - Remove RFC tag from patch (added by mistake in v1)
> - Document the new mailboxes in mboxes instead of mbox-names
> - Provide example with all the mailboxes set
> - Update commit title to have "ti,sci"
> - Split into two patches
> - Link to v1: https://lore.kernel.org/r/20251111-k3_syscon_add_boot_mailboxes-v1-1-529a27f21076@ti.com
> ---
> .../devicetree/bindings/arm/keystone/ti,sci.yaml | 50 +++++++++++++++++++---
> 1 file changed, 43 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index 25a2b42105e5..d9eb2a81e539 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -51,15 +51,15 @@ properties:
> minItems: 1
>
> mbox-names:
> + minItems: 2
> + maxItems: 6
This doesn't seem right, why add these here when you set the exact
items allowed down below in the if/then block?
> description: |
> Specifies the mailboxes used to communicate with TI-SCI Controller
> made available from TI-SCI controller.
> - items:
> - - const: rx
> - - const: tx
>
> mboxes:
> minItems: 2
> + maxItems: 6
>
> ti,host-id:
> $ref: /schemas/types.yaml#/definitions/uint32
> @@ -79,6 +79,42 @@ properties:
> type: object
> $ref: /schemas/reset/ti,sci-reset.yaml#
>
> +if:
> + properties:
> + compatible:
> + contains:
> + const: ti,am654-sci
> +then:
> + properties:
> + mbox-names:
> + minItems: 2
If you are listing 6 items, then the number needed is exactly 6, no
need for a minimum less than that. I also think this is enforced without
needing to set min/max if you list the items explicitly.
> + items:
> + - const: rx
> + - const: tx
> + - const: notify
> + - const: boot_rx
> + - const: boot_tx
> + - const: boot_notify
> + mboxes:
> + minItems: 2
> + items:
> + - description: RX thread
> + - description: TX thread
> + - description: Notify thread
> + - description: boot stage RX thread
> + - description: boot stage TX thread
> + - description: boot stage Notify thread
> +else:
> + properties:
> + mbox-names:
> + items:
> + - const: rx
> + - const: tx
> + mboxes:
> + items:
> + - description: RX thread
> + - description: TX thread
> +
> required:
> - compatible
> - mbox-names
> @@ -99,11 +135,11 @@ examples:
>
> - |
> dmsc: system-controller@44083000 {
> - compatible = "ti,k2g-sci";
> + compatible = "ti,am654-sci";
> ti,host-id = <12>;
> - mbox-names = "rx", "tx";
> - mboxes = <&secure_proxy_main 11>,
> - <&secure_proxy_main 13>;
> + mbox-names = "rx", "tx", "notify", "boot_rx", "boot_tx";
> + mboxes= <&secure_proxy_mcu 6>, <&secure_proxy_mcu 8>,
> + <&secure_proxy_mcu 5>, <&secure_proxy_mcu 5>, <&secure_proxy_mcu 4>;
nit, how about:
mboxes= <&secure_proxy_mcu 6>,
<&secure_proxy_mcu 8>,
<&secure_proxy_mcu 5>,
<&secure_proxy_mcu 5>,
<&secure_proxy_mcu 4>;
Much easier to parse out the mailbox numbers visually. And to notice
you only have 5 items, but you list 6 in the schema, where is boot_notify?
Andrew
> reg-names = "debug_messages";
> reg = <0x44083000 0x1000>;
>
>
> ---
> base-commit: 4427259cc7f7571a157fbc9b5011e1ef6fe0a4a8
> change-id: 20251105-k3_syscon_add_boot_mailboxes-8452bdd98962
>
> Best regards,
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] dt-bindings: arm: keystone: add boot_* mboxes to ti,sci
2025-12-05 6:15 [PATCH v4] dt-bindings: arm: keystone: add boot_* mboxes to ti,sci Anshul Dalal
2025-12-05 13:01 ` Nishanth Menon
2025-12-05 14:58 ` Andrew Davis
@ 2025-12-08 6:20 ` Krzysztof Kozlowski
2025-12-08 6:31 ` Anshul Dalal
2 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-08 6:20 UTC (permalink / raw)
To: Anshul Dalal
Cc: Nishanth Menon, Tero Kristo, Santosh Shilimkar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Andrew Davis, linux-arm-kernel,
devicetree, linux-kernel, Vignesh Raghavendra
On Fri, Dec 05, 2025 at 11:45:43AM +0530, Anshul Dalal wrote:
> The bootloader on K3 devices makes use of mailboxes as per the ROM spec
> which might be different than one's available to the kernel (firmware
> spec).
>
> Therefore, this patch adds the missing mailbox entries to the DT binding
> if the matching compatible is ti,am654-sci to represent the mailboxes
> exposed by the hardware during boot for the purpose of loading the
> firmware.
>
> Signed-off-by: Anshul Dalal <anshuld@ti.com>
> ---
> Changes in v4:
> - Make new boot_* mboxes conditional on ti,am654-sci compatible
> - Link to v3: https://lore.kernel.org/r/20251112-k3_syscon_add_boot_mailboxes-v3-1-66155a4236dc@ti.com
>
> Changes in v3:
> - Drop [1/2] of the last patch series
> - Update existing example with boot_* mailboxes instead of adding a new one
> - Link to v2: https://lore.kernel.org/r/20251112-k3_syscon_add_boot_mailboxes-v2-0-aebc1e47b391@ti.com
>
> Changes in v2:
> - Remove maxItems entry
> - Remove RFC tag from patch (added by mistake in v1)
> - Document the new mailboxes in mboxes instead of mbox-names
> - Provide example with all the mailboxes set
> - Update commit title to have "ti,sci"
> - Split into two patches
> - Link to v1: https://lore.kernel.org/r/20251111-k3_syscon_add_boot_mailboxes-v1-1-529a27f21076@ti.com
> ---
> .../devicetree/bindings/arm/keystone/ti,sci.yaml | 50 +++++++++++++++++++---
> 1 file changed, 43 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index 25a2b42105e5..d9eb2a81e539 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -51,15 +51,15 @@ properties:
> minItems: 1
>
> mbox-names:
> + minItems: 2
> + maxItems: 6
> description: |
> Specifies the mailboxes used to communicate with TI-SCI Controller
> made available from TI-SCI controller.
> - items:
> - - const: rx
> - - const: tx
>
> mboxes:
> minItems: 2
> + maxItems: 6
>
> ti,host-id:
> $ref: /schemas/types.yaml#/definitions/uint32
> @@ -79,6 +79,42 @@ properties:
> type: object
> $ref: /schemas/reset/ti,sci-reset.yaml#
>
> +if:
> + properties:
> + compatible:
> + contains:
> + const: ti,am654-sci
> +then:
> + properties:
> + mbox-names:
> + minItems: 2
Why is this list flexible?
> + items:
> + - const: rx
> + - const: tx
> + - const: notify
> + - const: boot_rx
> + - const: boot_tx
> + - const: boot_notify
So this list goes to top-level with minItems.
> + mboxes:
> + minItems: 2
> + items:
> + - description: RX thread
> + - description: TX thread
> + - description: Notify thread
> + - description: boot stage RX thread
> + - description: boot stage TX thread
> + - description: boot stage Notify thread
This as well
> +else:
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] dt-bindings: arm: keystone: add boot_* mboxes to ti,sci
2025-12-08 6:20 ` Krzysztof Kozlowski
@ 2025-12-08 6:31 ` Anshul Dalal
2025-12-08 8:06 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Anshul Dalal @ 2025-12-08 6:31 UTC (permalink / raw)
To: Krzysztof Kozlowski, Anshul Dalal
Cc: Nishanth Menon, Tero Kristo, Santosh Shilimkar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Andrew Davis, linux-arm-kernel,
devicetree, linux-kernel, Vignesh Raghavendra
On Mon Dec 8, 2025 at 11:50 AM IST, Krzysztof Kozlowski wrote:
> On Fri, Dec 05, 2025 at 11:45:43AM +0530, Anshul Dalal wrote:
>> The bootloader on K3 devices makes use of mailboxes as per the ROM spec
>> which might be different than one's available to the kernel (firmware
>> spec).
>>
>> Therefore, this patch adds the missing mailbox entries to the DT binding
>> if the matching compatible is ti,am654-sci to represent the mailboxes
>> exposed by the hardware during boot for the purpose of loading the
>> firmware.
>>
>> Signed-off-by: Anshul Dalal <anshuld@ti.com>
>> ---
>> Changes in v4:
>> - Make new boot_* mboxes conditional on ti,am654-sci compatible
>> - Link to v3: https://lore.kernel.org/r/20251112-k3_syscon_add_boot_mailboxes-v3-1-66155a4236dc@ti.com
>>
>> Changes in v3:
>> - Drop [1/2] of the last patch series
>> - Update existing example with boot_* mailboxes instead of adding a new one
>> - Link to v2: https://lore.kernel.org/r/20251112-k3_syscon_add_boot_mailboxes-v2-0-aebc1e47b391@ti.com
>>
>> Changes in v2:
>> - Remove maxItems entry
>> - Remove RFC tag from patch (added by mistake in v1)
>> - Document the new mailboxes in mboxes instead of mbox-names
>> - Provide example with all the mailboxes set
>> - Update commit title to have "ti,sci"
>> - Split into two patches
>> - Link to v1: https://lore.kernel.org/r/20251111-k3_syscon_add_boot_mailboxes-v1-1-529a27f21076@ti.com
>> ---
>> .../devicetree/bindings/arm/keystone/ti,sci.yaml | 50 +++++++++++++++++++---
>> 1 file changed, 43 insertions(+), 7 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> index 25a2b42105e5..d9eb2a81e539 100644
>> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> @@ -51,15 +51,15 @@ properties:
>> minItems: 1
>>
>> mbox-names:
>> + minItems: 2
>> + maxItems: 6
>> description: |
>> Specifies the mailboxes used to communicate with TI-SCI Controller
>> made available from TI-SCI controller.
>> - items:
>> - - const: rx
>> - - const: tx
>>
>> mboxes:
>> minItems: 2
>> + maxItems: 6
>>
>> ti,host-id:
>> $ref: /schemas/types.yaml#/definitions/uint32
>> @@ -79,6 +79,42 @@ properties:
>> type: object
>> $ref: /schemas/reset/ti,sci-reset.yaml#
>>
>> +if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: ti,am654-sci
>> +then:
>> + properties:
>> + mbox-names:
>> + minItems: 2
>
> Why is this list flexible?
>
The idea is to make the boot_* mboxes optional so the existing DTs that
only have rx and tx remain complaint. Also, the boot_notify mbox is not
supported by every SoC.
>> + items:
>> + - const: rx
>> + - const: tx
>> + - const: notify
>> + - const: boot_rx
>> + - const: boot_tx
>> + - const: boot_notify
>
> So this list goes to top-level with minItems.
>
>> + mboxes:
>> + minItems: 2
>> + items:
>> + - description: RX thread
>> + - description: TX thread
>> + - description: Notify thread
>> + - description: boot stage RX thread
>> + - description: boot stage TX thread
>> + - description: boot stage Notify thread
>
> This as well
>
>> +else:
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] dt-bindings: arm: keystone: add boot_* mboxes to ti,sci
2025-12-08 6:31 ` Anshul Dalal
@ 2025-12-08 8:06 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-08 8:06 UTC (permalink / raw)
To: Anshul Dalal
Cc: Nishanth Menon, Tero Kristo, Santosh Shilimkar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Andrew Davis, linux-arm-kernel,
devicetree, linux-kernel, Vignesh Raghavendra
On 08/12/2025 07:31, Anshul Dalal wrote:
>>>
>>> mboxes:
>>> minItems: 2
>>> + maxItems: 6
>>>
>>> ti,host-id:
>>> $ref: /schemas/types.yaml#/definitions/uint32
>>> @@ -79,6 +79,42 @@ properties:
>>> type: object
>>> $ref: /schemas/reset/ti,sci-reset.yaml#
>>>
>>> +if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: ti,am654-sci
>>> +then:
>>> + properties:
>>> + mbox-names:
>>> + minItems: 2
>>
>> Why is this list flexible?
>>
>
> The idea is to make the boot_* mboxes optional so the existing DTs that
Then explain it in the commit msg.
> only have rx and tx remain complaint. Also, the boot_notify mbox is not
> supported by every SoC.
Not really relevant. This is one specific SoC. Not "every"...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread