From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f40.google.com (mail-pj2-f40.google.com [74.125.227.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A39D42517A5 for ; Mon, 5 Oct 2026 03:08:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.168 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791169690; cv=none; b=aJqSL5eA8QOyArUgYBL5HAN15AT021YRanzE4gj5lDkRZ4v2x8/oNqV9E4p0NBewCi2UDht3+vb/DolZUcTj6poYhHZu7Taxyl/GlX3slXCTaXoAxTHSUgl5LJxVmkHHYaGOMNcl27/js3ymcK8Fkx68LFyUSSYN/xtZL6CBZrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791169690; c=relaxed/simple; bh=3yFEDiOLVMsJyEOVraTu9nOIGvr8skJyU0mQeCxspoQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uf7/zCBAwHx9D3egp4+jL6QZSGDG53/Gsj9h8S0zyMul4uorekiXmcPCovgP9RjftHUZSYkSmp0DdR3wJCf3unVphmkQVkkYmEfuGsLYTm82xXnHaK3cIjTC0lHuR1cn3yCBKTzo1FfZniSLcLo6Ud7WyQzYyVORb02QfLiDvRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OuEPmH9g; arc=none smtp.client-ip=74.125.227.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OuEPmH9g" Received: by mail-pj2-f40.google.com with SMTP id 98e67ed59e1d1-3a7e13e2a77so293702a91.3 for ; Sun, 04 Oct 2026 20:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791169687; x=1791774487; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iUwgITrS/KUPi15l4I3iar5grcNqp8PamuCjtCJWXOI=; b=OuEPmH9gjMyt8ZuIRBKsASCMQkSyJaZG7JIb9h6TBkpl6F39W4ASAVBWnM6K37K2KX xjCoNoqgI82TUmTdqJR+R5bvBhJbmEr3/y5zP6YQGSPDB0KzRqTHAFaFvEwmWAX/AGYg 5dbokoi/0iBcaa7SV4IZOxTpXOw4TKUKA77LRqnKTo+5NuRyKceq6ek9wqYb1IzmBnOW hgQ+AWb0AqeujX7RlIkXkfD8MCSkwVQZhOu8Ea1saqRvyOtM3nRFiY0hCu2u9Ax+uKqj TcnWWNm+rL15H4mycUJj4HV8PdYdOiD4RJ2Ho5w5pYiW04+vduPZamUjZP7uvX4rRQdu P9Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791169687; x=1791774487; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iUwgITrS/KUPi15l4I3iar5grcNqp8PamuCjtCJWXOI=; b=k1JBZiNPsxcoGfIVorOKu/niBo3ru91TGd+Td2tmVZsJmK92Rw7wXfOamXy9SKhVD4 /zwrv+FRo7O1H+q5cV/NnfWKEowgYuczAmwynOqNOj+VAgrT3cfaJ8wfaQwvzx1obEy5 PXM9w2fhwIhb8hpQJqxleezLBnYYR/GdoyF1wpdXdZVy2hyVq/zpGoTiCd6J2lP3QduY X72LLyh6pl5B6/jF3yyw8TE++1cVnaw4Gu6IC8KVTxH3XrS/L/c6+6uvo12F8Z5kitCU SkIZnxkYaSfum4FlK+tvVE1aifCVOszs2Fd6xCxUYTvtRyEpQ/hdWjfq9KF5aNe1BDoh clvg== X-Forwarded-Encrypted: i=1; AKwUvBwYY5dm6zzJL+Az2Fy/uDRocQTRSUj6L0V1bonqnJa/MnY3zDSQ/aJF0Oh59750cM6ojSa940Pw8Bq8@vger.kernel.org X-Gm-Message-State: AFq9FYJJi47YrM7aPm0bVM5+S2I5J7aldNse3On7uxRnd4xTEyXD7vPz G+/E0BtGz/kib+HTuLOxumA4TVXtDAcfXhEmyt8QOexk81MkUIhBugeC X-Gm-Gg: AYBFou24QuUQ44Ri7Pcolz/5ciBe7ElOFl2ILHFsXC0ulJMy2QTmjGfbyMuYX5vkxuc 74vI/QdRsqfPOEZjWDPHsHf9SxzCzDbk7p+cuyCOSgoNxYgeQdPS7z28gbnvcPe4MGebbFIcvEA MOYYDKWF0Ta4Qu2SN0H+gZmH35HVE7+wbneyxiOtOB4Kixu5pYrgZxSxHan7gyapjgmppaBLOQP yZlCh0V3WdvFsjjprxSgwRchTU8F0qrPMQzXWau0xH+8ThcM++zqSTxFLcXqj4HKBUVDIcpuqKo 5+y1SiY8HzLyKR7MD/glNYn+SQCDBHU++CTca+awu4YExPuP6bH7o4hv2zODCOljVxkCJxBUj91 ZfthoBE7U3tDnaQEUffVajchrtw0YlTyigCESZohE6jRgNeZOX+x64r/MqtKiQOoojBNSq3VoBF g/mokAiDtC0+nRJic/m9sqpXat+7UgQbC5kxDsCw7y5qXXhnniR0Ig+YhGlp/f8YjMPvsaOJ7lY CDsh9HHRPi2EyxkBVNOrHRZCu5w7Cob8cI2L8x3xVSgpIqHDw== X-Received: by 2002:a17:90b:4ac1:b0:3a0:ddd6:896c with SMTP id 98e67ed59e1d1-3a6ce6af244mr7716297a91.17.1791169686748; Sun, 04 Oct 2026 20:08:06 -0700 (PDT) Received: from [172.19.1.42] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a78e497230sm8991834a91.11.2026.10.04.20.08.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Oct 2026 20:08:05 -0700 (PDT) Message-ID: <9706e01c-9c90-4dbc-a694-7f88bf7ee38c@gmail.com> Date: Mon, 5 Oct 2026 11:08:02 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] spi: dt-bindings: nuvoton,ma35d1-qspi: Add MA35D1 SPI controller To: Krzysztof Kozlowski Cc: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, cwweng@nuvoton.com References: <20261001131818.110028-1-cwweng.linux@gmail.com> <20261001131818.110028-2-cwweng.linux@gmail.com> <20261003-innocent-placid-markhor-e7c6ec@quoll> Content-Language: en-US From: Chi-Wen Weng In-Reply-To: <20261003-innocent-placid-markhor-e7c6ec@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Krzysztof Kozlowski 於 2026/10/3 下午 10:25 寫道: > On Thu, Oct 01, 2026 at 09:18:16PM +0800, Chi-Wen Weng wrote: >> From: Chi-Wen Weng >> >> Extend the existing MA35D1 QSPI binding to also describe the MA35D1 SPI >> controller. >> >> The SPI and QSPI controllers are separate hardware IPs. QSPI additionally >> supports dual, quad and DTR transfers and a target-mode timeout function, >> but these differences do not require additional controller-specific >> Devicetree properties. >> >> Both controllers expose the same Devicetree-visible resources and provide >> up to two native chip-select signals. GPIO chip selects are supported >> through the generic SPI controller binding. Since the MA35D1 QSPI driver >> now supports GPIO chip selects, also remove the existing restriction >> on cs-gpios for the QSPI compatible. > > This has to be a separate commit. > >> >> Add the nuvoton,ma35d1-spi compatible and update the binding description >> and examples to cover both controllers. >> >> Signed-off-by: Chi-Wen Weng >> --- >> .../bindings/spi/nuvoton,ma35d1-qspi.yaml | 41 +++++++++++++++++-- >> 1 file changed, 37 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml b/Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml >> index 40965ec5163b..72f2e1e1219a 100644 >> --- a/Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml >> +++ b/Documentation/devicetree/bindings/spi/nuvoton,ma35d1-qspi.yaml >> @@ -4,7 +4,17 @@ >> $id: http://devicetree.org/schemas/spi/nuvoton,ma35d1-qspi.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> -title: Nuvoton MA35D1 Quad SPI Controller >> +title: Nuvoton MA35D1 SPI and Quad SPI Controllers >> + >> +description: | >> + The Nuvoton MA35D1 SoC contains separate SPI and QSPI controller IPs. >> + Both controllers expose the same Devicetree-visible resources and provide >> + two native chip-select signals. GPIO chip selects are supported through the >> + generic SPI controller binding. >> + >> + The QSPI controller additionally supports dual, quad and DTR transfers and >> + a target-mode timeout function. These capability differences do not require >> + additional controller properties. >> >> maintainers: >> - Chi-Wen Weng >> @@ -14,7 +24,9 @@ allOf: >> >> properties: >> compatible: >> - const: nuvoton,ma35d1-qspi >> + enum: >> + - nuvoton,ma35d1-spi >> + - nuvoton,ma35d1-qspi >> >> reg: >> maxItems: 1 >> @@ -33,8 +45,6 @@ properties: >> maximum: 2 >> default: 2 >> >> - cs-gpios: false >> - >> required: >> - compatible >> - reg >> @@ -59,7 +69,30 @@ examples: >> interrupts = ; >> clocks = <&clk QSPI0_GATE>; >> resets = <&sys MA35D1_RESET_QSPI0>; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + }; >> + }; >> + >> + - | >> + #include >> + #include >> + #include >> + > > No need for a new example, for exactly the same node. Difference in > value of a property does not justify it. > > Best regards, > Krzysztof Hi Krzysztof, Thanks for the review. I will address both comments in v3. For the binding changes, I will split the current patch into two separate commits: 1. Extend the existing MA35D1 QSPI binding to also describe the MA35D1 SPI controller. This patch will only update the title, description and compatible list to cover both the SPI and QSPI controllers. The existing `cs-gpios: false` restriction will remain in this commit. 2. Add a separate binding patch to allow GPIO chip selects. This patch will remove the existing `cs-gpios: false` restriction so that the generic SPI controller binding can provide GPIO chip-select support. I will also drop the additional SPI example. Since the SPI and QSPI controllers use the same node structure and only differ in property values, the existing example is sufficient. So the v3 series is planned as: 1. spi: dt-bindings: nuvoton,ma35d1-qspi: Add MA35D1 SPI controller 2. spi: dt-bindings: nuvoton,ma35d1-qspi: Allow GPIO chip selects 3. spi: ma35d1: Add Nuvoton MA35D1 SPI controller support 4. spi: ma35d1-qspi: Add GPIO chip select support Thanks, Chi-Wen