From: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
To: Val Packett <val@packett.cool>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Subject: Re: [PATCH v2 2/3] ASoC: qcom: q6apm-lpass-dais: Add MI2S clock control
Date: Mon, 15 Jun 2026 15:16:14 +0530 [thread overview]
Message-ID: <970e9449-ef38-47d2-8e77-9f406722afa9@oss.qualcomm.com> (raw)
In-Reply-To: <8b2318ff-d07c-4c2d-9c2d-ef7c5c763096@packett.cool>
On 6/8/2026 8:19 AM, Val Packett wrote:
>
> On 6/7/26 11:30 PM, Mohammad Rafi Shaik wrote:
>> Add support for MI2S clock control within q6apm-lpass DAIs, including
>> handling of MCLK, BCLK, and ECLK via the DAI .set_sysclk callback.
>> Each MI2S port now retrieves its clock handles from the device tree,
>> allowing per-port clock configuration and proper enable/disable during
>> startup and shutdown.
>> [..]
>> @@ -297,6 +373,59 @@ static const struct snd_soc_component_driver
>> q6apm_lpass_dai_component = {
>> .remove_order = SND_SOC_COMP_ORDER_FIRST,
>> };
>> +static int of_q6apm_parse_dai_data(struct device *dev,
>> + struct q6apm_lpass_dai_data *data)
>> +{
>> + struct device_node *node;
>> + int ret;
>> +
>> + for_each_child_of_node(dev->of_node, node) {
>> + struct q6apm_dai_priv_data *priv;
>> + int id;
>> +
>> + ret = of_property_read_u32(node, "reg", &id);
>> + if (ret || id < 0 || id >= APM_PORT_MAX) {
>> + dev_err(dev, "valid dai id not found:%d\n", ret);
>> + continue;
>> + }
>> +
>> + switch (id) {
>> + /* MI2S specific properties */
>> + case PRIMARY_MI2S_RX ... QUATERNARY_MI2S_TX:
>> + case QUINARY_MI2S_RX ... QUINARY_MI2S_TX:
>
> SENARY is also a thing these days btw..
>
Ack, will include SENARY dai also.
Thanks & Regards,
Rafi.
>
> ~val
>
next prev parent reply other threads:[~2026-06-15 9:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 2:30 [PATCH v2 0/3] ASoC: qcom: qdsp6: Add MI2S clock control Mohammad Rafi Shaik
2026-06-08 2:30 ` [PATCH v2 1/3] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode Mohammad Rafi Shaik
2026-06-08 4:44 ` sashiko-bot
2026-06-08 9:59 ` Krzysztof Kozlowski
2026-06-08 2:30 ` [PATCH v2 2/3] ASoC: qcom: q6apm-lpass-dais: Add MI2S clock control Mohammad Rafi Shaik
2026-06-08 2:38 ` sashiko-bot
2026-06-08 2:49 ` Val Packett
2026-06-15 9:46 ` Mohammad Rafi Shaik [this message]
2026-06-08 12:01 ` Mark Brown
2026-06-15 10:00 ` Mohammad Rafi Shaik
2026-06-08 2:30 ` [PATCH v2 3/3] ASoC: qcom: sc8280xp: ASoC: qcom: sc8280xp: enhance machine driver for board-specific config Mohammad Rafi Shaik
2026-06-08 2:41 ` sashiko-bot
2026-06-08 12:08 ` Mark Brown
2026-06-15 10:11 ` Mohammad Rafi Shaik
2026-06-08 8:23 ` [PATCH v2 0/3] ASoC: qcom: qdsp6: Add MI2S clock control Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=970e9449-ef38-47d2-8e77-9f406722afa9@oss.qualcomm.com \
--to=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=tiwai@suse.com \
--cc=val@packett.cool \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox