From: Fabio Estevam <festevam@denx.de>
To: Martin Kepplinger <martink@posteo.de>
Cc: Fabio Estevam <festevam@gmail.com>,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] media: dt-bindings: hynix,hi846: Document orientation and rotation
Date: Thu, 28 Sep 2023 09:13:57 -0300 [thread overview]
Message-ID: <970e9b41f1ee76c509dec032fa277eb0@denx.de> (raw)
In-Reply-To: <38925de00ef14354a17e2437284e08d0524e6a23.camel@posteo.de>
Hi Martin,
On 28/09/2023 06:20, Martin Kepplinger wrote:
unevaluatedProperties: false
>
> hi Fabio,
>
> thanks a lot, I like to have this fixed. I always thought we could re-
> use media/video-interface-devices.yaml for these properties somehow...
>
> if your change is preferred,
>
> Acked-by: Martin Kepplinger <martink@posteo.de>
Good point on video-interface-devices.yaml.
Indeed, we should pass a reference to it.
Otherwise, after this patch, hynix,hi846.yaml will only check for the
presence of
orientation/rotation properties and not check whether the values are
valid.
I will submit a v2 that adds the aditional ref to
video-interface-devices.yaml
Thanks!
prev parent reply other threads:[~2023-09-28 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 18:16 [PATCH] media: dt-bindings: hynix,hi846: Document orientation and rotation Fabio Estevam
2023-09-28 6:23 ` Krzysztof Kozlowski
2023-09-28 9:20 ` Martin Kepplinger
2023-09-28 12:13 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=970e9b41f1ee76c509dec032fa277eb0@denx.de \
--to=festevam@denx.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=martink@posteo.de \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).