From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 1/7] dt-bindings: media: platform: visconti: Add Toshiba Visconti MIPI CSI-2 Receiver
Date: Thu, 16 Oct 2025 08:38:25 +0200 [thread overview]
Message-ID: <97184b19-156c-4c42-ac8a-dc9800ea64af@kernel.org> (raw)
In-Reply-To: <20251016-visconti-viif-v13-1-ceca656b9194@toshiba.co.jp>
On 16/10/2025 04:24, Yuji Ishikawa wrote:
> Adds the Device Tree binding documentation that allows to describe
"Add".
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
> the MIPI CSI-2 Receiver found in Toshiba Visconti SoCs.
...
> +examples:
> + - |
> + #include <dt-bindings/clock/toshiba,tmpv770x.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + csi0: csi@1c008000 {
I don't understand why the label appeared. It is not used and it wasn't
here before. I did not ask to add label, but I only asked to fix the
node name to match generic names rule.
Drop the label. With these fixes:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-16 6:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 2:24 [PATCH v13 0/7] Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2025-10-16 2:24 ` [PATCH v13 1/7] dt-bindings: media: platform: visconti: Add Toshiba Visconti MIPI CSI-2 Receiver Yuji Ishikawa
2025-10-16 4:34 ` Frank Li
2025-10-20 6:11 ` yuji2.ishikawa
2025-10-16 6:38 ` Krzysztof Kozlowski [this message]
2025-10-20 6:16 ` yuji2.ishikawa
2025-10-16 2:24 ` [PATCH v13 2/7] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface Yuji Ishikawa
2025-10-16 6:39 ` Krzysztof Kozlowski
2025-10-16 2:24 ` [PATCH v13 3/7] media: uapi: Add visconti viif meta buffer formats Yuji Ishikawa
2025-10-16 2:24 ` [PATCH v13 4/7] media: platform: visconti: Add Toshiba Visconti CSI-2 Receiver driver Yuji Ishikawa
2025-10-16 4:45 ` Frank Li
2025-10-20 6:13 ` yuji2.ishikawa
2025-10-20 16:05 ` Frank Li
2025-10-16 2:24 ` [PATCH v13 5/7] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2025-10-16 2:24 ` [PATCH v13 6/7] media: platform: visconti: Add streaming interface for ISP parameters and statistics Yuji Ishikawa
2025-10-16 2:24 ` [PATCH v13 7/7] documentation: media: Add documentation for Toshiba Visconti Video Input Interface driver Yuji Ishikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97184b19-156c-4c42-ac8a-dc9800ea64af@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nobuhiro.iwamatsu.x90@mail.toshiba \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).