From: "Nuno Sá" <noname.nuno@gmail.com>
To: "Torreno, Alexis Czezar" <AlexisCzezar.Torreno@analog.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
David Lechner <dlechner@baylibre.com>,
"Sa, Nuno" <Nuno.Sa@analog.com>,
Andy Shevchenko <andy@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] iio: dac: ad5706r: Add support for AD5706R DAC
Date: Wed, 25 Mar 2026 10:14:50 +0000 [thread overview]
Message-ID: <975f2df6090f3aea0524369ef07f2a648064f010.camel@gmail.com> (raw)
In-Reply-To: <PH0PR03MB6351C1D87987E0533F4A07EEF149A@PH0PR03MB6351.namprd03.prod.outlook.com>
On Wed, 2026-03-25 at 03:13 +0000, Torreno, Alexis Czezar wrote:
> > > > + ret = spi_sync_transfer(st->spi, xfer, ARRAY_SIZE(xfer));
> > >
> > > Can you use spi_write_the_read()?
> > > Has the added advantage that it bounces the data so doesn't need DMA safe.
> > > Can also use more meaningful types like
> > > __be16 tx;
> > > __be16 rx16;
> > > u8 rx8;
> >
> > Ok, will shift to spi_write_the_read(). There was another place to use this
> > above, just trimmed it off here. Noted on the more meaningful variables.
> >
>
> I only just checked spi_write_then_read() but, it seems this doesn't support
> variable spi_speed_frequency for my future patches. Should I still use it for now
> and revert in the future?
There's still the open regmap discussion. Independent of that, if you can't use
spi_write_then_read(), you need to make sure the buffers you pass spi are DMA safe.
- Nuno Sá
next prev parent reply other threads:[~2026-03-25 10:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 5:13 [PATCH v3 0/2] Add support for AD5706R DAC Alexis Czezar Torreno
2026-03-18 5:13 ` [PATCH v3 1/2] dt-bindings: iio: dac: Add ADI AD5706R Alexis Czezar Torreno
2026-03-18 6:59 ` Krzysztof Kozlowski
2026-03-19 5:23 ` Torreno, Alexis Czezar
2026-03-18 5:13 ` [PATCH v3 2/2] iio: dac: ad5706r: Add support for AD5706R DAC Alexis Czezar Torreno
2026-03-18 8:16 ` Andy Shevchenko
2026-03-19 5:23 ` Torreno, Alexis Czezar
2026-03-19 7:07 ` Andy Shevchenko
2026-03-25 1:07 ` Torreno, Alexis Czezar
2026-03-25 10:13 ` Nuno Sá
2026-03-25 12:12 ` Andy Shevchenko
2026-03-27 9:01 ` Torreno, Alexis Czezar
2026-03-21 18:39 ` Jonathan Cameron
2026-03-25 1:22 ` Torreno, Alexis Czezar
2026-03-25 3:13 ` Torreno, Alexis Czezar
2026-03-25 10:14 ` Nuno Sá [this message]
2026-03-25 11:02 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=975f2df6090f3aea0524369ef07f2a648064f010.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=AlexisCzezar.Torreno@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox