From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: renesas: Document preferred compatible naming
Date: Fri, 1 Dec 2023 10:19:12 +0100 [thread overview]
Message-ID: <9792147e-da08-4215-94fb-dadbddc23384@linaro.org> (raw)
In-Reply-To: <ZWiLTYU_Hj0bl1gn@oden.dyn.berto.se>
On 30/11/2023 14:17, Niklas Söderlund wrote:
>>
>>> + - enum:
>>> + - renesas,cpg-div6-clock
>>> + - renesas,cpg-mstp-clocks
>>> + - renesas,intc-irqpin
>>> + - renesas,smp-sram
>>
>> smp-sram can have new compatibles? I am sorry, but this needs explanation...
>
> The intention is to list SoC agnostic compatibles here, or put another
> way false positives to the generic pattern "renesas,.*-.*". So no
> "renesas,smp-sram" can't have new compatibles but there might be new
> renesas compatible strings that hit the pattern that is not related to a
> SoC. Does this make sens?
Well, now I get the meaning, but I don't find this obvious especially
considering that contributors many, many times misunderstand "SoC
agnostic" with "generic is OK". Generic compatible is not OK for the
SoC. I think it is still the most repeated feedback from me.
I hope you will be explaining this for Renesas contributors :)
Best regards,
Krzysztof
prev parent reply other threads:[~2023-12-01 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 23:28 [PATCH] dt-bindings: renesas: Document preferred compatible naming Niklas Söderlund
2023-11-28 9:51 ` Krzysztof Kozlowski
2023-11-28 10:32 ` Geert Uytterhoeven
2023-11-28 14:32 ` Krzysztof Kozlowski
2023-11-30 14:27 ` Geert Uytterhoeven
2023-11-30 13:17 ` Niklas Söderlund
2023-12-01 9:19 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9792147e-da08-4215-94fb-dadbddc23384@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).