From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5413C4332F for ; Tue, 29 Nov 2022 08:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbiK2I5O (ORCPT ); Tue, 29 Nov 2022 03:57:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229641AbiK2I5M (ORCPT ); Tue, 29 Nov 2022 03:57:12 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DAB9D75 for ; Tue, 29 Nov 2022 00:57:11 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id be13so21449257lfb.4 for ; Tue, 29 Nov 2022 00:57:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qOArE8my8J/ipU9oMYClbJVsW3lHXFxVNxDO1jO7EJM=; b=zQScKMkcDPLb0VbjVjZbxuia8pV+1yNLJkwoOz5+7uEaU+6msIwDGKIXO6YPKZol+E M9XqTRkg0g9A2cXSGGy/jIz9rC5o8vGonCgrSvqpL4B9T6jWMrMRpMU6DqROQ9aQvN9j dJBuHZfMLbDTc8RSnsufVA52LDzaq9PVCwo8++dceJAbqtj9++MgCIlGUq1df3KRyfvg DkPklmj3A5QvgkGxK2hd9xinWidw30yeQHfNindqR+gPkyi/8W37sTa9TemdN2BtSDZu LhY72igp/L0YRGzG9vo23ai9ah5MOsiGcntbrPMT3QCw4pnG1uwlqyeGTYbfwJ8lV2DM 8Ktg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qOArE8my8J/ipU9oMYClbJVsW3lHXFxVNxDO1jO7EJM=; b=5mtMDm1PbKd0YB3T3aBAnDQOy9KIn8rUWR2GlVgmSQs5RJJcFgBX1/9IQdvhGCkQ2H vKBnMDzJmwpu94jY31K3BbKsLJUP0i/U2ghOtzvGtdLgBYCxSEgDeo+fzaFXXPqeLAT6 h0DDS/U11eOMaPK6UQqmMSD3cXPY/kTQBoRWFHJU07bwHE99AMrIDpdFEvSPrNXzsWHG vbA82rlhWcSqRTk2hpUsQJ4HwbA/PoQspDqi56LgeJiLemTK3NnKBhRWqTQhxiwdOdGK HNQZGw4ZFcyTr2bkppX5gdfKt5Zk2xxLClGTaE11Kl7wOOBpkIavlaNNK88m827no0pr U96g== X-Gm-Message-State: ANoB5pl8xuVJm2j7WeLnljgixVMwUK3P8k32BwNUBAEjr+atbKGvfuIM /RTG2BD7AWBSJxibOBE5I2m6VJdDNeJdksNy X-Google-Smtp-Source: AA0mqf6nzwvf2RmaoCBMIPu+kzJXafNijvrUgD0Yz45ncIT5YtlHx/jG9cgKZI04TjMh48z5zZWvnw== X-Received: by 2002:a05:6512:3049:b0:4a2:3f4b:839 with SMTP id b9-20020a056512304900b004a23f4b0839mr16695594lfb.483.1669711895956; Tue, 29 Nov 2022 00:51:35 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id l18-20020a194952000000b004aa427febe5sm2111342lfj.64.2022.11.29.00.51.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 00:51:35 -0800 (PST) Message-ID: <979d220c-525c-ad57-89b8-b65bda55fe55@linaro.org> Date: Tue, 29 Nov 2022 09:51:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/2] dt-bindings: net: rockchip-dwmac: add rk3568 xpcs compatible Content-Language: en-US From: Krzysztof Kozlowski To: Chukun Pan , "David S . Miller" Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Wu , Rob Herring , Heiko Stuebner , Krzysztof Kozlowski , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20221129072714.22880-1-amadeus@jmu.edu.cn> <6f601615-deab-a1df-b951-dca8467039f8@linaro.org> In-Reply-To: <6f601615-deab-a1df-b951-dca8467039f8@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/11/2022 09:49, Krzysztof Kozlowski wrote: > On 29/11/2022 08:27, Chukun Pan wrote: >> The gmac of RK3568 supports RGMII/SGMII/QSGMII interface. >> This patch adds a compatible string for the required clock. >> >> Signed-off-by: Chukun Pan >> --- >> Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml >> index 42fb72b6909d..36b1e82212e7 100644 >> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml >> @@ -68,6 +68,7 @@ properties: >> - mac_clk_rx >> - aclk_mac >> - pclk_mac >> + - pclk_xpcs >> - clk_mac_ref >> - clk_mac_refout >> - clk_mac_speed >> @@ -90,6 +91,11 @@ properties: >> The phandle of the syscon node for the peripheral general register file. >> $ref: /schemas/types.yaml#/definitions/phandle >> >> + rockchip,xpcs: >> + description: >> + The phandle of the syscon node for the peripheral general register file. > > You used the same description as above, so no, you cannot have two > properties which are the same. syscons for GRF are called > "rockchip,grf", aren't they? Also: 1. Your commit msg does not explain it at all. 2. Your driver code uses this as some phy? Don't use syscon as workaround for missing drivers. Best regards, Krzysztof