From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96CACC636D6 for ; Thu, 16 Feb 2023 10:57:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230316AbjBPK5j (ORCPT ); Thu, 16 Feb 2023 05:57:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230337AbjBPK5c (ORCPT ); Thu, 16 Feb 2023 05:57:32 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C59A956499 for ; Thu, 16 Feb 2023 02:57:09 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id cq19so2224509edb.5 for ; Thu, 16 Feb 2023 02:57:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=THtAgCOl9QgR+PBCQKm+XDfV9tIc7qpiTl9QgWvXcHg=; b=U6H4iC7hYR/chymc+q+RyndAL4se27QK3fvzV8WqQIXuxxRKB3uUKGFgBjrA7pUhA3 TxIdXtyaKdN2b9jgQ/IS7kSk1qgAAicfUPdajYmMdO68hu6gElAWF2tGciziJJJ2dLBy unTddpuWUJKM5PW0GhDoICAGoSiD8ND3c6o/LqYpOJTFrtts6Z0Ctnc88pmdzINdTmOL z0G4cJOvTfV9H9Pe2fA72wHz2Y5/i1cyOIXzZmUQSlvV5V8FGEkKBISBPaNJfSQrpW6q xDWxuzZRmspaKsBw+tYYoLaPol80grKVz8IS3y1SyxRIZUxnJpQNorzRPOwfXEQA/bpf 2MdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=THtAgCOl9QgR+PBCQKm+XDfV9tIc7qpiTl9QgWvXcHg=; b=t0CBgm0W9afd/XVYzFAknG6dci0cfVqe3eyqTqi6f/6RGfUIhDti09QInrjIUy+LA7 qK19zaDJFttEQqLfEEN8NE6czAGBaBW3/wvl7zsTUQAoTdpo5VxXQ9rLGMRPccbXN5cQ tIoyv1rUddRkzf9Mfg5Wn7BhCLtN8lcRlnjW5+hVYN2ve8PZMa6iuhVIT64/0EcYTw7Y ykew/80WOcJo0pnmftwyf2ZPHF+JJtJZEl3iKzlIAQvcfM5Gsk2q78otkQfT9miJn0kx +aRcxTOa2pUzRjobrpeSBJnHtKZvXK6UeMdC3Dx3JdttdPEaIW+9F0zcuwSRRHZ5voI+ tSZA== X-Gm-Message-State: AO0yUKVjlyo+SXEmQNpRiQ1dEB/lqU03CFl3gMDr5TnQUb5B2aswZEAz dfMiU254cnfp7WeeQhbWkNVMCw== X-Google-Smtp-Source: AK7set9OfkNt5LKvITUMHqNbfAMut7qF3b/o8biOq9I1xBhTpbQURE55MHNjA797MY9Vjl5S1t9X0Q== X-Received: by 2002:aa7:d4c1:0:b0:4ad:6fc6:ae9c with SMTP id t1-20020aa7d4c1000000b004ad6fc6ae9cmr432542edr.17.1676545023642; Thu, 16 Feb 2023 02:57:03 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id x72-20020a50bace000000b004acbe8255f1sm669464ede.86.2023.02.16.02.57.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 02:57:03 -0800 (PST) Message-ID: <97a62d16-42cf-d778-f9a2-ddc7cc936d1d@linaro.org> Date: Thu, 16 Feb 2023 11:57:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 00/16] Refactor Exynos PCIe driver to make it generic Content-Language: en-US To: Shradha Todi , lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com, jingoohan1@gmail.com, Sergey.Semin@baikalelectronics.ru, lukas.bulwahn@gmail.com, hongxing.zhu@nxp.com, tglx@linutronix.de, m.szyprowski@samsung.com, jh80.chung@samsung.co, pankaj.dubey@samsung.com Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230214121333.1837-1-shradha.t@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20230214121333.1837-1-shradha.t@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/02/2023 13:13, Shradha Todi wrote: > Currently pci-exynos is being used as a PCIe driver for Exynos5433 > only. This patch set refactors the driver to make it extensible to > other Samsung manufactured SoCs having DWC PCIe controllers. > The major change points are: > - Renaming all common functions/structures to use "samsung" instead > of "exynos". Make common probe/remove/suspend/resume > - Making clock/regulator get/enable/disable generic > - Adding private struct to hold platform specific function ops Thanks for the work. I appreciate it. Some comments in individual patches. Best regards, Krzysztof