Re: [PATCH 1/2] dt-bindings: mfd: Add binding for synology,microp devices

[Krzysztof Kozlowski <krzk@kernel.org>]

On 07/03/2026 16:03, Markus Probst wrote:
>>> +  usb-led:
>>> +    $ref: /schemas/leds/common.yaml
>>> +    unevaluatedProperties: false
>>
>> That's pretty unreadable code.
>>
>>> +  no-check-fan:
>>
>> Vendor prefix
> 
> In the documentation it says
> 
> "
> Nonstandard property names should specify a unique string prefix, such
> as a stock ticker symbol, identifying the name of the company or
> organization that defined the property.
> "
> 
> I am not sure whether to use synology or linux as vendor prefix here.

You cannot have linux prefix - you are not adding bindings for a
abstracted/generalized device.

> 
> The property itself was not defined by synology,
> 
> but the property also is not necessarily specific to linux.
> The driver has to tell the device whether it should even check for fan
> failures. The property wouldn't alter behaviour of the driver, but of

Driver stuff so not really suitable for bindings in the first place.

> the device. The device itself would not check for fan failures anymore.
> 
> Thanks
> - Markus Probst
> 
>>
>>> +    type: boolean
>>> +    description: |
>>> +      Disable fan failure check.
>>
>> You described the desired Linux feature or behavior, not the actual
>> hardware. The bindings are about the latter, so instead you need to
>> rephrase the property and its description to match actual hardware
>> capabilities/features/configuration etc.

Do not ignore the comments.


Best regards,
Krzysztof