From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Henrik Grimler <henrik@grimler.se>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
replicant@osuosl.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
"Martin Jücker" <martin.juecker@gmail.com>,
"Artur Weber" <aweber.kernel@gmail.com>
Subject: Re: [PATCH v2] ARM: dts: samsung: exynos4412-midas: add USB connector and USB OTG
Date: Wed, 26 Jul 2023 09:23:04 +0200 [thread overview]
Message-ID: <97ec26e7-fb3e-ed01-d6f5-563a6ba8b209@linaro.org> (raw)
In-Reply-To: <ZMA9AcfElvuYZTiV@grimlerstat.localdomain>
On 25/07/2023 23:22, Henrik Grimler wrote:
>>> MHL works reliably if cable is attached before boot, but if cable is
>>> attached on already running device it sometimes work after detaching
>>> and attaching cable a few times. On cable attach, when it does not
>>> work, we get:
>>>
>>> [ 252.831734] max77693-muic max77693-muic: external connector is detached(chg_type:0x0, prev_chg_type:0x0)
>>> [ 253.733916] max77693-muic max77693-muic: external connector is attached(chg_type:0x1, prev_chg_type:0x1)
>>> [ 253.735232] max77693-muic max77693-muic: CONTROL1 : 0x09, CONTROL2 : 0x04, state : attached
>>> [ 254.691877] i2c i2c-15: sendbytes: NAK bailout.
>>> [ 254.692150] sii9234 15-0039: writebm: TPI[0x3d] <- 0x3e
>>> [ 255.984336] sii9234 15-0039: RGND is not 1k
>>> [ 256.068970] sii9234 15-0039: RSEN_HIGH without RGND_1K
>>> [ 256.104457] sii9234 15-0039: discovery failed, no power for MHL?
>>> [ 256.118272] i2c i2c-15: sendbytes: NAK bailout.
>>> [ 256.118539] sii9234 15-0039: writebm: TPI[0x3d] <- 0x3e
>>> [ 256.375966] sii9234 15-0039: RSEN_HIGH without RGND_1K
>>> [ 256.411561] sii9234 15-0039: discovery failed, no power for MHL?
>>>
>>> while when it works:
>>>
>>> [ 175.348307] max77693-muic max77693-muic: external connector is detached(chg_type:0x1, prev_chg_type:0x0)
>>> [ 175.349576] max77693-muic max77693-muic: CONTROL1 : 0x00, CONTROL2 : 0x01, state : detached
>>> [ 179.304373] dwc2 12480000.usb: new device is full-speed
>>> [ 179.305920] max77693-muic max77693-muic: external connector is detached(chg_type:0x0, prev_chg_type:0x0)
>>> [ 180.205735] max77693-muic max77693-muic: external connector is attached(chg_type:0x1, prev_chg_type:0x1)
>>> [ 180.207211] max77693-muic max77693-muic: CONTROL1 : 0x09, CONTROL2 : 0x04, state : attached
>>> [ 180.309727] i2c i2c-15: sendbytes: NAK bailout.
>>> [ 180.309996] sii9234 15-0039: writebm: TPI[0x3d] <- 0x3e
>>>
>>> Not sure if issue here is in muic driver or sii9234 driver.
>>>
>>> OTG still does not seem to work, the muic driver detects (only) a
>>> detach when OTG cable is attached:
>>>
>>> max77693-muic max77693-muic: external connector is detached(chg_type:0x0, prev_chg_type:0x0)
>>>
>>> Same happened when otg cable was attached before these hsotg changes
>>> as well. I suppose issue here is with max77693-muic driver.
>>>
>>
>> Thanks for testing. I miss here one important thing - did anything
>> regressed? Is MHL behaving not worse than before? OTG, as non-working,
>> matters less in such case.
>
> No regressions as far as I can tell, only improvements. We want the
> muic node and mhl_to_muic/muic_to_mhl ports so that muic can notify
> the mhl chip of cable attachment/detachment (with requires an
> additional patch to the sii9234 driver that I will send soon [1]).
> The alternative, having the mhl chip always on, has caused issues with
> some GUIs [2].
Awesome, thank you!
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-26 7:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 14:24 [PATCH v2] ARM: dts: samsung: exynos4412-midas: add USB connector and USB OTG Krzysztof Kozlowski
2023-07-25 19:15 ` Henrik Grimler
2023-07-25 20:08 ` Krzysztof Kozlowski
2023-07-25 21:22 ` Henrik Grimler
2023-07-26 7:23 ` Krzysztof Kozlowski [this message]
2023-07-26 8:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97ec26e7-fb3e-ed01-d6f5-563a6ba8b209@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=aweber.kernel@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.juecker@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=replicant@osuosl.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).