* [PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema
@ 2023-01-20 17:40 Krzysztof Kozlowski
2023-01-20 18:58 ` Konrad Dybcio
2023-02-09 4:23 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-20 17:40 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
DT schema expects nodes ending with "pins:
qcom-apq8060-dragonboard.dtb: mpps@50: cm3605-mpps-state: 'oneOf' conditional failed, one must be fixed:
'mpp5' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Warning visible after:
https://lore.kernel.org/r/20230120165103.1278852-1-robh@kernel.org
---
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
index 7a4c59e04af6..8e4b61e4d4b1 100644
--- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
+++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
@@ -435,15 +435,13 @@ &pm8058_led133 {
&pm8058_mpps {
dragon_cm3605_mpps: cm3605-mpps-state {
- mpp5 {
- pins = "mpp5";
- function = "analog";
- input-enable;
- bias-high-impedance;
- /* Let's use channel 5 */
- qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
- power-source = <PM8058_GPIO_S3>;
- };
+ pins = "mpp5";
+ function = "analog";
+ input-enable;
+ bias-high-impedance;
+ /* Let's use channel 5 */
+ qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
+ power-source = <PM8058_GPIO_S3>;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema
2023-01-20 17:40 [PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema Krzysztof Kozlowski
@ 2023-01-20 18:58 ` Konrad Dybcio
2023-02-09 4:23 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-01-20 18:58 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On 20.01.2023 18:40, Krzysztof Kozlowski wrote:
> DT schema expects nodes ending with "pins:
>
> qcom-apq8060-dragonboard.dtb: mpps@50: cm3605-mpps-state: 'oneOf' conditional failed, one must be fixed:
> 'mpp5' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
> Warning visible after:
> https://lore.kernel.org/r/20230120165103.1278852-1-robh@kernel.org
> ---
> arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> index 7a4c59e04af6..8e4b61e4d4b1 100644
> --- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> @@ -435,15 +435,13 @@ &pm8058_led133 {
>
> &pm8058_mpps {
> dragon_cm3605_mpps: cm3605-mpps-state {
> - mpp5 {
> - pins = "mpp5";
> - function = "analog";
> - input-enable;
> - bias-high-impedance;
> - /* Let's use channel 5 */
> - qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
> - power-source = <PM8058_GPIO_S3>;
> - };
> + pins = "mpp5";
> + function = "analog";
> + input-enable;
> + bias-high-impedance;
> + /* Let's use channel 5 */
> + qcom,amux-route = <PMIC_MPP_AMUX_ROUTE_CH5>;
> + power-source = <PM8058_GPIO_S3>;
> };
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema
2023-01-20 17:40 [PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema Krzysztof Kozlowski
2023-01-20 18:58 ` Konrad Dybcio
@ 2023-02-09 4:23 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-02-09 4:23 UTC (permalink / raw)
To: Andy Gross, Rob Herring, Krzysztof Kozlowski, devicetree,
Konrad Dybcio, linux-kernel, Krzysztof Kozlowski, linux-arm-msm
On Fri, 20 Jan 2023 18:40:36 +0100, Krzysztof Kozlowski wrote:
> DT schema expects nodes ending with "pins:
>
> qcom-apq8060-dragonboard.dtb: mpps@50: cm3605-mpps-state: 'oneOf' conditional failed, one must be fixed:
> 'mpp5' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
>
>
Applied, thanks!
[1/1] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema
commit: e58065542e8e95351df86dd3b5ef45dd05c2aa47
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-09 4:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-20 17:40 [PATCH] ARM: dts: qcom: apq8060-dragonboard: align MPP pin node names with DT schema Krzysztof Kozlowski
2023-01-20 18:58 ` Konrad Dybcio
2023-02-09 4:23 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).