From: Caleb Connolly <caleb.connolly@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: qcs6490-rb3gen2: describe secondary USB port
Date: Mon, 9 Sep 2024 13:00:34 +0200 [thread overview]
Message-ID: <98222e56-d382-409c-9c17-a99cab08ec94@linaro.org> (raw)
In-Reply-To: <7f98c987-0f9a-4ff5-9296-c6fdfc37e4c1@kernel.org>
On 05/09/2024 14:11, Krzysztof Kozlowski wrote:
> On 05/09/2024 14:05, Konrad Dybcio wrote:
>> On 4.09.2024 1:16 PM, Caleb Connolly wrote:
>>> The secondary USB controller on the rb3gen2 is routed directly to a
>>> mico-USB port where it can be used for EUD debugging or in OTG mode.
>>>
>>> Configure the controller to prefer peripheral mode (as this is almost
>>> always more useful) and describe the connector, vbus supply, and ID pin.
>>>
>>> OTG/Host mode is untested as I don't have micro-USB OTG cables to hand.
>>>
>>> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
>>> ---
>>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 69 ++++++++++++++++++++++++++++
>>> 1 file changed, 69 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>>> index 513d5265bb13..fe66f589cb5b 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>>> @@ -62,8 +62,30 @@ hdmi_con: endpoint {
>>> };
>>> };
>>> };
>>>
>>> + connector-usb2 {
>>> + compatible = "gpio-usb-b-connector";
>>> + vbus-gpio = <&pm7325_gpios 9 GPIO_ACTIVE_HIGH>;
>>> + id-gpio = <&tlmm 61 GPIO_ACTIVE_HIGH>;
>>
>> I don't think this is right, what's the revision of the board you have?
Still don't have schematics, this is based on downstream Qualcomm Linux.
>
> For sure any 'gpio' property is NAK and there is no way this passed
> checks...
ahh, gpios not gpio right?
sorry, should have caught this.
>
> Best regards,
> Krzysztof
>
--
// Caleb (they/them)
next prev parent reply other threads:[~2024-09-09 11:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 11:16 [PATCH 0/3] arm64: dts: qcom: rb3gen2: add second USB port Caleb Connolly
2024-09-04 11:16 ` [PATCH 1/3] arm64: dts: qcom: sc7280: convert usb_2 to support multiple ports Caleb Connolly
2024-09-04 11:16 ` [PATCH 2/3] arm64: dts: qcom: qcs6490-rb3gen2: make node names consistent Caleb Connolly
2024-09-04 11:16 ` [PATCH 3/3] arm64: dts: qcom: qcs6490-rb3gen2: describe secondary USB port Caleb Connolly
2024-09-05 12:05 ` Konrad Dybcio
2024-09-05 12:11 ` Krzysztof Kozlowski
2024-09-09 11:00 ` Caleb Connolly [this message]
2024-09-09 16:54 ` Krzysztof Kozlowski
2024-09-04 13:36 ` [PATCH 0/3] arm64: dts: qcom: rb3gen2: add second " Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98222e56-d382-409c-9c17-a99cab08ec94@linaro.org \
--to=caleb.connolly@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).