public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	wim@iguana.be, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
	paul@crapouillou.net
Subject: Re: [PATCH 1/2] dt: watchdog: Add DT binding documentation for jz47xx watchdog timer
Date: Wed, 28 Jan 2015 12:23:48 +0100	[thread overview]
Message-ID: <9831838.T0biTLFe1N@wuerfel> (raw)
In-Reply-To: <54C8B974.8030703@imgtec.com>

On Wednesday 28 January 2015 10:27:00 Zubair Lutfullah Kakakhel wrote:
> 
> There is on-going work to fix jz4740, add jz4780 and shake the entire clock tree as well.
> 
> Patch 14 onwards in this series
> http://patchwork.linux-mips.org/bundle/paulburton/ci20-v3.20/

Right, that looks good.
 
> Instead of lumping things out in huge changesets, I intended to push out the minor patches that are disjoint.
> 
> That was the purpose of sending these two patches.
> 
> Current binding requires the clock-name to be "rtc". Hence the name at the moment.

The problem with the binding is that once you've established it, it
is very hard to change. One possible solution would be to try
'of_clk_get(dev->of_node, 0)' in the driver first, and only then
call clk_get(dev, "rtc"). Doing that, you can have an anonymous clock
in the DT without waiting for the clock driver to get merged first
or breaking the existing setup.

	Arnd

  reply	other threads:[~2015-01-28 11:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 15:11 [PATCH 0/2] watchdog: jz4740: Add DT support Zubair Lutfullah Kakakhel
2015-01-27 15:11 ` [PATCH 1/2] dt: watchdog: Add DT binding documentation for jz47xx watchdog timer Zubair Lutfullah Kakakhel
     [not found]   ` <1422371490-44402-2-git-send-email-Zubair.Kakakhel-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2015-01-27 16:30     ` Guenter Roeck
2015-01-27 20:16     ` Arnd Bergmann
2015-01-27 20:52       ` Guenter Roeck
2015-01-27 21:29         ` Arnd Bergmann
2015-01-27 22:19           ` Guenter Roeck
     [not found]             ` <20150127221909.GA21671-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-01-27 22:36               ` Arnd Bergmann
2015-01-27 22:42                 ` Arnd Bergmann
2015-01-28 10:27                   ` Zubair Lutfullah Kakakhel
2015-01-28 11:23                     ` Arnd Bergmann [this message]
     [not found] ` <1422371490-44402-1-git-send-email-Zubair.Kakakhel-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2015-01-27 15:11   ` [PATCH 2/2] watchdog: jz4740: Add DT support Zubair Lutfullah Kakakhel
     [not found]     ` <1422371490-44402-3-git-send-email-Zubair.Kakakhel-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2015-01-27 16:31       ` Guenter Roeck
2015-01-27 20:15       ` Arnd Bergmann
2015-01-27 20:54         ` Guenter Roeck
     [not found]           ` <20150127205430.GB6983-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-01-27 21:23             ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9831838.T0biTLFe1N@wuerfel \
    --to=arnd@arndb.de \
    --cc=Zubair.Kakakhel@imgtec.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=paul@crapouillou.net \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox