From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] iommu/ipmmu-vmsa: Include SoC part number in DT binding docs Date: Mon, 19 Oct 2015 09:44:04 +0300 Message-ID: <9833652.FLB0aRvpVP@avalon> References: <20151019031003.7878.28510.sendpatchset@little-apple> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20151019031003.7878.28510.sendpatchset@little-apple> Sender: linux-sh-owner@vger.kernel.org To: Magnus Damm Cc: devicetree@vger.kernel.org, mark.rutland@arm.com, laurent.pinchart+renesas@ideasonboard.com, geert+renesas@glider.be, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, joro@8bytes.org, linux-sh@vger.kernel.org, iommu@lists.linux-foundation.org, robh+dt@kernel.org, galak@codeaurora.org, horms+renesas@verge.net.au List-Id: devicetree@vger.kernel.org Hi Magnus, Thank you for the patch. On Monday 19 October 2015 12:10:03 Magnus Damm wrote: > From: Magnus Damm > > Add part numbers for APE6 and current set of R-Car Gen2 SoCs to the > IPMMU DT binding documentation. The example is also updated to show > how the generic compatible string may be used as fallback. I'd use a wording stronger than "may" here, as the generic compatible value is required. I would also explicitly state that in the bindings documentation. > Signed-off-by: Magnus Damm > --- > > Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.txt | 12 > ++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) > > --- 0001/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.txt > +++ > work/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.txt 2015-10 > -18 15:53:08.850513000 +0900 @@ -7,7 +7,15 @@ connected to the IPMMU through > a port ca > > Required Properties: > > - - compatible: Must contain "renesas,ipmmu-vmsa". > + - compatible: Must contain one of the following: > + > + - "renesas,ipmmu-r8a73a4" for the R8A73A4 (R-Mobile APE6) IPMMU. > + - "renesas,ipmmu-r8a7790" for the R8A7790 (R-Car H2) IPMMU. > + - "renesas,ipmmu-r8a7791" for the R8A7791 (R-Car M2-W) IPMMU. > + - "renesas,ipmmu-r8a7793" for the R8A7793 (R-Car M2-N) IPMMU. > + - "renesas,ipmmu-r8a7794" for the R8A7794 (R-Car E2) IPMMU. > + - "renesas,ipmmu-vmsa" for generic R-Car Gen2 VMSA-compatible IPMMU. > + > - reg: Base address and size of the IPMMU registers. > - interrupts: Specifiers for the MMU fault interrupts. For instances that > support secure mode two interrupts must be specified, for non-secure and @@ > -27,7 +35,7 @@ node with the following property: > Example: R8A7791 IPMMU-MX and VSP1-D0 bus master > > ipmmu_mx: mmu@fe951000 { > - compatible = "renasas,ipmmu-vmsa"; > + compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa"; > reg = <0 0xfe951000 0 0x1000>; > interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>, > <0 221 IRQ_TYPE_LEVEL_HIGH>; -- Regards, Laurent Pinchart