devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sdm845: move sound node out of soc
Date: Sat, 10 Dec 2022 13:27:47 +0100	[thread overview]
Message-ID: <985e763d-2fa3-4c0c-4970-7c4b47c162c7@linaro.org> (raw)
In-Reply-To: <20221210115704.97614-3-krzysztof.kozlowski@linaro.org>



On 10.12.2022 12:57, Krzysztof Kozlowski wrote:
> The sound node is not a property of a soc, but rather board as it
> describes the sound configuration.  It also does not have unit address:
> 
>   sdm845-shift-axolotl.dtb: soc@0: sound: {} should not be valid under {'type': 'object'}
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 573b2394e63f..14a409f22bfd 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -3972,9 +3972,6 @@ lmh_cluster0: lmh@17d78800 {
>  			#interrupt-cells = <1>;
>  		};
>  
> -		sound: sound {
> -		};
> -
>  		usb_1_hsphy: phy@88e2000 {
>  			compatible = "qcom,sdm845-qusb2-phy", "qcom,qusb2-v2-phy";
>  			reg = <0 0x088e2000 0 0x400>;
> @@ -5349,6 +5346,9 @@ wifi: wifi@18800000 {
>  		};
>  	};
>  
> +	sound: sound {
> +	};
> +
>  	thermal-zones {
>  		cpu0-thermal {
>  			polling-delay-passive = <250>;

  reply	other threads:[~2022-12-10 12:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-10 11:57 [PATCH 1/4] arm64: dts: qcom: sc7180: move QUP and QSPI opp tables out of SoC node Krzysztof Kozlowski
2022-12-10 11:57 ` [PATCH 2/4] arm64: dts: qcom: sdm845: move DSI/QUP/QSPI " Krzysztof Kozlowski
2022-12-10 12:28   ` Konrad Dybcio
2022-12-10 11:57 ` [PATCH 3/4] arm64: dts: qcom: sdm845: move sound node out of soc Krzysztof Kozlowski
2022-12-10 12:27   ` Konrad Dybcio [this message]
2022-12-10 11:57 ` [PATCH 4/4] arm64: dts: qcom: sm8250: move sound and codec nodes " Krzysztof Kozlowski
2022-12-10 12:31   ` Konrad Dybcio
2022-12-11 20:13     ` Krzysztof Kozlowski
2022-12-11 21:15       ` Dmitry Baryshkov
2022-12-12  8:43         ` Krzysztof Kozlowski
2022-12-12  9:12       ` Konrad Dybcio
2022-12-10 12:29 ` [PATCH 1/4] arm64: dts: qcom: sc7180: move QUP and QSPI opp tables out of SoC node Konrad Dybcio
2022-12-11 20:14   ` Krzysztof Kozlowski
2022-12-12  9:15     ` Konrad Dybcio
2022-12-12  9:17       ` Krzysztof Kozlowski
2022-12-12  9:18         ` Konrad Dybcio
2022-12-12  9:24           ` Krzysztof Kozlowski
2022-12-28  4:36 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=985e763d-2fa3-4c0c-4970-7c4b47c162c7@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).