From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD6EC43334 for ; Mon, 6 Jun 2022 15:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241199AbiFFP5P (ORCPT ); Mon, 6 Jun 2022 11:57:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241168AbiFFP5I (ORCPT ); Mon, 6 Jun 2022 11:57:08 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89AF013DF7 for ; Mon, 6 Jun 2022 08:57:07 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id j10so23967009lfe.12 for ; Mon, 06 Jun 2022 08:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=YdNQsAh0qlk4u0zBBVjDkzwiH9R4DqegW0uwFh+QZew=; b=Ry/wQFW21izQYCGVPxoTTQkGOePxLZ94A6g0x0GNQyIisRWf063vJSA9VrU6GHiNBJ 8tX5GNA2Q/evL4mMqDhUdJP/XblS2pNXJtKFL8BB5v4nSP+/BNMhEhM9eY7ndE8sqpEd NkWhDGj2l5I1giLnh5G/k9ykB4AhicZpUHfTpl4a7itRpZQZCBNjxW0TpeS0DEfpLCEq 7t7VYoei6nEklWuuJEgdUFWGJf+1zQYE2oQABaGRbJMLdBv33H3GUPn4rT1nEKFh3veh RPLBYhzEFDxkR+/0tKBtIVmloJoLJgeszvSZkxPXZxRz3EfvLAY/vnmGSAsT1MzflzY2 jsxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YdNQsAh0qlk4u0zBBVjDkzwiH9R4DqegW0uwFh+QZew=; b=F34ndbByuNv1ZQ27KsBFYxZ8SFfHKckBJVLEgHE9hMBRoTtUN/Pa0wcRREJapsL7WN fMVPNcTZwuQB1wBFmf+BIacsERYj1cWWcUrSeWfIm7BklP3Gr52XGHTMdmDduPPyRu7F EhvPeHtQX+xzw9iBy8hu+0oB5qUXcH/45SNn5R6iiqupl5MYfh3W77JO+qeGOuMWAeEX wn0uwxN7JYvt5rcQP41hxBpNE2vYIWF6xse4PCYTOFm1Wq/M6AO0qHw5SKxQuXfR4mHG Y8WmLco1CpUH0SBu3PImOKCDttQSI9AbRZgvZAuyBEx+SW6pTIsTp+fXToHv1U8eEkhf CPOA== X-Gm-Message-State: AOAM530Ieb1QfAUWVZ4hADYlIEME8D3lBoPywagE3DL+KkRkpIUIc88A yF5VoNWL9xJqMfC7Htoqg00iQQ== X-Google-Smtp-Source: ABdhPJxanyqAWNvCGkqFfFiDr0g6eEVU9GfHoKUKyz3jwWQBwP8oldiA+lJj0xPi8o4Z+6YdMBM3Yw== X-Received: by 2002:ac2:5b08:0:b0:479:16ed:e624 with SMTP id v8-20020ac25b08000000b0047916ede624mr11946145lfn.618.1654531025868; Mon, 06 Jun 2022 08:57:05 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id j22-20020a056512345600b00478ed85bc92sm2906342lfr.249.2022.06.06.08.57.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jun 2022 08:57:04 -0700 (PDT) Message-ID: <9872153f-8f46-23c3-6eb7-154d20fdee5b@linaro.org> Date: Mon, 6 Jun 2022 18:57:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] arm64: dts: qcom: sm8450: fix interconnects property of UFS node Content-Language: en-GB To: Vinod Koul , Vladimir Zapolskiy Cc: Bjorn Andersson , Andy Gross , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20220310221934.1560729-1-vladimir.zapolskiy@linaro.org> <2af9a8a7-0904-df31-7c1a-21705bcda8d6@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/04/2022 14:17, Vinod Koul wrote: > On 12-04-22, 09:34, Vladimir Zapolskiy wrote: >> Hi Bjorn, >> >> On 4/12/22 05:35, Bjorn Andersson wrote: >>> On Tue 05 Apr 12:38 CDT 2022, Dmitry Baryshkov wrote: >>> >>>> On Tue, 5 Apr 2022 at 20:17, Bjorn Andersson wrote: >>>>> >>>>> On Tue 05 Apr 08:38 PDT 2022, Dmitry Baryshkov wrote: >>>>> >>>>>> On 11/03/2022 01:19, Vladimir Zapolskiy wrote: >>>>>>> All interconnect device tree nodes on sm8450 are 2-cells, however in >>>>>>> UFS node they are handled as 1-cells, fix it. >>>>>>> >>>>>>> Fixes: aa2d0bf04a3c ("arm64: dts: qcom: sm8450: add interconnect nodes") >>>>>>> Signed-off-by: Vladimir Zapolskiy >>>>>> >>>>>> Reviewed-by: Dmitry Baryshkov >>>>>> >>>>>> Bjorn, could you please this pick for the -rc kernel? >>>>>> >>>>> >>>>> The change is obviously correct, but what difference does this change >>>>> make with the current implementation? >>>> >>>> it makes interconnect paths probe correctly. All NoC have >>>> #interconnec-cells = <2> now. >>>> >>> >>> But there's no code in the UFS driver that calls of_icc_get(), so what >>> does this actually do? (Other than correcting the dtb for the day when >>> we add that support to the driver). >> >> FWIW the change also has a runtime effect, it fixes a parsing of the board dtb, >> otherwise a warning in the kernel log appears: >> >> OF: /soc@0/ufshc@1d84000: could not get #interconnect-cells for /clocks/sleep-clk >> >> Why /clocks/sleep-clk is mentioned here at all?? >> Its phandle value is 0x26, which is equal to SLAVE_UFS_MEM_CFG from the array. > > We should either apply this fix or a patch to drop this line from dts. > Either would be apt and latter would make more sense.. So, neither of the patches were applied. I'd suggest to apply this one now during the -rc stage. -- With best wishes Dmitry