From: Krzysztof Kozlowski <krzk@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>, dlemoal@kernel.org, cassel@kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
sebastian.reichel@collabora.com, linux-ide@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
u.kleine-koenig@baylibre.com
Subject: Re: [PATCH] dt-bindings: ata: rockchip-dwc-ahci: add missing power-domains
Date: Sun, 21 Jul 2024 12:21:33 +0200 [thread overview]
Message-ID: <988784e7-ffeb-4e87-a18a-64fd5cb17776@kernel.org> (raw)
In-Reply-To: <20240720205705.776384-1-heiko@sntech.de>
On 20/07/2024 22:57, Heiko Stuebner wrote:
> The Rockchip variant of the dwc-ahci controller does have and need power-
> domains to work, though the binding does not mention them, making dtccheck
> quite unhappy:
>
> DTC_CHK arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dtb
> /home/devel/hstuebner/00_git-repos/linux-rockchip/_build-arm64/arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dtb: sata@fc800000: Unevaluated properties are not allowed ('power-domains' was unexpected)
> from schema $id: http://devicetree.org/schemas/ata/rockchip,dwc-ahci.yaml#
>
> Fix that by adding the missing power-domain property to the binding.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-21 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-20 20:57 [PATCH] dt-bindings: ata: rockchip-dwc-ahci: add missing power-domains Heiko Stuebner
2024-07-21 10:21 ` Krzysztof Kozlowski [this message]
2024-07-22 1:15 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=988784e7-ffeb-4e87-a18a-64fd5cb17776@kernel.org \
--to=krzk@kernel.org \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).