From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Richard Acayan <mailingradian@gmail.com>, linux-arm-msm@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/3] dt-bindings: dma: qcom: gpi: add fallback compatible
Date: Mon, 17 Oct 2022 17:37:26 -0400 [thread overview]
Message-ID: <98c595dc-0dfb-e87d-aa1e-38198f942525@linaro.org> (raw)
In-Reply-To: <20221007213640.85469-2-mailingradian@gmail.com>
On 07/10/2022 17:36, Richard Acayan wrote:
> The drivers are transitioning from matching against lists of specific
> compatible strings to matching against smaller lists of more generic
> compatible strings. Use the SDM845 compatible string as a fallback in
> the schema to support this change.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/dma/qcom,gpi.yaml | 21 ++++++++++++-------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> index eabf8a76d3a0..081b8a2d393d 100644
> --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> @@ -18,14 +18,19 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - qcom,sc7280-gpi-dma
> - - qcom,sdm845-gpi-dma
> - - qcom,sm6350-gpi-dma
> - - qcom,sm8150-gpi-dma
> - - qcom,sm8250-gpi-dma
> - - qcom,sm8350-gpi-dma
> - - qcom,sm8450-gpi-dma
> + oneOf:
> + - enum:
> + - qcom,sc7280-gpi-dma
> + - qcom,sdm845-gpi-dma
> + - qcom,sm6350-gpi-dma
> + - qcom,sm8350-gpi-dma
> + - qcom,sm8450-gpi-dma
> +
Drop the empty line, please.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-17 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 21:36 [PATCH v5 0/3] SDM670 GPI DMA support Richard Acayan
2022-10-07 21:36 ` [PATCH v5 1/3] dt-bindings: dma: qcom: gpi: add fallback compatible Richard Acayan
2022-10-17 21:37 ` Krzysztof Kozlowski [this message]
2022-10-07 21:36 ` [PATCH v5 2/3] dt-bindings: dma: qcom: gpi: add compatible for sdm670 Richard Acayan
2022-10-07 21:36 ` [PATCH v5 3/3] dmaengine: qcom: deprecate redundant of_device_id entries Richard Acayan
2022-10-17 21:06 ` [PATCH v5 0/3] SDM670 GPI DMA support Richard Acayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98c595dc-0dfb-e87d-aa1e-38198f942525@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).